Received-SPF: pass (google.com: domain of linux-kernel+bounces-198807-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 3 Jun 2024 09:25:11 +0100
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Arthur Becker <arthur.becker@sentec.com>
CC: Jonathan Cameron <jic23@kernel.org>, Krzysztof Kozlowski
	<krzk@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring
	<robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
	<conor+dt@kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-iio@vger.kernel.org"
	<linux-iio@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS
 bindings
Message-ID: <20240603092511.0000391e@Huawei.com>
In-Reply-To: <ZR1P278MB1117EE8AFDD8891EE6459CEC81FF2@ZR1P278MB1117.CHEP278.PROD.OUTLOOK.COM>
References: <20240527-veml6040-v3-0-6f3bbfd42960@sentec.com>
	<20240527-veml6040-v3-2-6f3bbfd42960@sentec.com>
	<e47de936-8cb4-4cef-a346-74835767e203@kernel.org>
	<ZR1P278MB111779FE0C84DB465C54EEFF81F12@ZR1P278MB1117.CHEP278.PROD.OUTLOOK.COM>
	<20240602141617.533558c4@jic23-huawei>
	<ZR1P278MB1117EE8AFDD8891EE6459CEC81FF2@ZR1P278MB1117.CHEP278.PROD.OUTLOOK.COM>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Mon, 3 Jun 2024 08:23:55 +0000
Arthur Becker <arthur.becker@sentec.com> wrote:

> From: Jonathan Cameron <jic23@kernel.org>
> Sent: 02 June 2024 15:16
> To: Arthur Becker
> Cc: Krzysztof Kozlowski; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> > On Tue, 28 May 2024 07:23:03 +0000
> > Arthur Becker <arthur.becker@sentec.com> wrote:
> >   
> > > Thanks for the Review!
> > > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> > > I'll modify that the next time I make adjustments to the driver.  
> >
> > Hi Arthur,
> >
> > If I read the above correctly you are hoping this merges as it stands and
> > we come back later. If we are going to combine them long term,
> > I'd rather we avoided the churn and had a combined DT binding from the start.  
> 
> Hi Jonathan,
> 
> I could have phrased that better, what I meant was that I was waiting for the next
> feedback on the driver to make the adjustments all at once.
> I'll get to it shortly!

Great :)

Thanks,

Jonathan

> 
> Kind Regards,
> Arthur
> 
> >
> > Jonathan
> >  
> > >
> > > Kind regards,
> > > Arthur
> > >
> > > ________________________________________
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: 27 May 2024 18:31
> > > To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> > > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> > > Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> > >
> > > On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:  
> > > > From: Arthur Becker <arthur.becker@sentec.com>
> > > >
> > > > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > > > driver
> > > >
> > > > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > > > ---
> > > > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > > > along with v2 of the driver but not in a set)  
> > >
> > > It's basically the same as veml6075, so should be put there...
> > >
> > > Eh,
> > >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > >
> > > Best regards,
> > > Krzysztof
> > >  
>