Received-SPF: pass (google.com: domain of linux-kernel+bounces-198809-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <37e0f1cd-d6b4-4b7c-b386-7d31423ac7c8@intel.com>
Date: Mon, 3 Jun 2024 10:45:57 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2 net-next] devlink: Constify the 'table_ops' parameter
 of devl_dpipe_table_register()
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, <idosch@nvidia.com>,
	<petrm@nvidia.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <jiri@resnulli.us>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
References: <cover.1717337525.git.christophe.jaillet@wanadoo.fr>
 <3d1deee6bb5a31ee1a41645223fa8b4df1eef7ba.1717337525.git.christophe.jaillet@wanadoo.fr>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <3d1deee6bb5a31ee1a41645223fa8b4df1eef7ba.1717337525.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2EvOUVkbmN2SDZYVFNhVmRjZ2hLbFkrbld1UWxabUdoWmNoRnhVVmZGY3Y4?=
 =?utf-8?B?U2ZZTGk4dG1uRkhTZjVRQzgzcVJoS3FXTE5qbk16QVhqcUp4SkxRWVRvbHVK?=
 =?utf-8?B?VkE3ZmM1WG1ISnJYZDk2bVVjSnpGSzZKcldGSnM5ZGhtTVpjK2oxSWtFOEFC?=
 =?utf-8?B?dDY2NDlqSERiS3A0aU5nZ01Bd09WdTN3dWVGUzByYzJYa2VPV1lyRHVyYWF2?=
 =?utf-8?B?cDNjT1BaSUJkdThJNGRYMnhVQnhHWWdZS2VGaEk1eDdrdm5IWWNNRzRXUU83?=
 =?utf-8?B?ZGpUNUJ3cmRkeU1oR0J6MjNhNitWT2Z6ajduLzVBWmtkSm9QeHBYcjc5c2NX?=
 =?utf-8?B?a095S2lGS1FaVC9ZL0UxblNaQzJJSzNOMnhISTlHOHZUUHQ2Wlp1NUVZQmc2?=
 =?utf-8?B?UlFicHdOQ1B1SkJXbzY3Njh3NkFZMHcvRkpzcGhLamRYV3RWS3dSVnV6QVBI?=
 =?utf-8?B?ZUxKN3ZGTEVuQzdDaVpTbjNOUllUOU1NRFNhU3h4VlNQM3oyaDY3NGYvQWps?=
 =?utf-8?B?ZE54Q0hPWWdoRURzc0pSU2c1d1ErdGpWNkx2MW9INTNUMUZ0NWNud2xqSXVG?=
 =?utf-8?B?Tmx6QlNDWEREaHdxVlZZQ0dsSzcxeG9FemlUMGNyNTAzaXBVenozUVBnNjdS?=
 =?utf-8?B?NWpIMGdmU1h3TW1Kc3lNZ1ZuTWZmTDBnd1lESEFGRkZoRTZoZmVjS2VsM3ZC?=
 =?utf-8?B?ZkNvMGJ5OWVqdEcxTmVSWFhBandjMFVGMXpPWDRyNkpwVUVSTDAvcm9saGZF?=
 =?utf-8?B?R1crRVpTNjd5Qyt4eEV2L0hFSnNGN1l4TzZkQzdzSVFQS0p3aWpBZ21aN3Bp?=
 =?utf-8?B?S0tweDdSN280ZWRsczJqOXpUYTdMNGVqRWk2MTJaZmtLajZCSi9nWXRhbkZM?=
 =?utf-8?B?NjhzZDkzVjlrdWUyeVgzZkp3cHZWcVlJOVZWdzNjdXc0eUp0YmFPSGtWc3FC?=
 =?utf-8?B?eU9RUEZkdEQ1bmYyWTlJM2Z0ZnBtaHN5dU10Sk1STlZxcng1NldkSTU5cTFS?=
 =?utf-8?B?RklZRkRoOUpCMWpNRldtK3NkT1dnejkwU3JlWUVyTDdCSU5rcU9LeFA5dmdZ?=
 =?utf-8?B?MytXdmxNbE9HemlPRTNTRU5hUGdGYkhsbWlrUmhwcmJOVlJ4cG91eDdLTWEw?=
 =?utf-8?B?bGNUZ1RFVlNPa2x5ejlJRi9iZHdyRTBlb2ZxdjdodDNXRENRNEh0bXAzQjZm?=
 =?utf-8?B?VE5JVFNJUk5CejUrT3ljemRYbUhVNzVKZjNYY2ZIR2luSjhpeFltREZab014?=
 =?utf-8?B?eGZIeGN6ZTh5TGlXSTA3L2lCU0hCcXU5NU5DT1poUi80dWNtZlFTS050OG9s?=
 =?utf-8?B?TzdXUFVLeVBKRndaMERPcWRpazhMTlgzaGN4YnpadStMQU5VRUVsWDFPMkh6?=
 =?utf-8?B?MlpvL0F3Z2dFRTU2MmpWclBaMmhULzlTVU1WUFZpaHRuMDc4emlrZ21vMzVh?=
 =?utf-8?B?WFl0VGRDRFFnSzNsM3ZZeW01dmdnS05XYmltZU9EZXNkMkZ5aWQ0cmdhdFBm?=
 =?utf-8?B?b3NyS0Vad0xCSDZXSTJGdndVUWZHYUlTWmdXZTJXZ21zbElwbFhKaTM1RmIr?=
 =?utf-8?B?OVJBMndHbnhDNnZZc0RIeGJWYjRnU1J6WnZXOExpbmphdC9iQmR2dExZMFZK?=
 =?utf-8?B?RW9Dck5mYkJCR3krek5rSU1vQWlpdzhzRVppWVhEYzh1dzVZR0hYRm5oMWhQ?=
 =?utf-8?B?dTlPbFFQUko3aDJ6Zm5kK3oxYyszbG5vbjgxeVV4TTNsUWx3Y2JXZVoxYnZZ?=
 =?utf-8?B?alowdUltS083aVZHY2pQTXI1cDhCbm05dHFNQ0ZOK1kzcll1Qmltalppd2hW?=
 =?utf-8?B?NjIzMzF0d2xrdXpYeFMwUDBXUjlvRlNzNldjcHhrM29XR093ek9uUHlzL1Rp?=
 =?utf-8?B?SExlVVBWcC9Ua1NpbHJtZkNpWWR3S2FSeERHbDZQbklnRUdsbkN2YjFoTksv?=
 =?utf-8?B?aUdGMit0R0wvTnJoajVTQlIwR1p6TEpidGZJSFZlcHZHN21PbjZaV2dQeXor?=
 =?utf-8?B?Z0wxcFBmcmdrRi82ZDdRdUtNK0srUHlKb3E1ako2cUFJVmx4eUtqSkFma0NR?=
 =?utf-8?B?ZFpmbHJubm9kR3lrank0Q3E5N1ROcXduM010b3FBQS9iRkd2UnB4UEV3UDZt?=
 =?utf-8?B?MHNkWlBmMTI4NkZEU2Qrc2lxSk9POEZ0NHhnZGoyRHY4SjkyQ3dOMVdyNHlo?=
 =?utf-8?B?aGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 71021f48-ee23-4d6c-7f16-08dc83a9997e
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 08:46:02.9936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 86goQEOCAoWh5HjM8/zpcNn/qQf1uKscqon7PvxnlXc1YSo4KNyIr2kJQkk3xK1FhMZNcDRIkVMbPcEWFyr1ZkIoPuJlmQpbMRTeAr6aSPs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7450
X-OriginatorOrg: intel.com


On 02.06.2024 16:18, Christophe JAILLET wrote:
> "struct devlink_dpipe_table_ops" only contains some function pointers.
> 
> Update "struct devlink_dpipe_table" and the 'table_ops' parameter of
> devl_dpipe_table_register() so that structures in drivers can be
> constified.
> 
> Constifying these structures will move some data to a read-only section, so
> increase overall security.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  include/net/devlink.h | 4 ++--
>  net/devlink/dpipe.c   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/net/devlink.h b/include/net/devlink.h
> index 35eb0f884386..db5eff6cb60f 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -352,7 +352,7 @@ struct devlink_dpipe_table {
>  	bool resource_valid;
>  	u64 resource_id;
>  	u64 resource_units;
> -	struct devlink_dpipe_table_ops *table_ops;
> +	const struct devlink_dpipe_table_ops *table_ops;
>  	struct rcu_head rcu;
>  };
>  
> @@ -1751,7 +1751,7 @@ void devl_sb_unregister(struct devlink *devlink, unsigned int sb_index);
>  void devlink_sb_unregister(struct devlink *devlink, unsigned int sb_index);
>  int devl_dpipe_table_register(struct devlink *devlink,
>  			      const char *table_name,
> -			      struct devlink_dpipe_table_ops *table_ops,
> +			      const struct devlink_dpipe_table_ops *table_ops,
>  			      void *priv, bool counter_control_extern);
>  void devl_dpipe_table_unregister(struct devlink *devlink,
>  				 const char *table_name);
> diff --git a/net/devlink/dpipe.c b/net/devlink/dpipe.c
> index a72a9292efc5..55009b377447 100644
> --- a/net/devlink/dpipe.c
> +++ b/net/devlink/dpipe.c
> @@ -839,7 +839,7 @@ EXPORT_SYMBOL_GPL(devlink_dpipe_table_counter_enabled);
>   */
>  int devl_dpipe_table_register(struct devlink *devlink,
>  			      const char *table_name,
> -			      struct devlink_dpipe_table_ops *table_ops,
> +			      const struct devlink_dpipe_table_ops *table_ops,
>  			      void *priv, bool counter_control_extern)
>  {
>  	struct devlink_dpipe_table *table;