Received-SPF: pass (google.com: domain of linux-kernel+bounces-198810-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <49b0247f-f2df-4b28-abeb-520901a3a153@intel.com>
Date: Mon, 3 Jun 2024 10:46:15 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2 net-next] mlxsw: spectrum_router: Constify struct
 devlink_dpipe_table_ops
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, <idosch@nvidia.com>,
	<petrm@nvidia.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <jiri@resnulli.us>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
References: <cover.1717337525.git.christophe.jaillet@wanadoo.fr>
 <6d79c82023fd7e3c4b2da6ac92ecf478366e8dca.1717337525.git.christophe.jaillet@wanadoo.fr>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <6d79c82023fd7e3c4b2da6ac92ecf478366e8dca.1717337525.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXNldFdGRGVDamlpdzEzeGt3UWttK0N4bFJXUXF1THFMWXVvZVJsRXpsZ3dT?=
 =?utf-8?B?OFAxL3ZTMzNWMEZpZmNWNmNXV0VXN3hySUMvSHZiUldIN01rTVBpaXZiWEZm?=
 =?utf-8?B?TlFTMzlOYkJXYmhZMTBldWpVMExPS3NrNDkwWU5QV0EvQmJ0Nzk3dmdMWjAz?=
 =?utf-8?B?bHhJcUg5TU5FRm5CZzVrVWZjSDA5ZTI1VTA0dmVxYkRjeGFQRUVyUzBtdjNs?=
 =?utf-8?B?QVJ6R1hieVRuOStJbGlGd0tNRG13N3BXVUN6RU9jaHhvRVJ6SVd5ZS9kMmV5?=
 =?utf-8?B?RWErQVQrb3g0Y3h4MGwwclU2endnNDlGWWVkSERDUUJnS2ZRTkE2Sk0yWHJN?=
 =?utf-8?B?dWtObzJFdmhkV2pvNGUzWkFOTE5OWEMyRDJnUjJHYytaUk80UHlISVBLMjBp?=
 =?utf-8?B?TURQL25FS3BXRHNYN0VQOXAyems2bDVQVWptdjVyd1JzemEvOE5XVngvOFY5?=
 =?utf-8?B?bHU5QjF2SlRKbmdORWRKaWRZcndOdTU5dXlYcEpxbE5kOHphMEhDSU9VVGxx?=
 =?utf-8?B?L1VjODNydllManYrTVJiU3RoeThPZnY0ekFKRTdybWRtcG1HNFZLRVMvdnNC?=
 =?utf-8?B?QTBOU3ZBRkU2U2JJNzJ1WE9wNTNSd1lNd3RPUEFVMlQyUjdkRzhld3gvcFo0?=
 =?utf-8?B?N3pNUGRKWGtrTCtkWDJGbGU0c1h3Z2NVdiszL1VGMkRWWWVoYzdNaWgzUG9X?=
 =?utf-8?B?M2dWNTU0d3IxNXhubFkrcjQwQnpHR0VSRUplakxxNkhpV2JJYjlrU25GZU1p?=
 =?utf-8?B?M0xiSDRVak9iMDRoRGtIWFNBRC9JNTBqOURjRDBCa09jV3JBbCs3M1o4UDdj?=
 =?utf-8?B?Z1ExVlcwZWxXdzhSWm96Q1paNlkyWHJwMzJudGd3RFpVUDVPVVZmYURRTDlq?=
 =?utf-8?B?NldwbGtSeFpuaFJSYXg3djZDMlFOMnEyaWVyeXc1N3RoaWhHQ3YyY3dIWFVq?=
 =?utf-8?B?N3lObVh4SGZtZlBZQTRCUUdiYW1KVjNaOHJvVzNwSEpIMnk3YjduaXN5NCs0?=
 =?utf-8?B?V0Fndjk2STExdkFQSDZhWGtkRGpjY2pjcE4zdTFTR2h3Z0tEbmFEVUplS2h0?=
 =?utf-8?B?OE55VURDWjZWM1ltNjdJZ0x6S2h2WC9MRTN4NG93SWpDRXp0N3FxS0VmU29w?=
 =?utf-8?B?VUdjNEpQNnNSSmZSanJZblpxQk51OWZIVjdOanBTbGpraHhpS0lZbE5adWJO?=
 =?utf-8?B?aGQ2dnllTnNPczJISnlCL2FPeERFakFrZTdkK1A2N0djUjFEa0tuc2d4MjVz?=
 =?utf-8?B?ZnNxd2hpeHRqbmxMLzNhMzZNWVBPbEd3a3VmcVNpVmNCMGJXdmlOU3JWRG1j?=
 =?utf-8?B?SWZUdEVsbHIzbTJMSG13NmZnc2RHMDdFWndzVDZBUlZFTG9udm9vVjhmaDcv?=
 =?utf-8?B?VUlFcnUzR3JBbk5oOFp5ZEE1R202c2Q4ajhFNUx1MTdGcXowRU1sV3dXTHhG?=
 =?utf-8?B?YlYwYWsyYnhuSHZuQ1RrODVodTk5enhMVG53eTE2eFJPRkNXWGNKMnVCeWZu?=
 =?utf-8?B?bW00anRRa3I3aGcwZm9wNGFFTllzQjc5SVZkbm5ib2dZbzZrbXl5QUs5SHc5?=
 =?utf-8?B?ek1Yc1BscDhEZGJKZHhJV295aUQzdFZCTHNoT0tmZEc3L3NCK1I1NEl0Y0Zl?=
 =?utf-8?B?OWNkakZGMkNjV0liZUdNTGk4aVFyMTBEQmhxQ2FZSndpZU1XOGxJdXgzbzRp?=
 =?utf-8?B?NkNhRzI1TktsREhTZllDTTdEMDRQSnhaL09MRlJUeGtQOGJ1TEZpVFIzTEpt?=
 =?utf-8?B?MG9ydjVjaDg5TXU2c3JJRUVoemxvdjVqakM4RTdxOExRczFWbDZZNERSUlZK?=
 =?utf-8?B?a1g1RHlSRVNCMkhXVEd6ZUhsdVN4a0lEcGV6V0NWVFFWTlpnbTExMWJ6OHlV?=
 =?utf-8?B?Qjl0UkRyOStZTXI4T01scmxuV0xodmtSUGZuamZmMlZZOGlrbmxFMWgwQ3lO?=
 =?utf-8?B?OWFyRE82TE5OMk9rUE9ucTJFUUVuSDBWQ1NKajJpeFNmVHk5WEhoUHVBaVBQ?=
 =?utf-8?B?eVFRWlNGR2NjV2prUzNNOXdJQnBtNkgwdWdmOTFBdEd5aFFNT2p1L1dsYWtm?=
 =?utf-8?B?b0xmR1pOVzVrZFJ1Q1lpbmhWazhDMlg0REdjblVZbTlmVHk3WFRPdzRWQU15?=
 =?utf-8?B?Z1BDOWlLV1Zzb25WMmI5Q3dTY2xIYzd4SzRzbW1IenBITTd0RmZlVXpDL005?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5770f0af-3dab-47f3-edd0-08dc83a9a4f6
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 08:46:22.2564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nyjaXHQBE4IhSOqQlGztuPoGKb7qUXpeUzsAGkpKrJEQE4P13EmkGcLvpcKWAtbWV5LuCUr3OVbJyuHqr+jIoxGROHYH6DiVRYNCu1UeZ78=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7450
X-OriginatorOrg: intel.com


On 02.06.2024 16:18, Christophe JAILLET wrote:
> 'struct devlink_dpipe_table_ops' are not modified in this driver.
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   15557	    712	      0	  16269	   3f8d	drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   15789	    488	      0	  16277	   3f95	drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c
> index ca80af06465f..fa6eddd27ecf 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c
> @@ -283,7 +283,7 @@ static u64 mlxsw_sp_dpipe_table_erif_size_get(void *priv)
>  	return MLXSW_CORE_RES_GET(mlxsw_sp->core, MAX_RIFS);
>  }
>  
> -static struct devlink_dpipe_table_ops mlxsw_sp_erif_ops = {
> +static const struct devlink_dpipe_table_ops mlxsw_sp_erif_ops = {
>  	.matches_dump = mlxsw_sp_dpipe_table_erif_matches_dump,
>  	.actions_dump = mlxsw_sp_dpipe_table_erif_actions_dump,
>  	.entries_dump = mlxsw_sp_dpipe_table_erif_entries_dump,
> @@ -734,7 +734,7 @@ static u64 mlxsw_sp_dpipe_table_host4_size_get(void *priv)
>  	return mlxsw_sp_dpipe_table_host_size_get(mlxsw_sp, AF_INET);
>  }
>  
> -static struct devlink_dpipe_table_ops mlxsw_sp_host4_ops = {
> +static const struct devlink_dpipe_table_ops mlxsw_sp_host4_ops = {
>  	.matches_dump = mlxsw_sp_dpipe_table_host4_matches_dump,
>  	.actions_dump = mlxsw_sp_dpipe_table_host_actions_dump,
>  	.entries_dump = mlxsw_sp_dpipe_table_host4_entries_dump,
> @@ -811,7 +811,7 @@ static u64 mlxsw_sp_dpipe_table_host6_size_get(void *priv)
>  	return mlxsw_sp_dpipe_table_host_size_get(mlxsw_sp, AF_INET6);
>  }
>  
> -static struct devlink_dpipe_table_ops mlxsw_sp_host6_ops = {
> +static const struct devlink_dpipe_table_ops mlxsw_sp_host6_ops = {
>  	.matches_dump = mlxsw_sp_dpipe_table_host6_matches_dump,
>  	.actions_dump = mlxsw_sp_dpipe_table_host_actions_dump,
>  	.entries_dump = mlxsw_sp_dpipe_table_host6_entries_dump,
> @@ -1230,7 +1230,7 @@ mlxsw_sp_dpipe_table_adj_size_get(void *priv)
>  	return size;
>  }
>  
> -static struct devlink_dpipe_table_ops mlxsw_sp_dpipe_table_adj_ops = {
> +static const struct devlink_dpipe_table_ops mlxsw_sp_dpipe_table_adj_ops = {
>  	.matches_dump = mlxsw_sp_dpipe_table_adj_matches_dump,
>  	.actions_dump = mlxsw_sp_dpipe_table_adj_actions_dump,
>  	.entries_dump = mlxsw_sp_dpipe_table_adj_entries_dump,