Received-SPF: pass (google.com: domain of linux-kernel+bounces-198834-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Bharat Bhushan <bbhushan2@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam
	<hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Jerin Jacob
	<jerinj@marvell.com>, Linu Cherian <lcherian@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>
Subject: RE: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
 ipsec transmit offload
Thread-Topic: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
 ipsec transmit offload
Thread-Index: AQHasQaTfyi6mWkXDkOBPclCj0tdJLGyuFMAgAMP14A=
Date: Mon, 3 Jun 2024 09:06:13 +0000
Message-ID: 
 <SN7PR18MB5314C837EBC54B24350DC638E3FF2@SN7PR18MB5314.namprd18.prod.outlook.com>
References: <20240528135349.932669-1-bbhushan2@marvell.com>
 <20240528135349.932669-7-bbhushan2@marvell.com>
 <20240601101930.GB491852@kernel.org>
In-Reply-To: <20240601101930.GB491852@kernel.org>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?08LZcTtI86cQALu+b/vUXX4zY3mAyqDH9agoRN2nrpwY7bnKrcMgUxvqaYIc?=
 =?us-ascii?Q?nbQvi/gZpJ6g2NQJx4HvvsnYm2oVt6jbkrupTB0LoZMg+QWF5PYrV67CZ7Vm?=
 =?us-ascii?Q?8ViRhXT5ANZaYrtBmiB6cevbyEmCyAW55lp8+SVftFoXzy1PXMmdtksmJ7Ty?=
 =?us-ascii?Q?yG7ZvbbH/T/1mqo/8ghtKsNB2EgrytVNLNZd6wSiEgoYKFxNKzydLIZX+bpB?=
 =?us-ascii?Q?weI9rLjo+RsKjGGiiol6IvxIVrTAG27ovDt/QXySnAVIlulJrG9hAco2JXHA?=
 =?us-ascii?Q?cDIfUnp3FmSbXTVczcLL2rKNZCEk6911Y1A/XRvI4oiGnE+C67F+4tILk8sg?=
 =?us-ascii?Q?EXOn2esQXi3H83C+CdV+/ySPNSIEzAtJq/2PZG/2xzhy1XSlju/EC5pkxnj/?=
 =?us-ascii?Q?lsIhjgG6IzdewfZbo8GLK+TVevdZcxEj7wWsFVytuhSCano+aD1WJ4TJM3cn?=
 =?us-ascii?Q?+65kbx4HluhiQD4cSOUsROxOic/71wvGRFFU89thhRewzo2/BU4v3y4jg4eu?=
 =?us-ascii?Q?jtZ7nUQFolk252Trvfl/+2eWNLKmEUvOzq9fb+iXXhSRor3uXLMpqJAGjbhp?=
 =?us-ascii?Q?fzhwEA0/2IHY4SpKJc0mC1UC3RhpIHTQixCGIPx/jkGlaMYgkbDLjJpxi3Cm?=
 =?us-ascii?Q?VLyfv68IbCckikt68dyE18FwySvHyO9ja0uBqV44Shvg/gQ7iS9us9aEoFvP?=
 =?us-ascii?Q?PNtIzFm16SOmioc5Qv8jWOAQ/yiYIezGaPo73owF2wr7FS9CAKs0O2MehogJ?=
 =?us-ascii?Q?Xdx2iok38N0mBjB7i+pcs4wfZ0AtcnxK01FHeACgxYw/G4JefR+y0YL5EK6E?=
 =?us-ascii?Q?JKRdFtgtjEtSG//hiFzhtj7u0YfBhZvETxenj7vJDee9mXycauv1SWtu486N?=
 =?us-ascii?Q?AD9NXsHVscMWy+M1y2pJO9fxxMShpGyltczePHGFpcjL98JuM/sTeMOUMV2d?=
 =?us-ascii?Q?5ulv/VF8pO1FYlgYfBweSZ3vZ5Jjb1UgWu2Aemxr2G4MoM9vlPFUw/MPxVmt?=
 =?us-ascii?Q?gip6nHrN8iQv2hrpxNkoCu026D1/YeyNspmEKoy/kFmzSG0+YThSFgwOuBS4?=
 =?us-ascii?Q?uqE35tF2I1m7y9C87JawpoQxssYPsyo62jpxVhvIvWgV9kqaGHEoj+E8y6vx?=
 =?us-ascii?Q?MG2PhAp1Xzmz6Vkjin1AgcWKmJyATM90ACoJLv2wFEaw8S3X8tjQc6AWkpHz?=
 =?us-ascii?Q?jhPJgm9NSL6wGQuTZa83OmXLEuTO28lNLqCdiZQJqFiV5NpnBQmD56IPps60?=
 =?us-ascii?Q?XOPtjbEmhCK9QK2FTUnssRz9Z2KrVaFAf5CG7HekxdjVLA+CO+pdsITWTO/M?=
 =?us-ascii?Q?dkL6xOMOZKg9IZ/qDIn6JBggkrxYuN4IMUcdV5z+Xy5nKo5byGx1jAjJGlFV?=
 =?us-ascii?Q?z2JYNendSj1/2GlzUJOfwxnUC5beO1IDLVe4Y6O/EPIPmVR6SFnqWA34R/g4?=
 =?us-ascii?Q?O3PjF/JHdNpApPukaP01dFIcZb5Vb68Fbk1I2EdaHUA4ZJ9N8niZMaQiN0OG?=
 =?us-ascii?Q?AvBHq+2x+7Jdsd8Mw8+CASQnUI2/s2wWB7uGqoQbJrczpBUHnF5qzO7zfkBi?=
 =?us-ascii?Q?DJ3S7SZKiS4icFHq0eirNwetmxVLHpTPvuaBqbdK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR18MB5314.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0495eb40-a67d-4db2-ba92-08dc83ac6b3e
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 09:06:13.6427
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PnXC5l6op3nG+RzX2Jim6c02jeAsKdImxk/CXXPoXpEqTyka3QOtkzI/n1y7TuaYMO128e5JuMuxLO4h0QeX1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB5859
X-Proofpoint-ORIG-GUID: uZYKiq0BANrirF2A9dCKnEoRnbabKiWD
X-Proofpoint-GUID: uZYKiq0BANrirF2A9dCKnEoRnbabKiWD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-06-03_05,2024-05-30_01,2024-05-17_01


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Saturday, June 1, 2024 3:50 PM
> To: Bharat Bhushan <bbhushan2@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
> Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Jerin Jacob
> <jerinj@marvell.com>; Linu Cherian <lcherian@marvell.com>;
> richardcochran@gmail.com
> Subject: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline ips=
ec
> transmit offload
>=20
>=20
> ----------------------------------------------------------------------
> On Tue, May 28, 2024 at 07:23:47PM +0530, Bharat Bhushan wrote:
> > Prepare and submit crypto hardware (CPT) instruction for outbound
> > inline ipsec crypto mode offload. The CPT instruction have
> > authentication offset, IV offset and encapsulation offset in input
> > packet. Also provide SA context pointer which have details about algo,
> > keys, salt etc. Crypto hardware encrypt, authenticate and provide the
> > ESP packet to networking hardware.
> >
> > Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
>=20
> Hi Bharat,
>=20
> A minor nit from my side as it looks like there will be a v4 anyway.
>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
>=20
> ...
>=20
> > +bool cn10k_ipsec_transmit(struct otx2_nic *pf, struct netdev_queue *tx=
q,
> > +			  struct otx2_snd_queue *sq, struct sk_buff *skb,
> > +			  int num_segs, int size)
> > +{
>=20
> ...
>=20
> > +	/* Check for valid SA context */
> > +	sa_info =3D (struct cpt_ctx_info_s *)x->xso.offload_handle;
> > +	if (!sa_info || !sa_info->sa_iova) {
> > +		netdev_err(pf->netdev, "Invalid SA conext\n");
>=20
> nit: context
>=20
>      checkpatch.pl --codespell is your friend.

Will fix here and run this on all patches.

Thanks
-Bharat

>=20
> > +		goto drop;
> > +	}
>=20
> ...