Received-SPF: pass (google.com: domain of linux-kernel+bounces-198856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Bharat Bhushan <bbhushan2@marvell.com>
To: Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Leon Romanovsky
	<leon@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Geethasowjanya
 Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Jerin Jacob <jerinj@marvell.com>, Linu Cherian <lcherian@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>
Subject: RE: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
 ipsec transmit offload
Thread-Topic: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
 ipsec transmit offload
Thread-Index: AQHasQaTfyi6mWkXDkOBPclCj0tdJLG0EIWAgAFrzACAAE9NkA==
Date: Mon, 3 Jun 2024 09:18:33 +0000
Message-ID: 
 <SN7PR18MB5314D17F56C125A6AB36AD88E3FF2@SN7PR18MB5314.namprd18.prod.outlook.com>
References: <20240528135349.932669-1-bbhushan2@marvell.com>
 <20240528135349.932669-7-bbhushan2@marvell.com>
 <20240602065125.GH3884@unreal>
 <BY3PR18MB4737F1C148F2C230A4ABC49CC6FF2@BY3PR18MB4737.namprd18.prod.outlook.com>
In-Reply-To: 
 <BY3PR18MB4737F1C148F2C230A4ABC49CC6FF2@BY3PR18MB4737.namprd18.prod.outlook.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?E+9/1waeyODTJ96j70yiSHqwwyV7hwFoEQ2N+dQhmv63y+wU4joxcvaP0M8k?=
 =?us-ascii?Q?q6RrtnHR+XQsAYDfp4nPqDj86kzqdix9W9MIx9kajuSgeDg9L1WWbRTxaIKj?=
 =?us-ascii?Q?+/uKTvn/61lQ7pC6hkn+ZCD/hW+q8+3qC5O+NfNuhV/66CaqJI0CsnxAabeJ?=
 =?us-ascii?Q?ULfoNaKVDNik+JGhNNjxPC8rhKPVgieieBImipWMqsEFWfkNe4N6H5FY2Ayq?=
 =?us-ascii?Q?K+MilXMEgx394mNQ3I42O7jfXRk9nowplgzZIdXvsG0SuEOuFu0ZvAwrQhhw?=
 =?us-ascii?Q?pn4Aspneza430sPEvO31at6vcfKT6YDAX8lDEix4I8fUFf9qux2/K79caNC4?=
 =?us-ascii?Q?yKFXXXfJ8lTrGLM9N7COMeiqePZsMBwRJkD1abMeGjiAdcPWKx+6FmtOb2WD?=
 =?us-ascii?Q?XSMNb0AeV+6PT2nJrt0s5ms6bViFw6sx6VbAL1Slwx9sTtRFhMSJyLLoWCp2?=
 =?us-ascii?Q?y1nu4ZltCqmQzm3dWYGxoizGgFrzpN2ig0rcbz94lfF9LAeQvVE7oCX4srDt?=
 =?us-ascii?Q?jZhVwKm8vmcNy2p2xKHBqQhCt8gBaEgHCnzH0ROp2dhA2glPE2rI6rO+5KxI?=
 =?us-ascii?Q?VbP5R5xkjZy7mLODmA+yH0/A33WCcpckj1jBRtmNQrr90jMgABPwV5Ws+ZjH?=
 =?us-ascii?Q?XZs6QzD4HeqXdY3x4U/zbDA4gExt2QMe35sxP84Pym5C9AVYcB6g7a0OdiPC?=
 =?us-ascii?Q?Xe6FgRmCHu/3NnsBmHfmo7agJTtWHoEFAHlLqPArSOTLKz+rW9klaGFR5Vd8?=
 =?us-ascii?Q?7hA0O9vD72sKIUs4GE0l1kBtqw9Y2+JaZyiZJnJqLQ08r9MeENmi1wH8OgqH?=
 =?us-ascii?Q?GZRlAh/rJBXRMQxXBuz9T+w1ruf3S/TyUDG2YLcDBJGc0Qc6EysulkPpa6ng?=
 =?us-ascii?Q?/wLMCl2gjey2PmboNOg0nek2qJZglgHZ1aTybFsXbU4MqZfb2WSm7bZV3xxP?=
 =?us-ascii?Q?BVJc3Sed0pKjCw9lu8mfgiJtsDhKqeQC7nKqzMBK5WoUofqrFXF/BXf17NGH?=
 =?us-ascii?Q?et5wOz4D9vPKMI0iLJJWDgzY8+BP4PjILTvox+PuA/5V2axn9F6LjVvdyco3?=
 =?us-ascii?Q?3bIKlyHE7XWMy0Zse97jorl8H6Fsmy9/+H5qWsE2hprCx0WL9armZDOaGFmh?=
 =?us-ascii?Q?zbSrhMV0zmaE+yCb8ia5q0opWFIJhajTlxi6DAB0MNnHitBy0esfPZA6gnSx?=
 =?us-ascii?Q?7kUEAQUeowT7hMpAjY1lX1o0+6xLco1GMZArO2uiHUizteIoJikBFqcoMWP0?=
 =?us-ascii?Q?jI3nYFv6puIVG2cPJZ+ewuqYx/O8RthFfinZUtTEbZKVpd8LQfJsGam1avUU?=
 =?us-ascii?Q?YamAnXL7uLUqnFBJNel14OeX2+KopUoQf4lUMq3iadQdnXdYPd+ikddmXbSH?=
 =?us-ascii?Q?NDHEUzg3QCV8Ggitnx/8xvOsy9ecmjzKH+d+8c7HNAp3dEYXESFP2ZB84+Li?=
 =?us-ascii?Q?iKCWbOlvv81UVR1SLGPr7SRZNfBlh6WyYOMkt28hOulmOUzosqsUmIvYAuoZ?=
 =?us-ascii?Q?ckgxAntJ5bD/3WxSKymrwaMsCG1LGjIC5VlK2b0fjCgTcWIZZYxRo/q271Sg?=
 =?us-ascii?Q?j2z21EBJtaN39Si7mOsC+ya2j0x6hALuNquMMQkE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR18MB5314.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06c24045-bd7d-4ff6-2a99-08dc83ae2424
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 09:18:33.3090
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nWK0hWq02prW8eYguU8LCoszLp0UrcK5AN/s5WsVjO9j3NOTc/48BMra3smGpsByXLaWgZN8MrTykI13f6rBqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS1PR18MB6135
X-Proofpoint-GUID: WjCdkk2mpP-Sc4NK8upQsHdQT29zHC-j
X-Proofpoint-ORIG-GUID: WjCdkk2mpP-Sc4NK8upQsHdQT29zHC-j
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-06-03_05,2024-05-30_01,2024-05-17_01


> -----Original Message-----
> From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Sent: Monday, June 3, 2024 10:04 AM
> To: Leon Romanovsky <leon@kernel.org>; Bharat Bhushan
> <bbhushan2@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Geethasowjanya
> Akula <gakula@marvell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; Jerin Jacob <jerinj@marvell.com>; Linu Cherian
> <lcherian@marvell.com>; richardcochran@gmail.com
> Subject: RE: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
> ipsec transmit offload
>=20
>=20
>=20
> >-----Original Message-----
> >From: Leon Romanovsky <leon@kernel.org>
> >Sent: Sunday, June 2, 2024 12:21 PM
> >To: Bharat Bhushan <bbhushan2@marvell.com>
> >Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> >Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> ><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
> >Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
> >edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Jerin Jacob
> ><jerinj@marvell.com>; Linu Cherian <lcherian@marvell.com>;
> >richardcochran@gmail.com
> >Subject: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
> >ipsec transmit offload
> >
> >
> >----------------------------------------------------------------------
> >On Tue, May 28, 2024 at 07:23:47PM +0530, Bharat Bhushan wrote:
> >> Prepare and submit crypto hardware (CPT) instruction for outbound
> >> inline ipsec crypto mode offload. The CPT instruction have
> >> authentication offset, IV offset and encapsulation offset in input
> >> packet. Also provide SA context pointer which have details about
> >> algo, keys, salt etc. Crypto hardware encrypt, authenticate and
> >> provide the ESP packet to networking hardware.
> >>
> >> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
> >> ---
> >>  .../marvell/octeontx2/nic/cn10k_ipsec.c       | 224 +++++++++++++++++=
+
> >>  .../marvell/octeontx2/nic/cn10k_ipsec.h       |  40 ++++
> >>  .../marvell/octeontx2/nic/otx2_common.c       |  23 ++
> >>  .../marvell/octeontx2/nic/otx2_common.h       |   3 +
> >>  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |   2 +
> >>  .../marvell/octeontx2/nic/otx2_txrx.c         |  33 ++-
> >>  .../marvell/octeontx2/nic/otx2_txrx.h         |   3 +
> >>  7 files changed, 325 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> >> b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> >> index 136aebe2a007..1974fda2e0d3 100644
> >> --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> >> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
> >> @@ -7,8 +7,11 @@
> >>  #include <net/xfrm.h>
> >>  #include <linux/netdevice.h>
> >>  #include <linux/bitfield.h>
> >> +#include <crypto/aead.h>
> >> +#include <crypto/gcm.h>
> >>
> >>  #include "otx2_common.h"
> >> +#include "otx2_struct.h"
> >>  #include "cn10k_ipsec.h"
> >>
> >>  static bool is_dev_support_inline_ipsec(struct pci_dev *pdev) @@
> >> -843,3 +846,224 @@ void cn10k_ipsec_clean(struct otx2_nic *pf)
> >>  	cn10k_outb_cpt_clean(pf);
> >>  }
> >>  EXPORT_SYMBOL(cn10k_ipsec_clean);
> >
> ><...>
> >
> >> +bool cn10k_ipsec_transmit(struct otx2_nic *pf, struct netdev_queue *t=
xq,
> >> +			  struct otx2_snd_queue *sq, struct sk_buff *skb,
> >> +			  int num_segs, int size)
> >> +{
> >> +	struct cpt_ctx_info_s *sa_info;
> >> +	struct cpt_inst_s inst;
> >> +	struct cpt_res_s *res;
> >> +	struct xfrm_state *x;
> >> +	dma_addr_t dptr_iova;
> >> +	struct sec_path *sp;
> >> +	u8 encap_offset;
> >> +	u8 auth_offset;
> >> +	u8 gthr_size;
> >> +	u8 iv_offset;
> >> +	u16 dlen;
> >> +
> >> +	/* Check for Inline IPSEC enabled */
> >> +	if (!(pf->flags & OTX2_FLAG_INLINE_IPSEC_ENABLED)) {
> >> +		netdev_err(pf->netdev, "Ipsec not enabled, drop packet\n");
> >
> ><...>
> >
> >> +		netdev_err(pf->netdev, "%s: no xfrm state len =3D %d\n",
> >> +			   __func__, sp->len);
> >
> ><...>
> >
> >> +		netdev_err(pf->netdev, "no xfrm_input_state()\n");
> >
> ><...>
> >
> >> +		netdev_err(pf->netdev, "un supported offload mode %d\n",
> >> +			   x->props.mode);
> >
> ><...>
> >
> >> +		netdev_err(pf->netdev, "Invalid IP header, ip-length zero\n");
> >
> ><...>
> >
> >> +		netdev_err(pf->netdev, "Invalid SA conext\n");
> >
> >All these prints are in datapath and can be triggered by network
> >packets. These and RX prints need to be deleted.
> >
>=20
> Yes, all these error messages in datapath should be under netif_msg_tx_er=
r().

Will delete a few of these prints and rest will be moved under netif_msg_tx=
_err().

Thanks
-Bharat

>=20
> Thanks,
> Sunil.