Received-SPF: pass (google.com: domain of linux-kernel+bounces-198902-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 3 Jun 2024 09:31:13 +0000
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Ben Walsh <ben@jubnut.com>
Cc: Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>,
	"Dustin L. Howett" <dustin@howett.net>,
	Kieran Levin <ktl@frame.work>,
	Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>,
	Mario Limonciello <mario.limonciello@amd.com>,
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] platform/chrome: cros_ec_lpc: Add a new quirk for
 AML mutex
Message-ID: <Zl2NYTIWtt604WXm@google.com>
References: <20240603063834.5580-1-ben@jubnut.com>
 <20240603063834.5580-5-ben@jubnut.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240603063834.5580-5-ben@jubnut.com>

On Mon, Jun 03, 2024 at 07:38:33AM +0100, Ben Walsh wrote:
> @@ -484,6 +492,18 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>  			}
>  			ACPI_COMPANION_SET(dev, adev);
>  		}
> +
> +		if (quirks & CROS_EC_LPC_QUIRK_AML_MUTEX) {
> +			const char *name
> +				= driver_data->quirk_aml_mutex_name;
> +			ret = cros_ec_lpc_mec_acpi_mutex(adev, name);

* Assuming the `adev = ACPI_COMPANION(dev);` didn't move in previous patch,
  `adev` here could be uninitialized.

* Also, it shouldn't rely on CROS_EC_LPC_QUIRK_ACPI_ID to set the `adev`.

To keep it simple, I would suggest to use ACPI_COMPANION() instead.