Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp850064lqj; Mon, 3 Jun 2024 02:44:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUpntH6IO9IHmeova+FlV9zlfUYeXPCCjKlhG+rflHTjKgWv6JyrdXwPevDSjkFS2sXAcsh6JNDYCTVywtF1hi65+lDEoSpzIU66eZlvw== X-Google-Smtp-Source: AGHT+IGySBgZGMNDt8ocVC7qSSjylQyC7OEecT2gl5L7n6cx8RXk5+07wzgMdYTJnX6Uw6wEDcOd X-Received: by 2002:a50:d718:0:b0:570:5e7f:62cb with SMTP id 4fb4d7f45d1cf-57a36543a5amr5402374a12.29.1717407890751; Mon, 03 Jun 2024 02:44:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717407890; cv=pass; d=google.com; s=arc-20160816; b=v/BJskWGY2g5QGX6ISlkYNhRI8gB5UJW7WO03I3iTAwDeqI6axhKeKIG+ElE6fQfpT i/R8zz2qU0ojbSLugE2fkwc2EqZ6PN6sfpWcG1rgQxk1oUvSo4grf9Vh43YwO+Iw7cJt MRLYIlRMik1Zuzoyu71ksP4tqn9q9ybp87ZMmk1M9vYff8YOo1YZlHtBkd0XY27gRgQ5 74yp2m7sCMfuUib42UE65+l2tZr7s5Xg4TOUEzF2JfS0tWUCYT8M8fokle9x/MntEkKN rJaMnl2U/hPuShBrf5yIgX+t52vcsXTepFYzAP0SOJFqrJYtCHM0p95b0oWQIqnKPHyk Occw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=U7Ho4zKhkkiYFTzTY91pGPL2i6KvNE8h4Vbogb5wZs0=; fh=GlppEOaPWPJngaaiMlf02dOpKbvM42LBGh/MgRkBbps=; b=UG3NTQBTNLDUXasz3BpVLItH2uQbHhQiNuap5cuswDzFzmozC7/R8bmYpSUkUvGFIP Emm4Qg+Fo4cHzKOFmjjdyAI4rHjpXx/OWz9eAmb7lwxBBmWYVHCVzd9F5cWIWiXltEYr DdEZ3BSNnBSyM8Ccwg+6G707i1FKr2j6EDYspcEblZ5GVJM+ZNJOp2dUYUuz1oH/wopQ MlnpjmBr3ANHnnwOpK4aWyshodUzczg2k+ylH1y2/STfARBk/Zxoa3mfHhW0Xbb2FSsp w2RUpq3s96zN9kVQJnCZ/QqDmZabKn+lMCoac8HXxvmKjxKLcaIVneiQgwg2J3XAZlPs +CFA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=ByhlWGRI; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-198920-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198920-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a31ca4e40si3749590a12.503.2024.06.03.02.44.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 02:44:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-198920-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=ByhlWGRI; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-198920-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198920-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CC9E51F24465 for ; Mon, 3 Jun 2024 09:43:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33763126F11; Mon, 3 Jun 2024 09:38:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ByhlWGRI" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7948B667; Mon, 3 Jun 2024 09:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717407503; cv=none; b=W2xabk+ESShePnQVum+2UtgtYXabC6N6Bmx8ZJbIZ43HTHaETcmJZRZYpuelHJwicWyiqkHiEquvePZ9ri2a97yXuSuBlnZ+17r2koCA4UL0wA3cZC0LCnC+1VaG7SJSWXPBArksloSeOMkHSKGObJzJSF6iXHnSS6M5ZxOAR6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717407503; c=relaxed/simple; bh=nsLDjTZTaB6IlVf1YN+Z1Ok82/GbhJFUrL0xBcqN0mA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uADUAhITw3PJJP0CnxXmboeRGAEvdXfEHlBxjMB8M3qNC0+HqQRU8DwgpD3SNoZ/hUY+jk4p87RvowI8WfZVPMACJ01yluB85kPLWllAXktURPUihBCLM4oVYmMMQt1A4rDQ968cw+cgKLQuSxueVIDuk7AzoUSs6Q69UqUzDRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=ByhlWGRI; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=U7Ho4zKhkkiYFTzTY91pGPL2i6KvNE8h4Vbogb5wZs0=; b=ByhlWGRI2Ktx47DAPDLPq8dnm1 B+CX9jUK47LjL+lCl8e6Mu8Syjci2Ufq1RkI4Z127sWqr85wz6jhqmCKiL0uopS32LmM8l6iaRhUp 2x5rRl0dhueE2SS1UwhflKFjjY+lm5ObcN3H1OykMtzbKp/UFET4iJldTTwxKTymYbOYYQcQCIMMV YCknfBryxH45AJqMzIsExz4ZGIES33S6GCQlD/WLTB6ljQw1Lk20MBTSqmdIws+jFyOsKe98OaqXb xpLDDT54wpVXB5pdsJGyFsl9lmfw0cdeQGASvSQKYp/Zu6qb9+tqTavOkS7Dz1Drpgtqh0aeQUX7o pdWUlSew==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44764) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sE48g-0002Xl-1z; Mon, 03 Jun 2024 10:38:02 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sE48g-0000Jm-09; Mon, 03 Jun 2024 10:38:02 +0100 Date: Mon, 3 Jun 2024 10:38:01 +0100 From: "Russell King (Oracle)" To: Christophe Roullier Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , Marek Vasut , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/11] net: stmmac: dwmac-stm32: Separate out external clock rate validation Message-ID: References: <20240603092757.71902-1-christophe.roullier@foss.st.com> <20240603092757.71902-3-christophe.roullier@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603092757.71902-3-christophe.roullier@foss.st.com> Sender: Russell King (Oracle) On Mon, Jun 03, 2024 at 11:27:48AM +0200, Christophe Roullier wrote: > +static int stm32mp1_validate_ethck_rate(struct plat_stmmacenet_data *plat_dat) > +{ > + struct stm32_dwmac *dwmac = plat_dat->bsp_priv; > + const u32 clk_rate = clk_get_rate(dwmac->clk_eth_ck); > + > + switch (plat_dat->mac_interface) { Should these be phy_interface? Does this clock depend on the interface mode used with the PHY? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!