Received-SPF: pass (google.com: domain of linux-kernel+bounces-198928-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <577cc35e-00c6-4893-b917-d3f44bf19191@redhat.com>
Date: Mon, 3 Jun 2024 11:44:01 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: yt2-1380: add CONFIG_EXTCON dependency
To: Arnd Bergmann <arnd@kernel.org>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Armin Wolf <W_Armin@gmx.de>,
 SungHwan Jung <onenowy@gmail.com>,
 Henning Schild <henning.schild@siemens.com>, Ai Chao <aichao@kylinos.cn>,
 Robert Joslyn <robert.joslyn@redrectangle.org>,
 Heiner Kallweit <hkallweit1@gmail.com>, platform-driver-x86@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240528115940.3169455-1-arnd@kernel.org>
Content-Language: en-US
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20240528115940.3169455-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 5/28/24 1:59 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver uses the extcon subsystem and fails to build
> when it cannot call into that subsystem:
> 
> x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_worker':
> lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d819): undefined reference to `extcon_get_state'
> x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9d853): undefined reference to `extcon_get_state'
> x86_64-linux-ld: vmlinux.o: in function `yt2_1380_fc_serdev_probe':
> lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9da22): undefined reference to `extcon_get_extcon_dev'
> x86_64-linux-ld: lenovo-yoga-tab2-pro-1380-fastcharger.c:(.text+0xa9dc0c): undefined reference to `devm_extcon_register_notifier_all'
> 
> Add a Kconfig dependency to make it it always builds correctly.
> 
> Fixes: b2ed33e8d486 ("platform/x86: Add lenovo-yoga-tab2-pro-1380-fastcharger driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans


> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 809888e4c1e7..9f850e4617bf 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -136,6 +136,7 @@ config YOGABOOK
>  config YT2_1380
>  	tristate "Lenovo Yoga Tablet 2 1380 fast charge driver"
>  	depends on SERIAL_DEV_BUS
> +	depends on EXTCON
>  	depends on ACPI
>  	help
>  	  Say Y here to enable support for the custom fast charging protocol