Received-SPF: pass (google.com: domain of linux-kernel+bounces-198941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b154663e-db1b-4f9b-8f8e-8da832b0edfd@siemens.com>
Date: Mon, 3 Jun 2024 10:55:19 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping
 support for SR1.0 devices
To: Jacob Keller <jacob.e.keller@intel.com>,
 MD Danish Anwar <danishanwar@ti.com>, Roger Quadros <rogerq@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Richard Cochran <richardcochran@gmail.com>, Nishanth Menon <nm@ti.com>,
 Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
 diogo.ivo@siemens.com
References: <20240529-iep-v1-0-7273c07592d3@siemens.com>
 <20240529-iep-v1-1-7273c07592d3@siemens.com>
 <46b4e8f4-e86a-4755-8e82-a3975973c43e@intel.com>
Content-Language: en-US
From: Diogo Ivo <diogo.ivo@siemens.com>
In-Reply-To: <46b4e8f4-e86a-4755-8e82-a3975973c43e@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Feedback-ID: 519:519-1320519:519-21489:flowmailer

Hi Jacob,

On 5/30/24 7:43 PM, Jacob Keller wrote:
> 
> 
> On 5/29/2024 9:05 AM, Diogo Ivo wrote:
>> +	ret = icss_iep_init(prueth->iep0, NULL, NULL, 0);
>> +	if (ret) {
>> +		dev_err_probe(dev, ret, "failed to init iep0\n");
>> +		goto put_iep;
>> +	}
>> +
>> +	ret = icss_iep_init(prueth->iep1, NULL, NULL, 0);
>> +	if (ret) {
>> +		dev_err_probe(dev, ret, "failed to init iep1\n");
>> +		goto exit_iep0;
>> +	}
>> +
> 
> Once initialized, the icss_iep driver logic must implement the actual
> PTP clock interfaces?

Yes exactly, the IEP driver then implements the PHC operations.

> Neat.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thank you for the review!

Best regards,
Diogo