Received-SPF: pass (google.com: domain of linux-kernel+bounces-198973-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <11841924e4e1db49001a2fe52f5985f3c044c184.camel@gmail.com>
Subject: Re: [PATCH v3 0/5] iio: add support for multiple scan types
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, David Lechner
 <dlechner@baylibre.com>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>, Nuno
 =?ISO-8859-1?Q?S=E1?= <nuno.sa@analog.com>, Julien Stephan
 <jstephan@baylibre.com>, Esteban Blanc <eblanc@baylibre.com>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 03 Jun 2024 12:25:55 +0200
In-Reply-To: <20240602102517.438b51b8@jic23-huawei>
References: 
	<20240530-iio-add-support-for-multiple-scan-types-v3-0-cbc4acea2cfa@baylibre.com>
	 <20240602102517.438b51b8@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Sun, 2024-06-02 at 10:25 +0100, Jonathan Cameron wrote:
> On Thu, 30 May 2024 10:14:07 -0500
> David Lechner <dlechner@baylibre.com> wrote:
>=20
> > Up to now, the IIO subsystem has only supported a single scan type per
> > channel. This scan type determines the binary format of the data in the
> > buffer when doing buffered reads.
> >=20
> > For simple devices, there is only one scan type and all is well. But
> > for more complex devices, there may be multiple scan types. For example=
,
> > ADCs with a resolution boost feature that adds more bits to the raw
> > sample data. Traditionally, for slow devices, we've just always used th=
e
> > highest resolution mode, but for high performance ADCs, this may not be
> > always practical. Manipulating data after every read can hurt performan=
ce
> > and in the case of hardware buffers, it may not be possible to change t=
he
> > format of the data in the buffer at all. There are also ADCs where
> > enabling the higher resolution can only be done if oversampling is also
> > enabled which may not be desireable.
> >=20
> > To allow for more flexibility, we would like to add support for multipl=
e
> > scan types per channel.
> >=20
> > To avoid having to touch every driver, we implemented this in a way tha=
t
> > preserves the existing scan_type field. See the "iio: add support for
> > multiple scan types per channel" the details. The first couple of patch=
es
> > are just preparation for this.
> >=20
> > [1]:
> > https://lore.kernel.org/linux-iio/CAMknhBHOXaff__QyU-wFSNNENvs23vDX5n_d=
dH-Dw3s6-sQ9sg@mail.gmail.com/
>=20
> Nice series. Applied to the togreg branch of iio.git and pushed out as
> testing for 0-day to poke at it.
>=20
> Obviously this v3 hasn't been on list that long, but there is still time
> as I doubt I'll push out a non rebasing tree for a week or so.
> This week is looking too busy!

If there's still time, feel free to add my tag:

Reviewed-by: Nuno Sa <nuno.sa@analog.com>