Received-SPF: pass (google.com: domain of linux-kernel+bounces-199011-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 3 Jun 2024 13:03:44 +0200
From: Jan Kara <jack@suse.cz>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] readdir: Add missing quote in macro comment
Message-ID: <20240603110344.weobnu6augggrbdw@quack3>
References: <20240602004729.229634-2-thorsten.blum@toblux.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240602004729.229634-2-thorsten.blum@toblux.com>

On Sun 02-06-24 02:47:30, Thorsten Blum wrote:
> Add a missing double quote in the unsafe_copy_dirent_name() macro
> comment.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/readdir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/readdir.c b/fs/readdir.c
> index 278bc0254732..5045e32f1cb6 100644
> --- a/fs/readdir.c
> +++ b/fs/readdir.c
> @@ -72,7 +72,7 @@ int wrap_directory_iterator(struct file *file,
>  EXPORT_SYMBOL(wrap_directory_iterator);
>  
>  /*
> - * Note the "unsafe_put_user() semantics: we goto a
> + * Note the "unsafe_put_user()" semantics: we goto a
>   * label for errors.
>   */
>  #define unsafe_copy_dirent_name(_dst, _src, _len, label) do {	\
> -- 
> 2.45.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR