Received-SPF: pass (google.com: domain of linux-kernel+bounces-199015-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 3 Jun 2024 13:06:52 +0200
From: Jan Kara <jack@suse.cz>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] readdir: Remove unused header include
Message-ID: <20240603110652.5hjcsajjjmefv63i@quack3>
References: <20240602101534.348159-2-thorsten.blum@toblux.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240602101534.348159-2-thorsten.blum@toblux.com>

On Sun 02-06-24 12:15:35, Thorsten Blum wrote:
> Since commit c512c6918719 ("uaccess: implement a proper
> unsafe_copy_to_user() and switch filldir over to it") the header file is
> no longer needed.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/readdir.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/readdir.c b/fs/readdir.c
> index 5045e32f1cb6..d6c82421902a 100644
> --- a/fs/readdir.c
> +++ b/fs/readdir.c
> @@ -22,8 +22,6 @@
>  #include <linux/compat.h>
>  #include <linux/uaccess.h>
>  
> -#include <asm/unaligned.h>
> -
>  /*
>   * Some filesystems were never converted to '->iterate_shared()'
>   * and their directory iterators want the inode lock held for
> -- 
> 2.45.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR