Received-SPF: pass (google.com: domain of linux-kernel+bounces-199014-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5a7d3d78-f152-466f-90de-e4a781577bb1@amd.com>
Date: Mon, 3 Jun 2024 13:04:36 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] firmware: xilinx: Move FIRMWARE_VERSION_MASK to
 xlnx-zynqmp.h
To: Ronak Jain <ronak.jain@amd.com>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240425095913.919390-1-ronak.jain@amd.com>
Content-Language: en-US
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <20240425095913.919390-1-ronak.jain@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZlNUdGJCVUlWTXZjdDBXaHBjVnk2cTVqMkhSWk1wbms2QWN5Yk9SRXhBc3pD?=
 =?utf-8?B?R3Y0bFNjanlLWUdWU3o5eDdYR0lITTNjTDRRSDF0eTRSaE1TS3dSZDBza0tC?=
 =?utf-8?B?bGdTYUxzSTNnRjNGVlR5R3VwdjIzY2lQeEhkUSt6M1JWM3JZclhKT1U0OWsv?=
 =?utf-8?B?Y2dLMXdDbHEvSXZ5QlRRWHNOQUNBcC95VXlySlRLZFhVZXhGQ1B5K3laTEJJ?=
 =?utf-8?B?TkhEdE9rQzNwMFRMdmtRb1ZaazRTNEU3ckVWNnBpaVZrQ212c3FyM1JhdlV2?=
 =?utf-8?B?MExnWWRlN08rZUpVU2Rmak50ajhGeFQ1YlA1RXg2eEx2YW4zeUV5a0VnakJK?=
 =?utf-8?B?NlFqeU5xMmxjTEI5dnE3NFYwYUtrdXJBWktaNXYvcEFnaWswczNYNXdPZWt6?=
 =?utf-8?B?VmUzWGhWWExkYyszcVJ6MmJKTFlYOHFYREpkU2Y5NWIzRW84OXRqNFA1QmpN?=
 =?utf-8?B?bkFJODRQRHJJQUtKbzdGMGdGdUdUNG1TVXg0Z0ZKTFplWFMyaktFYnROajkw?=
 =?utf-8?B?TFhmai8ybjZ1YXhEUnI1RlNkK3BOSFZDQzlwU0dpSFFJVHlsYzVWM2dwZmtt?=
 =?utf-8?B?aGpVdFBxVUI2WnVwK2pvNmZiYUR6cjVFVUdCRkRuSEtka1F0em8zRjU4M29y?=
 =?utf-8?B?NThXSjNXenVnRTQvRTVjVmRvdTVBdFNLSVR5aXQwN2JCaDJ1T2prRzZoRGIv?=
 =?utf-8?B?VmlsU21TaWFwSVRFRktZOWpMeUtuaS83cnVaaThpTEdCTU81RDc3OHBPM1M5?=
 =?utf-8?B?aVV5aUw1WWtVRGVHTUp0WWlPb0Q5QlVHbFc5THF5b2VJQjkwL3RqQ05ZQ0g4?=
 =?utf-8?B?d1ZpYWMzSVZzU3JYeWxMdERqODhEankwM1dybXFjM3gzR1VXNHgwNFA3Z3dr?=
 =?utf-8?B?WkRqOTZSazBSajRORG5lM0U5VWpsY3dRdndJSjFucExaTGw3WFFvMldDQmE1?=
 =?utf-8?B?RllZQWxGdW5xbm55dW56UVZDMjhMZW9oaS9xeTBNbDFZSU5ndGJOamxUN2Jo?=
 =?utf-8?B?bVBTd1A5bUtVQUVadm1CTFdwRlpHczJwSjlBcFI3TlMySWlOajJlZFJ0V1Rn?=
 =?utf-8?B?V0dEaGNMSGVTNmlScU0zcWFBSmh5RXlLRDd5aFJWMHRLekY3VnFMR1NYOThP?=
 =?utf-8?B?R2VLWnIwUHB4TC96ekVtOXZ4ck1CMk4xSXNYZ1UxNGF6REE2a0RQWkhXNUQ5?=
 =?utf-8?B?SXdDcVVUTDBTakJjMllkMlMxRFo2L0N0T1l1OWF3V0g4T2h2VG9CNkFLUkJR?=
 =?utf-8?B?eTlMbVpOUVVENCswSCt4ZXR6R0NoelFPZ1Jtc0tDcGhrNXh0YjRaT1lmRmJy?=
 =?utf-8?B?Y3llVXFEVGtkRlA5Wi9lbmJaaDNsTkRTMlg5dmlyNzQweUhTUFY2aXY4Ukwz?=
 =?utf-8?B?NUxHTkV3YmYyUVF1MUh2SlQxNWtOcElsNUpxY1lmSjJmMEZvU2RGZklXMTFr?=
 =?utf-8?B?QmdDNUN3ZitSRTVCWTVkK010OEc0VUtDYnNnUmtocGZVWTBKZFRjWXVBZEJX?=
 =?utf-8?B?c1U1YVFxWVhTdUt0SlZzSEV5MmZTODM4elNVb3ZuUnZaU21adVlBMlA0MmhQ?=
 =?utf-8?B?ckhBWGQrWlRPcHVjVzh5aTk5Wm1JcnRUSnlTSXJCUWZ1TDl4QzhmdmRpZlIv?=
 =?utf-8?B?R2VxYk9tL1dXTFdIdG1waW85cDNGWW96N2s0WmUxa1RUV0FHTGhEcnpSOTBo?=
 =?utf-8?B?U0xnU2kwSmNINU5ZcDNQMVQzdEpEOWlTbjFvbVRET2pKZEgwK2xxU0NZc2x0?=
 =?utf-8?B?RVpQNUNLV1BweHo2NDFqdDZxYWJMNzh1QVFjZnkzVDBXR1RhbVdGalRtUkVR?=
 =?utf-8?B?Z2JQMUljTVcwZDlqcFRnT2s4ZDA1dWlmTHFPUGs1VjBOSndqME14WmdvcFBL?=
 =?utf-8?B?U2ppdzdMbzZZWWhWT1p3RGQrVWdqQkJiMVFMQnFnUkRpUUs2c3UreW54bGZJ?=
 =?utf-8?B?d3diczk4OVJLZHJOQTB3TjgxaWRPc1U1c1ZQL25vdjRpTjNpOXY2YjQ3QkN5?=
 =?utf-8?B?VElFVFNVa1ZiQVdNcGZlQlBvdHBmQ05wTEJ1ZGR6djd4V2NBczg0Tmcyd091?=
 =?utf-8?B?RTJqd012cnRGWElFVTI4bmpxU3hMR09qdDE0ekZTalVkMERlWWlkRkljM0s3?=
 =?utf-8?Q?usfiQwPrzMMdZI9rx/tZtHSSN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c019b4c5-5059-4d61-d5a8-08dc83bcfb09
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 11:04:47.1079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Rrz9cYuT3VU4pn3ZW8BqLK0O7Mai6RP/bEsEZvxPKGkA2Yd29BgNvs/8k9pNx9S
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8231


On 4/25/24 11:59, Ronak Jain wrote:
> Move FIRMWARE_VERSION_MASK macro to xlnx-zynqmp.h so that other
> drivers can use it for verifying the supported firmware version.
> 
> Signed-off-by: Ronak Jain <ronak.jain@amd.com>
> Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@amd.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
>   drivers/firmware/xilinx/zynqmp.c        | 3 ---
>   drivers/soc/xilinx/xlnx_event_manager.c | 1 -
>   include/linux/firmware/xlnx-zynqmp.h    | 3 +++
>   3 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 9bc45357e1a8..add8acf66a9c 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -41,9 +41,6 @@
>   /* IOCTL/QUERY feature payload size */
>   #define FEATURE_PAYLOAD_SIZE		2
>   
> -/* Firmware feature check version mask */
> -#define FIRMWARE_VERSION_MASK		GENMASK(15, 0)
> -
>   static bool feature_check_enabled;
>   static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>   static u32 ioctl_features[FEATURE_PAYLOAD_SIZE];
> diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c
> index 253299e4214d..9d89b5a40f97 100644
> --- a/drivers/soc/xilinx/xlnx_event_manager.c
> +++ b/drivers/soc/xilinx/xlnx_event_manager.c
> @@ -35,7 +35,6 @@ static int event_manager_availability = -EACCES;
>   
>   #define MAX_BITS	(32U) /* Number of bits available for error mask */
>   
> -#define FIRMWARE_VERSION_MASK			(0xFFFFU)
>   #define REGISTER_NOTIFIER_FIRMWARE_VERSION	(2U)
>   
>   static DEFINE_HASHTABLE(reg_driver_map, REGISTERED_DRIVER_MAX_ORDER);
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index 1a069a56c961..d7d07afc0532 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -52,6 +52,9 @@
>   #define API_ID_MASK		GENMASK(7, 0)
>   #define MODULE_ID_MASK		GENMASK(11, 8)
>   
> +/* Firmware feature check version mask */
> +#define FIRMWARE_VERSION_MASK		0xFFFFU
> +
>   /* ATF only commands */
>   #define TF_A_PM_REGISTER_SGI		0xa04
>   #define PM_GET_TRUSTZONE_VERSION	0xa03

Applied.
M