Received-SPF: pass (google.com: domain of linux-kernel+bounces-199033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5dfdfa17-d3b3-408e-a8a6-b8dc0756eac3@gmail.com>
Date: Mon, 3 Jun 2024 13:17:58 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests: filesystems: fix warn_unused_result build
 warnings
From: Amer Al Shanawany <amer.shanawany@gmail.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Shuah Khan <shuah@kernel.org>, Christian Brauner <brauner@kernel.org>,
 Miklos Szeredi <mszeredi@redhat.com>, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Javier Carrasco <javier.carrasco.cruz@gmail.com>
References: <20240417184913.74734-1-amer.shanawany@gmail.com>
 <58e0539d-423e-42e0-9ee4-8fc8e1eed94f@collabora.com>
 <0910d537-c2e8-4932-8b0e-b5ce381e1ee1@gmail.com>
Content-Language: en-US
In-Reply-To: <0910d537-c2e8-4932-8b0e-b5ce381e1ee1@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 5/4/24 19:17, Amer Al Shanawany wrote:
> On 4/19/24 18:41, Muhammad Usama Anjum wrote:
>> On 4/17/24 11:49 PM, Amer Al Shanawany wrote:
>>> Fix the following warnings by adding return check and error messages.
>>>
>>> statmount_test.c: In function ‘cleanup_namespace’:
>>> statmount_test.c:128:9: warning: ignoring return value of ‘fchdir’
>>> declared with attribute ‘warn_unused_result’ [-Wunused-result]
>>>   128 |         fchdir(orig_root);
>>>       |         ^~~~~~~~~~~~~~~~~
>>> statmount_test.c:129:9: warning: ignoring return value of ‘chroot’
>>> declared with attribute ‘warn_unused_result’ [-Wunused-result]
>>>   129 |         chroot(".");
>>>       |         ^~~~~~~~~~~
>>>
>>> Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com>
>> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>
>>> ---
>>>  .../selftests/filesystems/statmount/statmount_test.c | 12 ++++++++++--
>>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/filesystems/statmount/statmount_test.c b/tools/testing/selftests/filesystems/statmount/statmount_test.c
>>> index e6d7c4f1c85b..e8c019d72cbf 100644
>>> --- a/tools/testing/selftests/filesystems/statmount/statmount_test.c
>>> +++ b/tools/testing/selftests/filesystems/statmount/statmount_test.c
>>> @@ -125,8 +125,16 @@ static uint32_t old_root_id, old_parent_id;
>>>  
>>>  static void cleanup_namespace(void)
>>>  {
>>> -	fchdir(orig_root);
>>> -	chroot(".");
>>> +	int ret;
>>> +
>>> +	ret = fchdir(orig_root);
>>> +	if (ret == -1)
>>> +		ksft_perror("fchdir to original root");
>>> +
>>> +	ret = chroot(".");
>>> +	if (ret == -1)
>>> +		ksft_perror("chroot to original root");
>>> +
>>>  	umount2(root_mntpoint, MNT_DETACH);
>>>  	rmdir(root_mntpoint);
>>>  }
> Hi,
>
> Can you please consider this patch?
>
> Thank  you
>
> Amer
>
>
>
Hello,

Could you please consider this simple patch for fixing build warnings for kselftest ?

Thank you

Amer