Received-SPF: pass (google.com: domain of linux-kernel+bounces-199034-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 3 Jun 2024 13:18:44 +0200
From: Jan Kara <jack@suse.cz>
To: Youling Tang <youling.tang@linux.dev>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Youling Tang <tangyouling@kylinos.cn>
Subject: Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include
Message-ID: <20240603111844.l4g2yk5q6z23cz3n@quack3>
References: <20240603014834.45294-1-youling.tang@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240603014834.45294-1-youling.tang@linux.dev>

On Mon 03-06-24 09:48:34, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
> 
> After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing
> in this file needs anything from `linux/prefetch.h`.
> 
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/direct-io.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index b0aafe640fa4..bbd05f1a2145 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -37,7 +37,6 @@
>  #include <linux/rwsem.h>
>  #include <linux/uio.h>
>  #include <linux/atomic.h>
> -#include <linux/prefetch.h>
>  
>  #include "internal.h"
>  
> @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
>  	struct blk_plug plug;
>  	unsigned long align = offset | iov_iter_alignment(iter);
>  
> -	/*
> -	 * Avoid references to bdev if not absolutely needed to give
> -	 * the early prefetch in the caller enough time.
> -	 */
> -
>  	/* watch out for a 0 len io from a tricksy fs */
>  	if (iov_iter_rw(iter) == READ && !count)
>  		return 0;
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR