Received-SPF: pass (google.com: domain of linux-kernel+bounces-199074-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ac0226c9-c3a4-4cc5-9323-850f79b7718a@intel.com>
Date: Mon, 3 Jun 2024 14:00:45 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next PATCH v3] octeontx2-af: Add debugfs support to dump NIX
 TM topology
To: Anshumali Gaur <agaur@marvell.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Sunil Goutham <sgoutham@marvell.com>, Linu Cherian <lcherian@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
	hariprasad <hkelam@marvell.com>, Subbaraya Sundeep <sbhatta@marvell.com>,
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
References: <20240603112249.6403-1-agaur@marvell.com>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240603112249.6403-1-agaur@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGR0dVZieXJtcFNsaHl1Q2RzZS80QmN0SGtMWWNLMmd1UEVWemtTR09BcGto?=
 =?utf-8?B?eSs4Mk5jREgvYUFXWHNEbWY5ZTlPekgwT3ZxUW4xMklTamZiUU9kYUtGdTNP?=
 =?utf-8?B?dG0zVStUWjhabUpYY0dZVlZvcWx0SEZva0pIN2JUSkJDd0VIT0hqVXVYajNx?=
 =?utf-8?B?NDN1Uk45TEVWdWxTMUU2Q0g1SGIzQ0gwT3Jld3p2WkpPaWp1anMrT2ZYUk9w?=
 =?utf-8?B?WUlack8waXpBOWFLZ0RBWThuQ0pyWFlRdWo2cTJaMlNPSWl3WEFMajRxdXBx?=
 =?utf-8?B?bXlqR1dGWXhkTWk0bU1ocGVCcHZuUVpwU0JjaGh5dTNOK2w4WlJBOU9JbnJn?=
 =?utf-8?B?STZmZHNWdlVlNFNLL3RQRVphdDJQdHc4N2ErS0RadHQxcjMvUC9VTEpQWHJR?=
 =?utf-8?B?d1J5RGlGeHQ5MW9QTENJWThIRklCaGVrSWRBY2h6MEp5KzUwaVFJN3VVS3NN?=
 =?utf-8?B?WWZKQ0RZY291RGkxOHZGVmNvcXE4WmYvaXMyU2R5YTUxNTQrUEJMNkp3RUVX?=
 =?utf-8?B?T0xCTkE2UlljTFNkbWRheGs2Qjh5eVVHTGNaMXlQem5rbFhkZTIzZXVpTW5M?=
 =?utf-8?B?U3VPbHlJaEpIYmJBUXJuQlJyTlo2bmdUUDFLMnVORHVsMmpYdmVEbEZkUEVY?=
 =?utf-8?B?R2hjUDlqOVd4a2l5dFN0NldRUzBWSlorY3JXa1lWUWd0QWhnZmJ0THdLY29q?=
 =?utf-8?B?S2RrVUE5YTYvRmc2S3JOazZYOG9VUWdlQXJqS2lEeVAwU3d0U3FPaml1L1NY?=
 =?utf-8?B?UnVYTmllbXZ4bVB5Q3VZVnM2aFFFejdOQmdXZ1FJaGhBK0lrcElUVmxTSzN5?=
 =?utf-8?B?Q1F2dTNieGpFWDduT2k0NzRXSTE0YXJFdXBEeXVCRGduVHd6YUkrRjRLS2xa?=
 =?utf-8?B?dkNDMjg5dmNHa3E5RGhzbE9URWY4Ykt6Z09jdnArbHlSdEhSY2ZHNkVKcnNW?=
 =?utf-8?B?UlZidFlLS0hVZ3JEL2NWcDU1SVZjcFRWNGx6SElLMnZuSmg5a1JQRXAvMnRm?=
 =?utf-8?B?TFZESEZkSThsSkc3MGRVWWZsMkZhRWIrNGMyNk5zQjhyUEFwZi9pSTRlRFNi?=
 =?utf-8?B?cVcvMzJyWlV5L3dOSUlhNDN0bndRMGgyZm9ZeXRPb3g2SVUzT2JmOEwyeUZy?=
 =?utf-8?B?bGRVSEp6R1dqMDlWTW9NSkowL1dQZHdubGNBNlpLODdOSmxsUkxQSnN3elBL?=
 =?utf-8?B?dWRVN0lxQlovWWZSMlRSZzNxczExN3AzWTJPeHV2MFNRNGFoMlVwWW8vZG56?=
 =?utf-8?B?UVFIOXp4bGwyRk83YUE4WEJFZkVabDdBODZFK1NITWxPa0Qya1Y4eFVibkpK?=
 =?utf-8?B?M2FsM2Iyamo5dXpha1pTMDAwQzJSQ0xkWGtySlNEODZwSHozY1cvQmpzdkxR?=
 =?utf-8?B?N0tTeHdIdyt4cDVvaHk2QmNabzhnUWJxRXNtL2JSR0pqdnFRYUJ4TXd5a2pE?=
 =?utf-8?B?WUVjcUtJTmMxSVpZRDNUemM4M05RSWlTeEJ5VHZFRWJkbW1leGI2bXh6L0tE?=
 =?utf-8?B?U0hSQlluV0IzcEJ6MEprYWxsc2p3Q3V6YlVoZWpqTnB2N1BSekNjT2lYWWU5?=
 =?utf-8?B?b2ZMUVpOeHYrWVNnaWZ2RU9SUVMwM1FtVVg4V3Fiemt5bHdaU2VMQVpHaW45?=
 =?utf-8?B?MitITFVBNjd6QnRFdTF5UDR4RDRJdmkzYjVKbnlPZzhaa1VYNmRHeTlUYWdQ?=
 =?utf-8?B?azRpYUNwb3ZSa0xNK1h6bzV5WnJwZGRuaVQrUGVTeGFCaGdkWXNUQXY0WTNQ?=
 =?utf-8?B?ZHlVYzYxRzdtM04xMjFDTXNQaUJIUmo4UDNtZGJkeWI2a0FiTmFibzZ3ZWFD?=
 =?utf-8?B?bmFEUFBqcDlpa3p4cDBsa0lRQyt2eG8xSTJuWVJvWlZvRFo3U3ZjbHdiNHVz?=
 =?utf-8?B?MjRTb3ZjajEzMXR3dmx0U1pWUkl2ZGtldThDS3FyVEpMa2x4SVFNMHgvNGhq?=
 =?utf-8?B?SW9wTjZzM3YrREt2QUM1T20zTjVlZHRxN0pwU3F3TnhRZFliaHFVNjBjUGti?=
 =?utf-8?B?TUhNRngxY2JBc3A5aW1VWG5BNzRtVmtlUXZIay9oVHhSMnF1NktMcEdIcVZI?=
 =?utf-8?B?YkRXTTdMSHdJT3VJdjNPYloydUNaS2I4SVZ3Zy8vUnROVnQ0M0pNODBFR2xW?=
 =?utf-8?B?MGlRRFlCbnU4T1doVXFEblB4SjRrV2pPdlk3VEhuaWtjdHJWNTJvVzZreFpS?=
 =?utf-8?B?UkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f57bf16-5669-4b11-90ef-08dc83c4d125
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 12:00:52.7980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YL6owSLZ469TM14RXd+2nPqXZbBz/TJ3U6ivRbNJWN+gt3PdM3lGZNjT4lxVXuKc0rj+MBCqwOxg+pLb6z8tSOmQW0kQ7ni4nQdHxW79Y1M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4677
X-OriginatorOrg: intel.com


On 03.06.2024 13:22, Anshumali Gaur wrote:
> This patch adds support to dump NIX transmit queue topology.
> There are multiple levels of scheduling/shaping supported by
> NIX and a packet traverses through multiple levels before sending
> the packet out. At each level, there are set of scheduling/shaping
> rules applied to a packet flow.
> 
> Each packet traverses through multiple levels
> SQ->SMQ->TL4->TL3->TL2->TL1 and these levels are mapped in a parent-child
> relationship.
> 
> This patch dumps the debug information related to all TM Levels in
> the following way.
> 
> Example:
> $ echo <nixlf> > /sys/kernel/debug/octeontx2/nix/tm_tree
> $ cat /sys/kernel/debug/octeontx2/nix/tm_tree
> 
> A more desriptive set of registers at each level can be dumped
> in the following way.
> 
> Example:
> $ echo <nixlf> > /sys/kernel/debug/octeontx2/nix/tm_topo
> $ cat /sys/kernel/debug/octeontx2/nix/tm_topo
> 
> Signed-off-by: Anshumali Gaur <agaur@marvell.com>
> ---

Thx,
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

> v3:
>     - Addressed review comments given by Wojciech Drewek
> 	1. Removed unnecessary goto statement
> 	2. Moved valid SQ check before AF mbox
> v2:
>     - Addressed review comments given by Simon Horman
> 	1. Resolved indentation issues
> 
>  .../net/ethernet/marvell/octeontx2/af/rvu.h   |   1 +
>  .../marvell/octeontx2/af/rvu_debugfs.c        | 365 ++++++++++++++++++
>  .../ethernet/marvell/octeontx2/af/rvu_reg.h   |   7 +
>  3 files changed, 373 insertions(+)
> 

<...>