Received-SPF: pass (google.com: domain of linux-kernel+bounces-199082-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 3 Jun 2024 13:08:11 +0100
From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jim Wylder <jwylder@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>, kernel-team@android.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regmap-i2c: Subtract reg size from max_write
Message-ID: <37abbb4e-cac4-4278-98fb-0af75e5b3ef4@sirena.org.uk>
References: <20240523211437.2839942-1-jwylder@google.com>
 <ZlwfQ3ERbo5snLcK@surfacebook.localdomain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="o/3PMIcJ4m5eaYT/"
Content-Disposition: inline
In-Reply-To: <ZlwfQ3ERbo5snLcK@surfacebook.localdomain>


--o/3PMIcJ4m5eaYT/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jun 02, 2024 at 10:29:07AM +0300, Andy Shevchenko wrote:

> >  		    (bus->max_raw_write == 0 || bus->max_raw_write > quirks->max_write_len))
> > -			max_write = quirks->max_write_len;
> > +			max_write = quirks->max_write_len -
> > +				(config->reg_bits + config->pad_bits) / BITS_PER_BYTE;

> Interesting. regmap-spi does this slightly differently, i.e. reg/8 + pad/8.
> I'm wondering which one is more correct (potential off-by-one I suppose).

The above seems more correct if we have less than a full byte of padding.

--o/3PMIcJ4m5eaYT/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZdsioACgkQJNaLcl1U
h9AAkAf+LVj40HA9xmSzj0Hr25sNKsNGbVaeKDNu4SfyvU4xByXqHWlF7IKQZC7w
4IQgrm5DThNk+dX34NeuR7IjC3wp3/rQLGPvYiH0IKoArBoGXB92/R50RB7piFhp
bFw0OgWyJ/jxWrwPAz8a/zHaxNLdN1ck21WhwTGr2z3IONKgo/k293keZJxt7kvD
fw6O9ljs1tka5yrF82DDDGGae+G6sHvhlpvdqj4hC9Yv2fzNy+ep/uXsy5aeNg2I
z4mW6fFpjYmoqZSEoiZKWNW3NzffOV9ZxTlgn4Lw39DkXkMEqT+d1riKNQi8lQSv
ZgCt9QB/2D/PrV0KY0UDDGc6Qm6zrA==
=OKvO
-----END PGP SIGNATURE-----

--o/3PMIcJ4m5eaYT/--