Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp923264lqj; Mon, 3 Jun 2024 05:19:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVSJwTxNrtxoJKedrHeZK6d43XftdS9WDnaUvXOnT1XdP37RaAt9U2TO1/bK0GkCMA0s0E5nHdhXjPB0jBKURf75ZgeMtRMr/YL0hW1YQ== X-Google-Smtp-Source: AGHT+IGeiYg6t5+yBGrKuejrGEg2V7z32FX4c64BE1hKCLhytuz1RYpbclQ59pyE+YBaryOCRSZF X-Received: by 2002:a05:620a:460a:b0:794:f992:265a with SMTP id af79cd13be357-794f992296cmr981378485a.25.1717417163412; Mon, 03 Jun 2024 05:19:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717417163; cv=pass; d=google.com; s=arc-20160816; b=eSGwxSROtplt5g4d1e0QotPxtmCuQKDZfoOzM3Nn3I3Err69i3l7ycFcWl+H6YTim3 r8LlxRU/3FULHCTBkpKkpIx5FQfhC2R6vt9Hzt3GsIHdPE+c0lDdFDcHv8IRHdE9rmhW 2P6A2mUz4ruVae8/xCS/Dpztpw7Nnfbl33YOcFQSIOAMAgtQN0sBSep+gQF9CZBJbDqh V2Lo6/T/9CYEqwqg3YNVKhw02l40ATK6Aq/aGAYGFfMGj2TXIbQjuVzcbyavxmzyR4cl rCPtggC2T1Cc8buCcpSKqeO+P/7NDLOdBPUcTjrjjzEpZ1NGNssq3AKNvCGboL2iD13Q UgzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:subject:cc:to:from:dkim-signature; bh=FVvvLwue4SCj5PzUi7YxHuuFlmPk46DEXSxEQV7xEg0=; fh=64w9rzpF6DVhguYLsxgNyXq+elZJt94iD6uwxQl/s+k=; b=V3dI1IRbSV2/yynJKhsbOldZLiswKOah9gXtms0NZzQ3rDt/BArfGZ3pXVUX+xjaOL /JHvtTcvwBJBLgiWNn7apgQCEGRDxab7esJzlSQ2pE3HgOOrIJGuD2wSc+S2k+SIHpaX 7EcZtMcsyTYDlDUocB609U1cJk3XqsvoLA8ZoAeAB7grqRSiwfN5PzWBPsdFyUdhFry0 WSVbYQapc/z4rAQ1h3PwQ3of5VfTP1XyeqyJYousaqkxdiVMJ/yph/PYvkk/m7puq+/c UbB8gbt67OzFPQKpy3QiO3L4FjJCXM2s8BQshiSfMlTUASAQgxpJEwZ7wpwqaYwlmK0g 4SYg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=LTLtNBqK; arc=pass (i=1 spf=pass spfdomain=mediatek.com dkim=pass dkdomain=mediatek.com dmarc=pass fromdomain=mediatek.com); spf=pass (google.com: domain of linux-kernel+bounces-199094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199094-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-794f32bd697si745709785a.786.2024.06.03.05.19.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 05:19:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=LTLtNBqK; arc=pass (i=1 spf=pass spfdomain=mediatek.com dkim=pass dkdomain=mediatek.com dmarc=pass fromdomain=mediatek.com); spf=pass (google.com: domain of linux-kernel+bounces-199094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199094-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C70991C2386F for ; Mon, 3 Jun 2024 12:19:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BC73E12BF1D; Mon, 3 Jun 2024 12:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LTLtNBqK" Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B61812AADD; Mon, 3 Jun 2024 12:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717417129; cv=none; b=fatHEQCYd7x6/OauIxqTy2G8p0pqk6Q9gOg+LdrbboioZ17iwrfP3/DBRqgKRSzoWLOWGCIwiW2F20w6iRI64jZwJnvUWOA7GEfcr/o2nplnrCltwZBMoazldmd2c5CAMdGRkLp2JgYO4X3J6qWg5xWmdghswbmSyXmQPnOo8W4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717417129; c=relaxed/simple; bh=D94SG2/sR7g1EjhtsW2xbGHuKC1gaGg8Ua/Tl8ISBvU=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=O9SLnIN7aqgqgLOeogWPXUbXrClxo2ujZH6jl8mRyq16XE9S7o21xmhV9pbfO9Pb1DFo4Qetfa3P90fly3cs2OSFvw8gvKatYY1Ks+HFeW0KV6brE5i+DhEyjGibnmSBIV7EkbtKfo7t5gbdeO7o8K1UvHZlASykP6uUsSGcqDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=LTLtNBqK; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com X-UUID: 6966d98c21a311efbfff99f2466cf0b4-20240603 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=FVvvLwue4SCj5PzUi7YxHuuFlmPk46DEXSxEQV7xEg0=; b=LTLtNBqKs2j3m/2/gR003VEYXF1xy7vl6sEkp/xo9HIfw/PGZxpaKP3dIuJn252Yp74XYsptNsofP+Hx4gAzlSkVI7uZDfhvnuEhy20sCsPMfRMtemQ/QLkkO2rztK7DXhRyBIS4BzNZ2mDzzuwrmy1xZKR7F1K9azv838c3F4c=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.39,REQID:365d1b3e-81fb-45f2-82e9-5160a46d1159,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:393d96e,CLOUDID:40148e93-e2c0-40b0-a8fe-7c7e47299109,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 6966d98c21a311efbfff99f2466cf0b4-20240603 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 514463508; Mon, 03 Jun 2024 20:18:40 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 3 Jun 2024 20:18:37 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 3 Jun 2024 20:18:37 +0800 From: Sky Huang To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Daniel Golle , Qingfang Deng , SkyLake Huang , Matthias Brugger , AngeloGioacchino Del Regno , , , , CC: Steven Liu , SkyLake.Huang Subject: [PATCH net-next v6 0/5] net: phy: mediatek: Introduce mtk-phy-lib and add 2.5Gphy support Date: Mon, 3 Jun 2024 20:18:29 +0800 Message-ID: <20240603121834.27433-1-SkyLake.Huang@mediatek.com> X-Mailer: git-send-email 2.18.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--5.801800-8.000000 X-TMASE-MatchedRID: e1D+mFe0mXuGeTbGWdRz1qUebN0FQAbYvtVce6w5+K9xUZeguPBDQcbK +pu0ZYwR6NJ1g8TkaiY/4sXBdVnb/U2VnXMRzIBj4bl1FkKDELchotH7bEpEMmecrqZc3vabN1L b3d91KD/symnxq9L1AixzufF6vmDubw8f/jlV5scdxBAG5/hkW1sChor7BLiN10wPNIuvyi/Akt gDJtZ0AmMl2fVuI+54nGl+g77/qoc/REwOA9OGte7KTDtx8CggLE3mrqeLTCsOUs4CTUgKy0MHU R1yMHZ62JwKrFIIzlEaMs2ZphvTvQRCoiooUu1OA9lly13c/gHP5QiZIw0wxWRuoH6AAg50sSZN qeM/MnPi8zVgXoAltsIJ+4gwXrEtec3QM3secWZu9xS+8dccnb7mwioSDeHWwUQdvNL5Fiu33e7 wtXyKyyQMR54A4ZhIlExlQIQeRG0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.801800-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 9922CDD3497FF3EF925E490724F0009F318158C0A7EF8939F982D3A111C601DB2000:8 X-MTK: N From: "SkyLake.Huang" This patch series integrate MediaTek's built-in Ethernet PHY helper functions into mtk-phy-lib and add more functions into it. Also, add support for 2.5Gphy on MT7988 SoC. Signed-off-by: SkyLake.Huang --- Changes in v2: - Apply correct PATCH tag. - Break LED/Token ring/Extend-link-pulse-time features into 3 patches. - Fix contents according to v1 comments. Changes in v3: - Rebase code and now this patch series can apply to net-next tree. [PATCH 4/5] Refactor mtk_gphy_cl22_read_status() with genphy_read_status(). [PATCH 5/5] 1. Add range check for firmware. 2. Fix c45_ids.mmds_present in probe function. 3. Still use genphy_update_link() in read_status because genphy_c45_read_link() can't correct detect link on this phy. Changes in v4: [PATCH 4/5] 1. Change extend_an_new_lp_cnt_limit()'s return type and all return values 2. Refactor comments in extend_an_new_lp_cnt_limit() [PATCH 5/5] 1. Move firmware loading function to mt798x_2p5ge_phy_load_fw() 2. Add AN disable warning in mt798x_2p5ge_phy_config_aneg() 3. Clarify the HDX comments in mt798x_2p5ge_phy_get_features() Changes in v5: - Fix syntax errors of comments in drivers/net/phy/mediatek/* [PATCH 1/5] - Change MEDIATEK_GE_SOC_PHY from bool back to tristate. [PATCH 5/5] 1. Move md32_en_cfg_base & pmb_addr to local variables to achieve symmetric code. 2. Print out firmware date code & version. 3. Don't return error if LED pinctrl switching fails. Also, add comments to this unusual operations. 4. Return -EOPNOTSUPP for AN off case in config_aneg(). Changes in v6: - Re-arrange patch and changes description in cover letter. - Contraint code inside 80 columns wide. [PATCH 4/5] 1. Add LP_DETECTED so extend_an_new_lp_cnt_limit() won't be called every time we poll the PHY for its status. It'll be called only when cable is plugged in and 1G training starts. 2. Call phy_read_paged() instead of calling phy_select_page() & phy_restore_page() pair. [PATCH 5/5] 1. Force casting (fw->data + MT7988_2P5GE_PMB_SIZE - 8) with __be16. 2. Remove parens on RHS of "phydev->c45_ids.mmds_present |=". 3. Add PHY_INTERFACE_MODE_INTERNAL check in mt798x_2p5ge_phy_get_rate_matching() 4. Arrange local variables in reverse Xmas tree order. --- SkyLake.Huang (5): net: phy: mediatek: Re-organize MediaTek ethernet phy drivers net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib net: phy: mediatek: Extend 1G TX/RX link pulse time net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 MAINTAINERS | 7 +- drivers/net/phy/Kconfig | 17 +- drivers/net/phy/Makefile | 3 +- drivers/net/phy/mediatek-ge.c | 111 --- drivers/net/phy/mediatek/Kconfig | 38 ++ drivers/net/phy/mediatek/Makefile | 5 + drivers/net/phy/mediatek/mtk-2p5ge.c | 435 ++++++++++++ .../mtk-ge-soc.c} | 640 ++++++++---------- drivers/net/phy/mediatek/mtk-ge.c | 249 +++++++ drivers/net/phy/mediatek/mtk-phy-lib.c | 427 ++++++++++++ drivers/net/phy/mediatek/mtk.h | 116 ++++ 11 files changed, 1544 insertions(+), 504 deletions(-) delete mode 100644 drivers/net/phy/mediatek-ge.c create mode 100644 drivers/net/phy/mediatek/Kconfig create mode 100644 drivers/net/phy/mediatek/Makefile create mode 100644 drivers/net/phy/mediatek/mtk-2p5ge.c rename drivers/net/phy/{mediatek-ge-soc.c => mediatek/mtk-ge-soc.c} (74%) create mode 100644 drivers/net/phy/mediatek/mtk-ge.c create mode 100644 drivers/net/phy/mediatek/mtk-phy-lib.c create mode 100644 drivers/net/phy/mediatek/mtk.h -- 2.34.1