Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp939687lqj; Mon, 3 Jun 2024 05:50:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUzNfI295CHrYxUpyhhgduh3o9wAVaV/9MVvRIgCA8Y2uaTabFU/CY5kAVf1NvLiyCmJg1H89qfUebpMJy4+tyXOjEnveCYSz4J0pPBVA== X-Google-Smtp-Source: AGHT+IHp36yOtyFlsqUG4EAo7xFLPigxjYLcVZsSwvpKwlJFjLNmCH5wZM90AHyw0YPJc1FXw6Cp X-Received: by 2002:a05:6870:f14a:b0:250:d5bc:7346 with SMTP id 586e51a60fabf-250d5bc7726mr3252184fac.3.1717419045541; Mon, 03 Jun 2024 05:50:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717419045; cv=pass; d=google.com; s=arc-20160816; b=PvEgRaVrvzKiegM9ksSXZ+sDD26EqRWJUSJY4I5+wf0BjLN4CQqsKKoPsPptOgSFog KVIsRa8u/UcNrdfje06/srBKRIapcjfauMMQ8HcJWxGCqxO4pgGFRa+26k5IcP1mEjZt NZGqreqYRU2ufPhbyReGkYKAKp9HWVr6GB74B8xbn/mSYnEId50EXYCx1tdQzzzdhtcO IcA3cHV1tsrgegrJPyH7Ut4TWAFa2hNpBh21taxFIygY3gc32gSf67EvlpWv4c/YI9U1 af+S0CcV0IwRyT/oeolJDqYUboHMkOh8g5JoBRD8bzIq8J/2TDDMQuPB+VaWKzXkjegw cjgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=o8VeUj32vRwgbd7gbBCv405ugpVHkIfEbgY0N+hn6Qk=; fh=87V4DBZuTPv5EyhClGNEL+FTbdjXlTP0dNCG+h7qGQU=; b=rjojqR87ViML27S473I8K1jLvaZpCXDpjLautOrYrSmEzPHlyOF0JxzGpougtXHNuT OTuoyT9eYX/Lj/yz5ZHU+3i7FfXTYKCnVhTWEu6+OylghTu93R2kUSo9H4QlV4i0V/ew NkL9AZ4qYyy3tt6rf4K6xz9RHysZrh3sVT86Val/qtVnk2PVYlBA41NLxCQtWoEskUmn 4/C9QEHNT1PirsWDyVAvxxIdTA6sPcpimDfdR58uPsVRDhf4xh3GVkcDUwM5gmrCMICc JjJPb4Bo8SoAVqCOcD9ny70NK9epvI1rzD9Ee+rghMb1SzEMJlCAoj296MdbiVPOTJPM VTmw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ssboo9KI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-199126-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199126-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c35b40bd67si6372199a12.489.2024.06.03.05.50.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 05:50:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199126-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ssboo9KI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-199126-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199126-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 738CB281A9A for ; Mon, 3 Jun 2024 12:46:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 785CF12C528; Mon, 3 Jun 2024 12:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ssboo9KI" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98A9E1E491; Mon, 3 Jun 2024 12:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717418774; cv=none; b=OgKUXRRKptIH/ZYDxDr4rEz0c4zTfrVeMGaBXU2pt5Pzu0ZepUZaQroW4MRZmozNMdEawZQDS0dBpeRFjRJrHR+HxjK1CcgtH/OASB/c/HQQVPHDPKw3Obk6w7Q6tiAU29sK8RfAFvV+rhlBTgYlOEedn2GYOOmn3ypCWjcX7Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717418774; c=relaxed/simple; bh=4RsD9/C3pEBXc6FiOISGRqAdcjs1/UJEsDEwucWnhkM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IMYiMIVFxBIqgFeXMl5RjVsXXM4T9z95mcZwprOfAlOmW4aYeecFm1S9ZeGIC59ViCpkIMTS8i+LeB4EqI5y2dar8sEpFJ0Uz368RkiaKZ9rKT/0CZicqBxVBZxkHQC6MYWg1PXyzGipU6qkdTzX9ADigqV+Ecp85QZ9+sJutRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ssboo9KI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62CADC2BD10; Mon, 3 Jun 2024 12:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717418774; bh=4RsD9/C3pEBXc6FiOISGRqAdcjs1/UJEsDEwucWnhkM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ssboo9KIENmb5gqh+naudYKIJ+9RWIpHdaOIXmtVsWHL3kLHI3zxKd8E671GAccVs /UN76bXZeO5KUDuLi8QHumctJ6pw2U96o7qAG6oHtKDtl1gzglObXGYY0+3xbfq48m wDlRDLR47Kp5lnh6fPck8e+V8eWFHMkwU1WXCRGIGcwKjJzdEP9MgqXN+qm9Vlfn74 VpCiER07m726Eq3t+m+cyLn2X3mnbDWfMBzJLoYhfqGOnXJkLKFS9P1JvSz0PuZu8o g+tosvKVkqjCN1bPwUhOpMAFJMQqsYeuqjfRD5dntj2wF/uGIWpYEdzuSued/aHjpN Hm3/EYfjqXCNg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sE74m-000000000jf-1Gj3; Mon, 03 Jun 2024 14:46:12 +0200 Date: Mon, 3 Jun 2024 14:46:12 +0200 From: Johan Hovold To: Abel Vesa Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] phy: qcom: qmp-pcie: Add X1E80100 Gen4 4-lane mode support Message-ID: References: <20240531-x1e80100-phy-add-gen4x4-v1-0-5c841dae7850@linaro.org> <20240531-x1e80100-phy-add-gen4x4-v1-2-5c841dae7850@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531-x1e80100-phy-add-gen4x4-v1-2-5c841dae7850@linaro.org> On Fri, May 31, 2024 at 07:06:45PM +0300, Abel Vesa wrote: > The PCIe 6th instance from X1E80100 can be used in both 4-lane mode or > 2-lane mode. Add the configuration and compatible for the 4-lane mode. Same language nits as for patch 1/1. > Signed-off-by: Abel Vesa I tried this patch along with the DT changes and the link on the CRD still comes up as 2-lane: qcom-pcie 1bf8000.pci: PCIe Gen.4 x2 link up so something appears to be wrong here. (I noticed the same with your next branch last week.) How did you test this? Does the link actually come up as 4-lane for you? Johan