Received-SPF: pass (google.com: domain of linux-kernel+bounces-199160-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e9ade241e57383d5342d377bc865046e612a7033.camel@gmail.com>
Subject: Re: [PATCH v4 3/6] iio: adc: ad7173: refactor ain and vref selection
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, Dumitru Ceclan via B4 Relay
	 <devnull+dumitru.ceclan.analog.com@kernel.org>
Cc: dumitru.ceclan@analog.com, Lars-Peter Clausen <lars@metafoo.de>, Michael
 Hennerich <Michael.Hennerich@analog.com>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>,  David Lechner <dlechner@baylibre.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org, 
 linux-kernel@vger.kernel.org, Dumitru Ceclan <mitrutzceclan@gmail.com>
Date: Mon, 03 Jun 2024 15:00:21 +0200
In-Reply-To: <20240601194925.23123071@jic23-huawei>
References: <20240531-ad4111-v4-0-64607301c057@analog.com>
	 <20240531-ad4111-v4-3-64607301c057@analog.com>
	 <20240601194925.23123071@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Sat, 2024-06-01 at 19:49 +0100, Jonathan Cameron wrote:
> On Fri, 31 May 2024 22:42:29 +0300
> Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel.org=
> wrote:
>=20
> > From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> >=20
> > Move validation of analog inputs and reference voltage selection to
> > separate functions to reduce the size of the channel config parsing
> > function and improve readability.
> > Add defines for the number of analog inputs in a channel.
> >=20
> > Reviewed-by: David Lechner <dlechner@baylibre.com>
> > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > ---
> > =C2=A0drivers/iio/adc/ad7173.c | 71 ++++++++++++++++++++++++++++++++++-=
-------------
> > =C2=A01 file changed, 50 insertions(+), 21 deletions(-)
> >=20
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index 6e249628bc64..a20831d99aa5 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -60,6 +60,7 @@
> > =C2=A0#define AD7173_CH_SETUP_AINPOS_MASK	GENMASK(9, 5)
> > =C2=A0#define AD7173_CH_SETUP_AINNEG_MASK	GENMASK(4, 0)
> > =C2=A0
> > +#define AD7173_NO_AINS_PER_CHANNEL	2
> > =C2=A0#define AD7173_CH_ADDRESS(pos, neg) \
> > =C2=A0	(FIELD_PREP(AD7173_CH_SETUP_AINPOS_MASK, pos) | \
> > =C2=A0	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
> > @@ -623,6 +624,7 @@ static int ad7173_setup(struct iio_dev *indio_dev)
> > =C2=A0static unsigned int ad7173_get_ref_voltage_milli(struct ad7173_st=
ate *st,
> > =C2=A0						 u8 reference_select)
> > =C2=A0{
> > +	struct device *dev =3D &st->sd.spi->dev;
> > =C2=A0	int vref;
> > =C2=A0
> > =C2=A0	switch (reference_select) {
> > @@ -646,9 +648,11 @@ static unsigned int ad7173_get_ref_voltage_milli(s=
truct
> > ad7173_state *st,
> > =C2=A0		return -EINVAL;
> > =C2=A0	}
> > =C2=A0
> > -	if (vref < 0)
> > +	if (vref < 0) {
> > +		dev_err(dev, "Cannot use reference %u. Error:%d\n",
> > +			reference_select, vref);
> > =C2=A0		return vref;
> > -
> > +	}
> > =C2=A0	return vref / (MICRO / MILLI);
> > =C2=A0}
> > =C2=A0
> > @@ -905,13 +909,50 @@ static int ad7173_register_clk_provider(struct ii=
o_dev
> > *indio_dev)
> > =C2=A0					=C2=A0=C2=A0 &st->int_clk_hw);
> > =C2=A0}
> > =C2=A0
> > +static int ad7173_validate_voltage_ain_inputs(struct ad7173_state *st,
> > +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const unsigned int
> > ain[AD7173_NO_AINS_PER_CHANNEL])
> I was late to the game in replying to previous thread.
>=20
> This is neater without the loop and with 2 parameters.=C2=A0 Anyhow see r=
eply to v3.
>=20

Yeps, even more given that we're passing/copying the complete array which a=
lways
fells awkward to me :)

- Nuno S=C3=A1