Received-SPF: pass (google.com: domain of linux-kernel+bounces-199171-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, "Luck, Tony" <tony.luck@intel.com>, "Arnd
 Bergmann" <arnd@kernel.org>, Borislav Petkov <bp@alien8.de>
CC: James Morse <james.morse@arm.com>, Mauro Carvalho Chehab
	<mchehab@kernel.org>, Robert Richter <rric@kernel.org>, Marvin Lin
	<milkfafa@gmail.com>, Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>, "Sai
 Krishna Potthuri" <sai.krishna.potthuri@amd.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] EDAC, i10nm: make skx_common.o a separate module
Thread-Topic: [PATCH] EDAC, i10nm: make skx_common.o a separate module
Thread-Index: AQHasa3aksCJcLTTrE+3snIA9cs7hbGuY0qAgAAB8QCAB5hEwA==
Date: Mon, 3 Jun 2024 13:02:31 +0000
Message-ID: <CY8PR11MB71345BD92CF809FCFA5E890D89FF2@CY8PR11MB7134.namprd11.prod.outlook.com>
References: <20240529095132.1929397-1-arnd@kernel.org>
 <SJ1PR11MB60838B76940188104D57E53FFCF22@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <e526fbec-5fc6-4778-b46d-608744a4d7f6@app.fastmail.com>
In-Reply-To: <e526fbec-5fc6-4778-b46d-608744a4d7f6@app.fastmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B4ip83QCMHR4+cw4FjH1+GECqU+UnlZThrA7SiTMEIqHjQOLdNlB9C8Iolml?=
 =?us-ascii?Q?kPQScXiutioCH4iFmcwLtegD683MaRCcU4N2bnVDj8p5xD75jtFE5RL0a0NA?=
 =?us-ascii?Q?5DhevpQ5PLbMEzeG4LfEZNxfAMdY7TUl4uApOFwN636ZGZtr9lVzlwz0/YZw?=
 =?us-ascii?Q?iMKyH32SPZXhQ0bJuMTzPDki91SD13OngbXe6hGT3aSzpwXwHO0Um3O288g+?=
 =?us-ascii?Q?U3giqXVvc31EfBwz0uXdpqymtlA+YiS9L2NWOYbPGNzC8dZAn9vkrG+aJhho?=
 =?us-ascii?Q?eWgvdSvZYDHUrtjXOMJqmbQCOkQZr/H9nFUQ62US2TKTyac6nPS4aTf5BCVa?=
 =?us-ascii?Q?bcsuSeiP4so/XyH997ByhVX/Uc80lt2u5+ZJc+ybo9IA5O8SGm8RLpxZKVMR?=
 =?us-ascii?Q?dAKJ4PcdxyRCj2qOWB7GG4fCYy03JtFSic7UZRscmyFfViD8Xgd9KyiubqTZ?=
 =?us-ascii?Q?/4ftoNKDKWCLeIK2WcN9ea5SGpW1ej+BpcLRF6/YsRIiUBDrqsWfA7ppt/I9?=
 =?us-ascii?Q?8VB1X5ZxLggEITSS+YrORGHfLLGEg67s/Qj+ssnK2eqX19xVRdrexzeh4wPB?=
 =?us-ascii?Q?ZHztxMCIMMIzJ9zYUwogPcM3e5q9ZklrfJiN6nnnIbTKJoIdIDpdjgjNlSpi?=
 =?us-ascii?Q?DDoCsN0l5Ug+DzsoNJO2+AY3lLYcZ7oCACdcTIlvAZ2O4sVymgG0JkPmGG4l?=
 =?us-ascii?Q?7nXpT9gMeO+hf/KBNr4FeaHfIPu//d99nvtgU//ld02YCcQ0leiYIVT9j1SC?=
 =?us-ascii?Q?aZgQHNvTjM0kSgPYrIJthMWcaFfMoaK6HjugUombH2PEtqRhL7eyC2LGEYox?=
 =?us-ascii?Q?YqLLb/SK6oZTFO8J58rbqWCxadTt6mwUWcANU/23d//w/1aVDguMIAiZnaDu?=
 =?us-ascii?Q?OttbI2CSa7OalSni0Gge5Rzvc3XmXflW7MrJoSafzSDRp8uo8dxXQGIZDYOY?=
 =?us-ascii?Q?J/0OqfV9qPPAD08gGuJ1Xq2hTGofTWB8bZ0t5PIpDKVITgyyTP5eikx/Whwk?=
 =?us-ascii?Q?eD4gIvgTgRaqORS4RdyKqfCL9YmgDjIFyte0I9t30Dso8UP79OsMZytLpp8Z?=
 =?us-ascii?Q?sV8OMNigggZ2N/GqxDBvySx+Iy+QC/aqP+KL64lHNjbQODc4++MH233LarxB?=
 =?us-ascii?Q?7PVEZNDrz57o4ow25MKkK3KJB/QkPpCNZc1bM/iGHtcHtRMuXsPRKEp94m2f?=
 =?us-ascii?Q?2xtXvbEsJO8Qez7B2XWJ1zsTKKW8vT2cExZD3RBctbm67sxA/OYKz5h1olno?=
 =?us-ascii?Q?Xbw9pF8w+E89XZ2C/0L9JTj8F+q7fuJHF0GY/1GlIdWqgkC7FtmHpNcQr0YE?=
 =?us-ascii?Q?WR/HD7o0RnIpnL7COGsZFsvZ3Q4tDXNpaxey9niShpxohl6f6JDdRoqqXtxz?=
 =?us-ascii?Q?4SNlY4OjEkegW4e6dSYOUEsBWA4L/K5fvylnu7DqCZKShywMq6xgxav6590B?=
 =?us-ascii?Q?Xy/58zKvXIMl6yAPf8qzK0Ou2dZeByQotZuN3Htg30Ra4TlVDseopirJtMyu?=
 =?us-ascii?Q?Xf/5yiDF8kbnxemy8vw3s7l74pixTwodoDoo+85fcTFjADHlG6ZetcXnUdPz?=
 =?us-ascii?Q?nsWSwlhVnY6YLwFe0pYO1QPVUM+5ilP4dBR8XEkq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7134.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87000779-4362-40fb-7624-08dc83cd6df3
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 13:02:31.5445
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z7dshMpqD6QH0fqa30PtsE3Yg4r6SLPxx2a3OCeuRqASZIogi8KKowzrK0f20HS8hpfpCmuAXo/kD9rNHXVQuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6917
X-OriginatorOrg: intel.com

> From: Arnd Bergmann <arnd@arndb.de>
> [ ...]
> A particularly bad case happens when one of the two is built-in while the
> other one is a loadable module. In this case, the module infrastructure
> assumes it's always built-in, which can mess up e.g. __exit annotations a=
nd
> THIS_MODULE references.

Hi Arnd,

Thanks for looking into this.=20

I re-verified the following configuration w/o your patch, it worked well, a=
nd I didn't see
__exit annotations and THIS_MODULE references got messed up.=20
This was because skx_common.o was built into separate two copied texts=20
(one is built-in, and the other is in the module).

1. Kernel configuration (one built-in, one module)
    CONFIG_EDAC_SKX=3Dy
    CONFIG_EDAC_I10NM=3Dm

2.   Build OK.
      Loaded/unloaded i10nm_edac.ko on an Intel Sapphire Rapids server succ=
essfully.=20

3. Symbol in skx_common.o example:=20
      [root@fl31ca103as0104 ~]# cat /proc/kallsyms | grep skx_adxl_put
         ffffffff832c7da0 T skx_adxl_put                            <--- sy=
mbol in built-in kernel
         ffffffffc094a350 t skx_adxl_put [i10nm_edac]   <---  symbol in 'i1=
0nm_edac.ko' module

Thanks!
-Qiuxu