Received-SPF: pass (google.com: domain of linux-kernel+bounces-199195-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 13.93.42.39 as permitted sender) receiver=protection.outlook.com;
 client-ip=13.93.42.39; helo=westeu12-emailsignatures-cloud.codetwo.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
From: Mike Looijmans <mike.looijmans@topic.nl>
To: linux-usb@vger.kernel.org
CC: Mike Looijmans <mike.looijmans@topic.nl>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] usb: dwc3: gadget: Inform system of suspended state
Date: Mon, 3 Jun 2024 15:13:04 +0200
Message-ID: <20240603131304.233403-1-mike.looijmans@topic.nl>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 =?us-ascii?Q?R24Miv8hDYuzJVIsetTrBo10R1XKUpIVcZyNSuMepDG8bdiWnxMu6TkyfWO9?=
 =?us-ascii?Q?hE1mSfCbiCpftqgqh2GujGySqOu8FZUETFXPcTsNs+LuV1Uihj6XuBDxGjym?=
 =?us-ascii?Q?RSB/unRvh2VbtxOJwVcmUISM1Gf+oQZaRuILWWJw+4iNbaHEXo7Y/rxs9f2+?=
 =?us-ascii?Q?JuOOfEFFheKd6/j1VSG/rFZvPknSmzVTlhxyPMva6eGykA6p2dYKSF3OclQv?=
 =?us-ascii?Q?NKq00SdiNTcmJyTgni8101VoWamNmgwLciD/IDRCcpvU8YDehg6h4H5MGu8M?=
 =?us-ascii?Q?8wzpl+ra0PmIIpgo4dQxqbv8AUFE2UEoVmwzDOWXDJW5X1ql2cM+SRSZQGY8?=
 =?us-ascii?Q?hAq1pcWkEOCN20/wjA7/KauysDeOqC6QAA84xSKvw3Axp7ig3CXSb2OA7OmT?=
 =?us-ascii?Q?Z92W6cY3wIo/2OvZ0A8BoOa/MqzoqlUg1NJm4vVR1NTEsWYBKXoFwzGMfNFQ?=
 =?us-ascii?Q?TG/6exJK+PyxaT3YUe8OyA1uebZfc1Icdk2dXZlgHzACGPdVzaGhvPSeEdD7?=
 =?us-ascii?Q?uCo9WNqZsbnAYw8ip6GoGkWx/NzNINXrNBKuXFZdjret2SGl00BY9BYhvSKm?=
 =?us-ascii?Q?kOb0JB0u5PFN5G4wBDLGZaoWKUEymZrsWgwfOkyY+Iifgc425wDCfRlBX90r?=
 =?us-ascii?Q?BCHhRfYkUL07Hq4WemX7YORnAe19l/cIqe3xbp7FF44FVstKDcnxNXo6tYzR?=
 =?us-ascii?Q?TzX0WHF+n9bCcN4BTPnwvFrU5X7LVa1Ii5CriY8qHZamouA+mLKft7QIjN6Y?=
 =?us-ascii?Q?2shBw5eTp8xnvZ5JzNGlL0OZA+/Lqd+X66gV39I3LIdepLpP8GeFKPkwc+y+?=
 =?us-ascii?Q?cNHcF+LMvKd/dQTMSP9gUOFU+BlvonBdm3Y30w3fotFJzx5HclNBjjljKNXm?=
 =?us-ascii?Q?sX5pbbWGwV084w3YH683+2QJJYLQ5oDejdC7Bdg7SR7ZlxECVUmRfnl6QSsh?=
 =?us-ascii?Q?alGBoX7UFa2gCfoFUNpifxs1DYx4e6XKqISDRvlrUrixYpQ0Ar8fgh+gjpCb?=
 =?us-ascii?Q?V3xKUqDEkZf1cJWVdN4MAjcgw9NlJ7FNNoqRXnWb3jAnUGaVDcQMbFNi25ty?=
 =?us-ascii?Q?R6+v5kauhD/n3SwJcsEWvV2l9io6AtCQr4Kjb4QgHgu2niCQ/GHpNdGI1Uss?=
 =?us-ascii?Q?KlOvrYrjvM5Z7cpocjgrZj1IGT/fc9zjw7g97FOk4M94ryiAfQ6Et/J15Sns?=
 =?us-ascii?Q?FEnlKZsFvJb/61AqAFLfbpGtvEfedX8RWuW9Sas9gBv3dShydkd7F2aidDPn?=
 =?us-ascii?Q?UBMFggn97URHdfNpVrb7oklW9L95N03Iw33pHpSiHLf5v0D4N0fk41f5QUTt?=
 =?us-ascii?Q?gJ+8WSruFSXuqoak5mhjhsauWocNIJwBsDNo5nlce/dUBg=3D=3D?=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7929
X-CodeTwo-MessageID: 12ebd205-b4a2-4b8c-bc9c-a3e90792ead2.20240603131314@westeu12-emailsignatures-cloud.codetwo.com
References:
 <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.c5f44c79-75b2-43c1-a791-806fe8b693cd@emailsignatures365.codetwo.com>
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB3PEPF0000885C.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3b6bf983-709d-490e-fe52-08dc83ceeac3
X-Microsoft-Antispam:
	BCL:0;ARA:13230031|376005|36860700004|1800799015|82310400017|35042699013;
X-Microsoft-Antispam-Message-Info:
	=?us-ascii?Q?raoQRY2ZEe/cZ5AYotKnhFooOvLL1BS8kD+fApGyHr0duivoWGRyCRPuUhTH?=
 =?us-ascii?Q?zLgIIX4M9EUfVc9YPTKLBUSXm4xcQoMqs0/tebTBg/1G6+t8drFlmscJs1KO?=
 =?us-ascii?Q?35/VHeI8YH/eqs4lJlq9fa/q/8TlrJYONundkIhdG/6ol57K0ERhE5tMw8Oz?=
 =?us-ascii?Q?YMdj25/hM8RiUldJfPpyChlF9/N9nlPYlWA0jkE6D7UgVssCWzjcdMcTDVn1?=
 =?us-ascii?Q?Xb6sKAF6sfh9PI94vPpjZh4qrRIOkPvdBEQPo9T93bbe16iqsemv+uh8coce?=
 =?us-ascii?Q?7F0ZziyLNJywRCWoPKTNVTV/MMVtVk8LVh2Ej8HYyOMSrhbNs1umfy4UpBpi?=
 =?us-ascii?Q?yJFc1szSCRRNJfr9dmSgT++jSbwrPQEc083dKMfwIANPoEQ9GrKNZNkbgFQn?=
 =?us-ascii?Q?GiZ9EHwLF5Sgkaj3Ytg4WxZ9pBquScMLU9CI4XBsYhDldvHuFkFiESDmeOyx?=
 =?us-ascii?Q?9qKL6Kd4ugOfIFGkGNocU6crLI/TIQOD+eYGYi0zvep6DWJ/OJ0Agp++wABu?=
 =?us-ascii?Q?9bee6tieKtLVf9AqJSDgaLwBjAN/Rf6K1kwKhbQU3FK9AAOLgQ634ewTaMbl?=
 =?us-ascii?Q?JYTzhZtu/qyHjVt7JE85iO5q2kilUojXjSYycfJ6USd8M9FExFlffJHzoNW1?=
 =?us-ascii?Q?N9c1FwPe43kfIXXr0w9VegvqBuhTjUVa6QimV7u9wW1B0zhsnNHjQeYSk4m/?=
 =?us-ascii?Q?uxdT79NcJnkSHweo0PrmZwjD5Zsr+5as3J4K1X9pHViBvfQb9P5r8d9X+eax?=
 =?us-ascii?Q?cjDKHkSzJFOH2D5LtV0BXj7Bjb0K2wVFQjL99SUDbMPOzumVBLk08NL0rqiP?=
 =?us-ascii?Q?uMXXgYfq7UQbt55GHUXs2uBe5IqldahhhJPa5JUg2i7+pLJIKHMijCgeOIqt?=
 =?us-ascii?Q?CIEi+GrqOCzkDDOpHZQJZcUn1DgR7XnFJMaobzFQuAifJHUEgd6YohwX93EW?=
 =?us-ascii?Q?qa60ah6rX3zZpdE1/5sqv039xm5fOiqdUk6GxfwRlcmKXV3LaUPoa0WIbf46?=
 =?us-ascii?Q?N6U3kNwK34TtshUV6AKMXT0y3u0fB2x0zB2fNrhsVjaqY3WwbDBM8OpFtRZn?=
 =?us-ascii?Q?Yci5RYBURvuCyDf15Ou+UKEc7FMOfga1S8pbHn/WpyqASxbKkGGzhjYm6KZz?=
 =?us-ascii?Q?opTeT6Qx8MLc7rE+YCCymfZV71R78t5qkyyr/i/xGK9rFJXK7ymMeStkF6rH?=
 =?us-ascii?Q?u0106RNcYKVtUUoEsp2pPf4lMHXCCOf0nbsSugRMu9E5ZpoUPuSBS0Uhqx1B?=
 =?us-ascii?Q?zK4NTEd0ac6+pk8+wXq2mLJPKDKbafksylvyFmESsHuE5pki1Q8rCb8Ia2YD?=
 =?us-ascii?Q?cMPy5VBHX+wpvrkn/BvNraqJ?=
X-Forefront-Antispam-Report:
	CIP:13.93.42.39;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu12-emailsignatures-cloud.codetwo.com;PTR:westeu12-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(376005)(36860700004)(1800799015)(82310400017)(35042699013);DIR:OUT;SFP:1102;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 13:13:15.2287
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: faacfcce-b147-4a05-a53e-08dc83ceedad
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[13.93.42.39];Helo=[westeu12-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB3PEPF0000885C.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9091

When disconnecting the USB cable on an LS1028 device, nothing happens
in userspace, which keeps thinking everything is still up and running.
Turns out that the DWC3 controller only sends DWC3_DEVICE_EVENT_SUSPEND
in that case, and not a DWC3_DEVICE_EVENT_DISCONNECT as one would
expect. As a result, sysfs attribute "state" remains "configured"
until something resets it.

Forward the "suspended" state to sysfs, so that the "state" at least
changes into "suspended" when one removes the cable, and hence also
matches the gadget's state when really suspended.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---

 drivers/usb/dwc3/gadget.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 4df2661f6675..99e8ea9db600 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4343,6 +4343,7 @@ static void dwc3_gadget_suspend_interrupt(struct dwc3=
 *dwc,
 	if (!dwc->suspended && next =3D=3D DWC3_LINK_STATE_U3) {
 		dwc->suspended =3D true;
 		dwc3_suspend_gadget(dwc);
+		usb_gadget_set_state(dwc->gadget, USB_STATE_SUSPENDED);
 	}
=20
 	dwc->link_state =3D next;
--=20
2.34.1


Met vriendelijke groet / kind regards,=0A=
=0A=
Mike Looijmans=0A=
System Expert=0A=
=0A=
=0A=
TOPIC Embedded Products B.V.=0A=
Materiaalweg 4, 5681 RJ Best=0A=
The Netherlands=0A=
=0A=
T: +31 (0) 499 33 69 69=0A=
E: mike.looijmans@topic.nl=0A=
W: www.topic.nl=0A=
=0A=
Please consider the environment before printing this e-mail=0A=