Received-SPF: pass (google.com: domain of linux-kernel+bounces-199199-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <d9fbc964-c5fd-4b55-8f9b-db6971c3188c@web.de>
Date: Mon, 3 Jun 2024 15:15:41 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Geunsik Lim <geunsik.lim@samsung.com>, linux-mm@kvack.org
Cc: Geunsik Lim <leemgs@gmail.com>, LKML <linux-kernel@vger.kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 Axel Rasmussen <axelrasmussen@google.com>, "H. Peter Anvin" <hpa@zytor.com>,
 Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@elte.hu>,
 Peter Zijlstra <a.p.zijlstra@chello.nl>, Steven Rostedt
 <rostedt@goodmis.org>, Thomas Gleixner <tglx@linutronix.de>,
 Vlastimil Babka <vbabka@suse.cz>
References: <CAGFP0L+BaNAtCF7c7cJ1bvbjomp03Fy0=6=w6dj29Fnr0ygSCA@mail.gmail.com>
Subject: Re: [PATCH] fix: Prevent memory leak by checking for NULL buffer
 before calling css_put()
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <CAGFP0L+BaNAtCF7c7cJ1bvbjomp03Fy0=6=w6dj29Fnr0ygSCA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:T7gFyDWMF6w=;G9VKhKd2USAhNh3h8kfItzutdKu
 YqFU0t2q+nk8PLIuNGSFYapNddBrP8IhHqvj+t+RhXvxtvf/3beGqugfHswwU8E0dgi0JKXP4
 iOERIyhFgQLKXT70ZVU2w3RMMIIl7PrZhiKKTYIm+T3Bn7ABDAYoZ2B1M1BsfaFbHSjOluFYa
 AN7u2yjVYBxaG0NXUe2P/Wr3yQa01F7TjDeyIUQ9nyHHWANQ5we/KM1A4ecgNp/1XTtvMW5If
 Rv4yIzPtpIiFG1krWgc+XEsqRAlEqO2sCfEVGoVnOSdGOnUXwinJEoz8xqzXWom1Rr3lw5r5P
 niurGmaUE+Dg1LsxRvVzivVhrqeYCtHxXbNyM8zXoMSWTyd0tuTFGki6W0AA1GjN1ggVxSj3F
 sS9KMPoFiInRjn9jsd1ZxNgBtruFNp8ztNbdQutm8isPvQeeTxr9r5qc1CyPnWHaG1AVokkw+
 RX15DOkhY44h/EvXK+cSFYitGZkAPTzD/8eUWeY4BahYnjV+epkZ2Agcoh2XnUY1vdEAyn0TK
 K02LIzammtX8c6eO/Nm7jZ3Y9LwhE9GDuR6mPbI7UNDdflj7v2XhCuplWDzPaJML2m6x4LtEB
 V9vIYO2c/DIJGqQRgjysAaWPQ4Lhx/NziRwruG+yRYETfbZTbQoB118BuxxHp2Yk9gBApl4eY
 f62MvqmelMjrQfR16tQRaVqlUe/LJXR45qY+l4QDD1GAqE90aImMZSvDhkkEssu1yTfwETUg8
 uv0zZ+1w/mq+p937ikmUP7YWWi9jwzyqXe4wikqA+qmwAbILPint8kt+LfBTMmdZweZaEd+qb
 uhnUxmzQJF4xs97d5kMp4zlQ/wjpfcs/5kPCrHvX6cYZ0=

=E2=80=A6
> Previously, the code would directly call `css_put()` without checking
> the value of
> `buf`, which could lead to a memory leak if the buffer allocation failed=
.
> This commit introduces a conditional check to ensure that `css_put()`
> is only called
> if `buf` is not NULL.
=E2=80=A6

How did you come to the conclusion that such a source code adjustment
would trigger a desirable effect?
https://elixir.bootlin.com/linux/v6.10-rc2/source/mm/mmap_lock.c#L188

By the way:
Would you like to reconsider word wrapping for such change descriptions
any more?

Regards,
Markus