Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp974317lqj; Mon, 3 Jun 2024 06:46:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXVz0J/MQ9PjyEJDd98cUg4m73GWYZ4LFBHJcAd0VxHnnhwwwNyB0HqUblpmearN6Mqe4U92taSf08PM+DPMQOI7aOlqDYn/TKoKw4zFw== X-Google-Smtp-Source: AGHT+IGeSruOPK5+S1Q5upqIOz4s9UoXm7SG5jBt0OWlfPPqBFbjLDZCSPCVA1ew532aa7zJqGso X-Received: by 2002:a05:6a20:9188:b0:1af:cdc5:dfbd with SMTP id adf61e73a8af0-1b26f11733cmr9587074637.14.1717422388357; Mon, 03 Jun 2024 06:46:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717422388; cv=pass; d=google.com; s=arc-20160816; b=PoqlYJxt3rYwPR/+N4tqRdFHWF5fOzfBFfK/fcpOeDjtXWzo9W7EUOlDVrRZtjz3ym HTMt70CvV06hxXCqLTdoewjW+S1LSdzjSzzg4ghMGKh/HQsN4ds5bSD+LO7rY0GZrvUF w1xQq/LJAhBX3SMZL5ZItpUBbkC260xd7CeCNBeWFC0m0/fYxJGZ3WFfl567UUJCAwg2 g5KBY5U62eReCZs0tA2zB9+QZVCISbbUgxWqt1v/DAzb3tA+7y8H/6uFvDEl2dmfBN5J Y/V9ydkF2ejdGNqRonhn9+EuJx5OJ7yzS6aWaghv1RY8QrBM5i7p72oywq1yDMpvbkp5 /LUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=GYvPM18eihxGQ0T4HjjyiUFUCBB9YXc9f0P5irDzLGg=; fh=np4jDbLVnoqkv3+sUYlitby5vs5P86AOvvZOqGHaBE8=; b=x4iq6eRUM129zPw7rA0bjFrijwND2xeMbE6Jrl52KfrnP7nHB17ZMB1CaAs6Op3aCw p8ggr8V/hegeTtwu7t0GuOYZXM8Xxs9mfXhD/MZpgLdsdj+i2otP4b4yiHrVgOJbmTh9 DcWTSGgMZdxLzokA+z2Eb0SZdiLIviSafQ+TG87ZcOJfyijFD8EOzp9y3R0tO5mfg/xD NIDDXnpzMxUX4eImk39Ipo8rl8rHNNBST1LrSwXj774ZDfl7Q/jWQPguyrefxOnhx39B pYuWAT+1x+2VdTY0SERLmIJ8nMUs8jptGtyYvMiDXYSaSVdw1ox4Ay/KNpgia786TCdG 3iEw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GdtNR57P; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-199213-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199213-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-70242c29062si6448316b3a.242.2024.06.03.06.46.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 06:46:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199213-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GdtNR57P; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-199213-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199213-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C32BEB267BA for ; Mon, 3 Jun 2024 13:29:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B1FA12D769; Mon, 3 Jun 2024 13:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GdtNR57P" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 125CD12D750 for ; Mon, 3 Jun 2024 13:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717421381; cv=none; b=e+QfmUiKNsmxK8WywISGp1FkyfZ87iZ+CBZXDEztJE6OBXwtRtKq4MnhG8gog6DrfNq+LUuv/u+HE4PlJjgVUUccMNkrPihQ6QwYUeQ5IEqbuoPkP92Gz48ZG6w6+ck8VsUsEPVdvjWC1z2gYIZf341UuAb3NN/ejo9wVjr593c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717421381; c=relaxed/simple; bh=uFRzflwr709sZknexkSG/BMqBZ1G81X1nY1ybM2bzCI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZzGl5akbyRoc352fFLNChTV5QHIYUcCeM6Zhc2tnQWWxZItXfJ5JfQLtdiBxAqnv4WumqzhsRlNWHGT72edT+bYrgNdz4Szr52ttEwoeqIZVHg5GNGnqrz83imjOiErm+iDmejzlg4UmKXj8fdprri3YInUJOrMB2pxcXTnV9Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GdtNR57P; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717421380; x=1748957380; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=uFRzflwr709sZknexkSG/BMqBZ1G81X1nY1ybM2bzCI=; b=GdtNR57PQX4j1Rebhq2GLiUDFZE4FsHUKp90lMnyUN9Nd4qiTsFJs4cS MBCHLmLpVO7UbwFTWnT+eSjR8vSccEO2F34OYOPhUGuzZTpugHdlfgHQN joOOFE5+FCkaTwR5MNI0DCflGzQ/s47DfWe+P70/YB9naAnYaibmBXMu9 3ZdgqTLSBSTOEBA1O+fJestso7H2dKQfz0vEDoCCuZ8DWKGxZjH9OIUD+ lFzFCgqQ+DM9NmkqkL5TN7gx/61oBNFH4PyhhYYBlqTFCiXM4w2bCWwpd rMcqxAgKGNJ71pqvNNLadLlqhh8ahC+iLjjlesZettuEpFArq7U/ngw3+ Q==; X-CSE-ConnectionGUID: dJ1yShUlQNSmTWszeUbyAg== X-CSE-MsgGUID: ncg1HwTDTU6PB1lp+ydIJQ== X-IronPort-AV: E=McAfee;i="6600,9927,11092"; a="17738497" X-IronPort-AV: E=Sophos;i="6.08,211,1712646000"; d="scan'208";a="17738497" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 06:29:40 -0700 X-CSE-ConnectionGUID: ib7RqXtrS4GPljRjRjHOGQ== X-CSE-MsgGUID: TNqq2zNMShGPIh9+lpxnhg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,211,1712646000"; d="scan'208";a="41298215" Received: from twinkler-lnx.jer.intel.com ([10.12.231.216]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 06:29:37 -0700 From: Tomas Winkler To: Greg Kroah-Hartman Cc: Alexander Usyskin , Vitaly Lubart , linux-kernel@vger.kernel.org, Tomas Winkler Subject: [char-misc-next] mei: me: release irq in mei_me_pci_resume error path Date: Mon, 3 Jun 2024 16:29:28 +0300 Message-ID: <20240603132928.977787-1-tomas.winkler@intel.com> X-Mailer: git-send-email 2.45.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mei_me_pci_resume doesn't release irq on the error path, in case mei_start() fails. Signed-off-by: Tomas Winkler --- drivers/misc/mei/pci-me.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c index 7f59dd38c32f52dccf632fb4..6589635f8ba32b35fd28876d 100644 --- a/drivers/misc/mei/pci-me.c +++ b/drivers/misc/mei/pci-me.c @@ -385,8 +385,10 @@ static int mei_me_pci_resume(struct device *device) } err = mei_restart(dev); - if (err) + if (err) { + free_irq(pdev->irq, dev); return err; + } /* Start timer if stopped in suspend */ schedule_delayed_work(&dev->timer_work, HZ); -- 2.45.0