Received-SPF: pass (google.com: domain of linux-kernel+bounces-199255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f3ae00c4-1db5-4aeb-ac85-5dfa1d69354b@oracle.com>
Date: Mon, 3 Jun 2024 14:54:00 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] null_blk: fix validation of block size
To: Damien Le Moal <dlemoal@kernel.org>, Andreas Hindborg <nmi@metaspace.dk>,
        Jens Axboe <axboe@kernel.dk>
Cc: Andreas Hindborg <a.hindborg@samsung.com>,
        Keith Busch
 <kbusch@kernel.org>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240601202351.691952-1-nmi@metaspace.dk>
 <d6999fef-aadf-494e-ad58-f27dfd975535@oracle.com>
 <9d68c7c1-b1e6-4f42-8d4b-8c986ab688b5@kernel.org>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <9d68c7c1-b1e6-4f42-8d4b-8c986ab688b5@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?TWJ4dHBlSXdjV0JYRDdoVW8xS1RNT1JKZUxRYk44QmZLMkpQK3piaUlzSXh6?=
 =?utf-8?B?RHpqNXprOXNvOHRkVXQ3cDh3MU00eFVxTXBnZkVaSzJDOXBmaklKVTdiKzhK?=
 =?utf-8?B?VWI4Nk5PRzhxK2YzNTg5ejBCLzVTWVBydFdhR1R4YXpzemtoR21HeG53Qm03?=
 =?utf-8?B?cjNOV01sOE5GeHZiZGRydCtXVUgyRlg5VFZQVHZKTFdPTlo4a3lCUG1kVHQy?=
 =?utf-8?B?cFlxRGc1UzM4RytMQzFDWnY1MHh4d2lSRVJrN0tiblJ0cXMxQjBMYjdJOUFV?=
 =?utf-8?B?M201dGlCenhBMEZLdHU3dzgrVkREK1lZN3N4MGFjenFrOFNnS0NCNC9INjV3?=
 =?utf-8?B?a0lGV0lNZWwyYUtJVTFjbTJidVlLVDk3QXRaVmtpVkNxWm53Tzd5K0RjS2I5?=
 =?utf-8?B?Zm9ab3dFbnhpRUtqUTlNRVY4VUQ2Y0ozYUdZUDQ1cVlPQ2luRkpSeFRiSWZk?=
 =?utf-8?B?eTcxSVFRK21GNS9uYitpbWR5VTJMb2FKZUJ6VFVUR0JQSjdqdTk4SVVaRXVv?=
 =?utf-8?B?RzFIL2VheUlMWUVQa1ZKRkdnOFgvWVZ6UWhaRWNOcE1aN1laS1FJU285TmJE?=
 =?utf-8?B?Q0U3aGlpKzVGdUhmUFBveWMzQi9FdnhMR2hzU3A4VytEL295UU0vWnZWT2tM?=
 =?utf-8?B?RTFhQ1A2MmtPLzNYWWJLVHQzRUpMSHB3cHNZaWFWcERXT1pJQjE1NHFVMWFs?=
 =?utf-8?B?MU5nRE14SzVFdzhpcURGVnE2TFk0bi82VHpRNmtMRWFDUkc5UmloUEdzVVlZ?=
 =?utf-8?B?bUdwWE5vd2RKbUVTTEtDN2dQbFBLd3BuUi9sRy9Bb3lUNVV0cldDM1pzRFZB?=
 =?utf-8?B?SUVDRllnQnBNUHExSVFvMEhiYnhjNXdQTzlNMXBmYnA4VFBXTys0VE9aNjc5?=
 =?utf-8?B?bkI0ZW9mZkZZaEpRWlBETEJNc2ZtaTk5NU9NdW9RQlFyYWNiZDlyV0pGMzdF?=
 =?utf-8?B?ZWJrUXpSRnJGczVnaXAvcTQvOWNHOEUrMlR0SXlmMWN1MXFDcnNpVFFubFpH?=
 =?utf-8?B?dTRCME5JWGJ0djdVRzJBQ3NXVTFPT1VHWDBYL1JrbG96ODcvT2lrNkN6aG52?=
 =?utf-8?B?VldHNjBRY2ZKSmV6Kzh4MWdBdldvaUwvOWZhSmFOd1E4cUY2bGRjT1dUSGtz?=
 =?utf-8?B?S0dsSkpTL1BTa0tZeHRhSzl5M0hVY1JIV241a3NxNVY1SUt1Z0M2bHM0Qmc3?=
 =?utf-8?B?Y0RQNFVMaGxoeGt6eHU5MGxWVUdEb0JiUFVBSEtBeGc3cm5FZVFjSHhxYTUy?=
 =?utf-8?B?c2oyS3Y4SStnSzMzV0VDdzZobUg0ZW1KUXRUSWd0MDh6M3QybmFQZi9Udm9N?=
 =?utf-8?B?SmdlWkFzQmI1TGFvSzgwa3EwbHpXMHZiOGdJTkxvTkJ5OUxmMVQvbUpuaFJQ?=
 =?utf-8?B?NzhEUUlPdGl1RW1LY0dlZzFBUHdpYVlVdEtHNldEZEdtc2tMdUlLTGFCMU16?=
 =?utf-8?B?aFNHeUp3OGw5anZ6dERFVnZPYURqKzlGWmV3OHlWRHNudThjTGl6YXBoVG1n?=
 =?utf-8?B?ZmhPK21tRmVPcTVhRWxCV2kyZzhtZjdxc1pXL3RxOXpoNDJBWHpFaTRGYTRq?=
 =?utf-8?B?bHZDRWQwdDZJSy9hRUlJZE9Eajl0encvYmFhNloyRktkUCtqaVhZZXpnaXI5?=
 =?utf-8?B?Z0N0YTNHVERQZGdSanVndHNSbGhOc1NDaHZhZEJSam5JTnYwS2ltS1BxVXRS?=
 =?utf-8?B?UERlQ2VYeG5XUkNYM1ZBbVQ5NWpwN2hWOFEyRXJEejVjZWhHME0xUlVqR1N0?=
 =?utf-8?B?REo1dVFlTVpiUmVWWmN1Y2h1Q29RUFhQTVlma0RWOU9VVUpQZ0Z4T0dabEFC?=
 =?utf-8?B?QkFLRFZkbThYZkd2bEMzS2FUakR1c1p0eWdaMnJmNEtEUmJtSnBXSXhMSU1E?=
 =?utf-8?B?TEVyMml2dWFSK043dXZSWkJHdDBvUm5Xd2E4cDNVT1NYaXN0bHZwZml2SlRl?=
 =?utf-8?B?b0lhV2tFNmNiSFRheUtVRko0emVEUGNIdGNaeWFzZ1A4NWtWK0FCaldrSTFJ?=
 =?utf-8?B?ZmE0NE1sQ0JRa3NkRTJJR280cDQrM1V0Vm4yK0xLazhvWE12eTl4NjhKUnNB?=
 =?utf-8?B?M1gza1ltNWxTMm1nNnRPWUFWdnpLcGYxTHJTaXpCZzdBRFMxOUVSb1JlNmx2?=
 =?utf-8?Q?96o6jVB8ZC3JROFDjgsbuIn55?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	nKzYRH3G1EstP0hxSWGi6TJiQCWNob2LTXmb2ubkSJgw4bjVzKoB4JLuurS14RG1H/Uzz/h2QzQYyIau54HDnG1PTaqaFUfqcDujEz21k9Gm6lvP0hBNV10d0tNa0GGkEggLAdZQlee1bRxZA+ljUlavjV97E+qE5LWqZoE3llb/7176PMYZIga6di/P/KlOZ+eL3F4kySgFatImVaRXhDjUCuQLoW/qhnMsNR33mvAaA21OX8j7bQlnUJu8usnMEFERMn3AE2thCMbjolUYhEb/RLlDnyUiPVLBzToqGS93neiJKo/kK6PyEroK6+oMrwy8qJY4YsglomlPCToftrQNjCR5JYbI+JhOzWaAzLkpfq4lP7Ab1sk1hnmDGgnmWx4kdr1WeE4tjgH7Z6q5Fjpd50AI7e/XlzRjr7EOF/ToBC3y3ya+WqQgRxbPS5Ef807piGWBfFRcvYJYn4Apu2K7A9bXbngI1wveMzU/CraS8dHeuYUPFdgAodusGTgaxNK1NayucW8HJLm66DbqzDJityT60yFBkw+gp0jhLH/8938k/VqE82NDs7j8lqrl5qylA7e15A8HEGp5uc9L16LgFQ/6iuCgEIO65IcvaWI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67d0fcba-5def-4a89-5444-08dc83d4a1ba
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 13:54:05.1596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ACE/vLmm/cgWrTvxbaUmXm/tGc12L2qoDcQbQKqQDwrAs4NyMvLZVPXNfgAYsWPJ3IixbyurtlrSZ8nFs7AYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7259
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-06-03_09,2024-05-30_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 adultscore=0 suspectscore=0 malwarescore=0 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406030116
X-Proofpoint-GUID: U0UBTtCrwhhvV3QljGSmKdBgHTBbcCts
X-Proofpoint-ORIG-GUID: U0UBTtCrwhhvV3QljGSmKdBgHTBbcCts

On 03/06/2024 00:59, Damien Le Moal wrote:
> On 6/2/24 19:57, John Garry wrote:
>> On 01/06/2024 21:23, Andreas Hindborg wrote:
>>> From: Andreas Hindborg<a.hindborg@samsung.com>
>>>
>>> Block size should be between 512
>>
>>> and 4096
>> Or PAGE_SIZE?
> PAGE_SIZE can be larger than 4096. But most drives are 512 or 4096 LBA-sized.

Sure, but maybe someone wants larger than 4096, like the LBS support.

Having said that, is there LBS support for nullb? I don't think so. I 
assume that PAGE_SIZE or 4096 limit would need to go for that.

Cheers,
John