Received-SPF: pass (google.com: domain of linux-kernel+bounces-199262-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1ef36309-8d7f-447b-a54a-3cdafeccca64@amd.com>
Date: Mon, 3 Jun 2024 09:01:49 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 1/3] efi/x86: Fix EFI memory map corruption with kexec
Content-Language: en-US
To: Mike Rapoport <rppt@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>, tglx@linutronix.de, mingo@redhat.com,
 dave.hansen@linux.intel.com, x86@kernel.org, rafael@kernel.org,
 hpa@zytor.com, peterz@infradead.org, adrian.hunter@intel.com,
 sathyanarayanan.kuppuswamy@linux.intel.com, jun.nakajima@intel.com,
 rick.p.edgecombe@intel.com, thomas.lendacky@amd.com, michael.roth@amd.com,
 seanjc@google.com, kai.huang@intel.com, bhe@redhat.com,
 kirill.shutemov@linux.intel.com, bdas@redhat.com, vkuznets@redhat.com,
 dionnaglaze@google.com, anisinha@redhat.com, jroedel@suse.de,
 ardb@kernel.org, kexec@lists.infradead.org, linux-coco@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240528095522.509667-1-kirill.shutemov@linux.intel.com>
 <cover.1717111180.git.ashish.kalra@amd.com>
 <f4be03b8488665f56a1e5c6e6459f447352dfcf5.1717111180.git.ashish.kalra@amd.com>
 <20240603085654.GBZl2FVjPd-gagt-UA@fat_crate.local>
 <8e3dfc15-f609-4839-85c7-1cc8cefd7acc@amd.com> <Zl3HfiQ6oHdTdOdA@kernel.org>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <Zl3HfiQ6oHdTdOdA@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dGQ0TEp5R0QxTE1qK1BMRVdDclJJSmdDQko5c081Y1dnMUo4RU1MNzErMU5k?=
 =?utf-8?B?Uk5wQnZzRTA5Wm5PZ1hXaVI1bDIzVm1CV3YrMVQ2eXdBUGs1ZkovZWxJREFB?=
 =?utf-8?B?cmF6QVNsUFhEb1p3bVB6U2lRdDZuRDYyS1dWVlYrZDU5ZHVYZmhYcUpPODVZ?=
 =?utf-8?B?ZWt0QklqL1IwZUwzZFAvSVBvMXdyQjYvRktCbjd2U0toUUE4dmNMSmNsZWlG?=
 =?utf-8?B?NVY1NS95Y1VLbXgwU1p3UXJCNUFYbWRCTEhYaVV0NEZESFkwZEE4RlBZaExQ?=
 =?utf-8?B?Z2RzOHFmcG56dEt3bGtZeXFrZEdPdzV5bjRZMS9LNTZFVytUK1BqMUhPQ1Nu?=
 =?utf-8?B?cXFwejNEa1Y4RUV6cjJQNzJFQTFJVFMxbDFEQXlMZ0c4UDRjMUFaM1VXNGZy?=
 =?utf-8?B?RUwrRUp0RENnRUlSWGtKK0l6dWk1bkNBSGdtOG5MTVF6RGFHS25kMjJ2NDlR?=
 =?utf-8?B?dDNIZlNqTWh5SjZNbFpYVURqQXJSTjMwOU9RV2FpN3dPa01JcVlOdHVvcWRu?=
 =?utf-8?B?SHdLeVgxYmpiWVlLc2VQTytVSk45MzZCR2ROaXlUUE1yK0hKUC9OWVBHRk9t?=
 =?utf-8?B?Y1EzK3RxNk1zZFBhZzY3cEQ5b0ZuZ1VGbW9aVm1nRU8rOEMybE9OKytyMGFk?=
 =?utf-8?B?NlNqWVU5SzJnTnhGUEY0blB2V2p3cDFnVTJBSUdYQjRSMm4vWmozZzZBRmNO?=
 =?utf-8?B?SFAvOXY4bGh4UzdkQVlwVUNHajRuelRnRngxQVZoMEdjbzJyV3hkOGEwNVU1?=
 =?utf-8?B?Zm5QMlFQZUlTY1hZNS9OeUFURE9QbHl3WUFhS2NYc3ptcEczaWt6VzJHY3Jm?=
 =?utf-8?B?N0REeE9DR2lTc3RQSDVMLzJVZ3Bab05ickNGdHpiZ3BOOVRJbGJNUnAvVEcv?=
 =?utf-8?B?TFd2VFRMWE83SzltM2xKOW5DZGJqNzRHR085SnBaUTlqV2NVektQVFNSZFJU?=
 =?utf-8?B?MkVUdkJvUnNHNklUMU1HQlhjUm5kck53YzZqaWEzWHY0UDlHUC93Qnc0VVpP?=
 =?utf-8?B?eEN0TU11Rnk2TXhUaUxvVWpZb0NIUDNjWGF5VE5VcnRNVXh1d252MHJ2RHNo?=
 =?utf-8?B?OFBkS3VTNkRtZXVYUnhkNExJQ3IvR2dJWlZublhWOFVXOUlud0lUVmNOS0Qz?=
 =?utf-8?B?cDFmVHFWVHdjZnBPRFdnTlh6SXpOY1RnYlBrczJBQzVzU0twSHQ4SE9EbVV3?=
 =?utf-8?B?WWo4cjI5ZTlXT3RKangrRnFWcEdCOW9sNFVyMTlvakJIVnFISzlXWXE5Q3NT?=
 =?utf-8?B?blhBOVRxNSs0eWhRTm1oNFN3NjFHU2tWeVZRK1N4QTdndHBURDBGWnFFK0xQ?=
 =?utf-8?B?Nlk0d2JlU1J6QnZzVllYdzdieU4vQVhNMzFGaDJDMW9IK0hYQStMZVg5dUk3?=
 =?utf-8?B?Q3FzbUpwZzhIdUhIcWVFd0FPNTZtQmVlWFgyellIaDlOQngxQmxHVVo5QjlE?=
 =?utf-8?B?UWxZc3VhN2g4SUI3NHIwN1JSSjA4NFFrSEhZaitTMGJsQzJIQm1NUVVMSk9h?=
 =?utf-8?B?eUZmaUtYOUNMZkdhaTU5NXlDRzZlenlwaTFhVVZWelo4MkhiUzJBL2owS0w5?=
 =?utf-8?B?NU8rTno4Ymx6Y2RjN0dOVGtJQUFyQ3ZDdTJnRG9uMnF1T0FkVXFxcFFvRmN2?=
 =?utf-8?B?VmF6TG5ZYWdwQVZMcGUxa21ub0V6cm1uL1JNbE01ZEp0eDk5N3ZCMmpsZTVY?=
 =?utf-8?B?cFhFc2JIKzBqL2lic0dCd3kzT3Zmd1E2b2tKaGQ4REFjeWo1RWVpbXRRZXhx?=
 =?utf-8?B?UzBqNHo3N2ZaY1RsY2RyamZIUnovYkdja2lrOTcrKzFmL1hycUliN3dhby9G?=
 =?utf-8?B?YWY1RmV0TkVPZnJET01HeGIrQ3lGZkZybVBYbXpMblNPZ1hhWGE4RTMyYWV3?=
 =?utf-8?B?QUlCZjdXeEFHNGdRS3hRQktPU1JORDBwQ3pzZE9YZzRqUzN0T3UyNm9lVWJE?=
 =?utf-8?B?ZjVFd2ZKaUtPbHhDa3U3T21KN0cwVFNYTnJidmZ4RXVlWk90OUZNVXI5UERo?=
 =?utf-8?B?a1NpQ29BTVZiajhYUytPTVJsdW1RR0tlT0w0REpVUVJldVlaWlRGMUw0NUhw?=
 =?utf-8?B?QVl2LytYNUt5UVBEdWd1bEI2c01zd3FsbFUwWGo1Q1FJeVoxVUQ1MVFYbEJy?=
 =?utf-8?Q?PL+c+VUTk7u+1BzJMJhduhGZo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 567cadb5-c58c-464b-ae47-08dc83d5b7de
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 14:01:51.6952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x1hc/1bEcQU+5hwBfchNM67lQCK2kuQXsZFq+zBYiKRtpwS6EpSo89a31yMXDKSjUkaTYvGg481pBBAk4xCXhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5927

On 6/3/2024 8:39 AM, Mike Rapoport wrote:

> On Mon, Jun 03, 2024 at 08:06:56AM -0500, Kalra, Ashish wrote:
>> On 6/3/2024 3:56 AM, Borislav Petkov wrote
>>
>>>> EFI memory map and due to early allocation it uses memblock allocation.
>>>>
>>>> Later during boot, efi_enter_virtual_mode() calls kexec_enter_virtual_mode()
>>>> in case of a kexec-ed kernel boot.
>>>>
>>>> This function kexec_enter_virtual_mode() installs the new EFI memory map by
>>>> calling efi_memmap_init_late() which remaps the efi_memmap physically allocated
>>>> in efi_arch_mem_reserve(), but this remapping is still using memblock allocation.
>>>>
>>>> Subsequently, when memblock is freed later in boot flow, this remapped
>>>> efi_memmap will have random corruption (similar to a use-after-free scenario).
>>>>
>>>> The corrupted EFI memory map is then passed to the next kexec-ed kernel
>>>> which causes a panic when trying to use the corrupted EFI memory map.
>>> This sounds fishy: memblock allocated memory is not freed later in the
>>> boot - it remains reserved. Only free memory is freed from memblock to
>>> the buddy allocator.
>>>
>>> Or is the problem that memblock-allocated memory cannot be memremapped
>>> because *raisins*?
>> This is what seems to be happening:
>>
>> efi_arch_mem_reserve() calls efi_memmap_alloc() to allocate memory for
>> EFI memory map and due to early allocation it uses memblock allocation.
>>
>> And later efi_enter_virtual_mode() calls kexec_enter_virtual_mode()
>> in case of a kexec-ed kernel boot.
>>
>> This function kexec_enter_virtual_mode() installs the new EFI memory map by
>> calling efi_memmap_init_late() which does memremap() on memblock-allocated memory.
> Does the issue happen only with SNP?

This is observed under SNP as efi_arch_mem_reserve() is only being 
called with SNP enabled and then efi_arch_mem_reserve() allocates EFI 
memory map using memblock.

If we skip efi_arch_mem_reserve() (which should probably be anyway 
skipped for kexec case), then for kexec boot, EFI memmap is memremapped 
in the same virtual address as the first kernel and not the allocated 
memblock address.

Thanks, Ashish

>
> I didn't really dig, but my theory would be that it has something to do
> with arch_memremap_can_ram_remap() in arch/x86/mm/ioremap.c
>   
>> Thanks, Ashish