Received-SPF: pass (google.com: domain of linux-kernel+bounces-199277-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 3 Jun 2024 22:19:24 +0800
From: Oliver Sang <oliver.sang@intel.com>
To: Ian Rogers <irogers@google.com>
CC: <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
	<linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Weilin
 Wang" <weilin.wang@intel.com>, Peter Zijlstra <peterz@infradead.org>, "Ingo
 Molnar" <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa
	<jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, Kan Liang
	<kan.liang@linux.intel.com>, Jing Zhang <renyu.zj@linux.alibaba.com>, "John
 Garry" <john.g.garry@oracle.com>, Sandipan Das <sandipan.das@amd.com>,
	<oliver.sang@intel.com>
Subject: Re: [PATCH v2 2/2] perf jevents: Autogenerate empty-pmu-events.c
Message-ID: <Zl3Q7AtOWY8ZCcg8@xsang-OptiPlex-9020>
References: <20240525013021.436430-2-irogers@google.com>
 <202405311548.1e881dea-oliver.sang@intel.com>
 <CAP-5=fX7ZyT82=W8uSZbT7c76E5+1JaoR5-y_gcj7A_=Js1YfA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAP-5=fX7ZyT82=W8uSZbT7c76E5+1JaoR5-y_gcj7A_=Js1YfA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEhlWEIwOThlRmZodlVKK1Z5dHhGNHBjT203WkJIOWdGK0NLbldBa0pSclBs?=
 =?utf-8?B?WktHWkwrd0VwMTE0bXFrZVVuaUtNY3hEYzF4MjNQMTlOQ1owUVV2TkNTZmxH?=
 =?utf-8?B?RU1LR2VXZWZoSEJVRWZtd1c4azhDa0E0MURHQXk0WDFQYmU4K2VkQkRkM1FI?=
 =?utf-8?B?cFFmV2NGRVJ0aGlyYVh1M1JTMjkrK1lpS1pOWUxUZUk1OEpkbmxEYXhhVWRt?=
 =?utf-8?B?cmp0S1JnaVlNVmc3ZHQvcjNwb1FDSmIwcFlNYUxHUzJWQSsyQjUzbTNsS0Ry?=
 =?utf-8?B?OVJ5enJiMEJVVWhEMndYY2E0ZzJteHc5emQzNjdzUk1tUzRKaG12M1pWVVVZ?=
 =?utf-8?B?NGU4eXhMT25iRWJqZnR1NjRNdGVRNE1hR2pBTkJzQXRwUkJHYnQxVUE2bW5z?=
 =?utf-8?B?UkRFakdteVlxUWdERVdscit5UCtBVU9nZFQ3RmNOa2Z0Qks1eGRVMDV0NUZQ?=
 =?utf-8?B?RHAvOHpSSFFheVlSYW9UVHBOaUNwa050SURLZEE1TFRmeHB2aklRUTl5NFlL?=
 =?utf-8?B?VGJudlozZ0I4V0pGZERkeVFlWTdaTmk3dk9BYXMrODN6VzFCZ3hqeldlRkY0?=
 =?utf-8?B?S29jei8xV1ZTcXIyZ0xPZG1JTVJZUVBGWDRyRFNmQUJSRGhyRnhRaXlVQU9w?=
 =?utf-8?B?ZnUrS2NWNzJXQ0VwT2pCamdZdmdoNEd2VTZuZEp4WER1bWkxN290K2VQaGQy?=
 =?utf-8?B?VHU5R2N4YXNzbFhoWER2Yk1FazN5cW5USzJPeEMvVmxXNHNPbWhDTEEzNnhu?=
 =?utf-8?B?UFpNaTRZVk1uRnJYKytwanUzSEQrN2s2TXFyUWYvZEszOCtQUC94Tit0OTdU?=
 =?utf-8?B?M1JST0xaNVg0NmZYLzhYNVIrbUhkblArYURjU0RZQzZqY1djTUthOEVuWG5k?=
 =?utf-8?B?dzd4R2Z4N2hTbWZ1eCttSnI3MHpMN01vTGR0d2hhZ3hUYnFXZGwvM2M1NXdJ?=
 =?utf-8?B?aFowVWs2cGZNSWZlbE5UZ2cwUGVVSSt6MlNKZldycDRQeWwvbUhab1ErcWll?=
 =?utf-8?B?cEs0MlYrTTgzWkQ5akc0QzdDNGswRXVrZUhEQVRvWDFDQWFrWTRLY09DUnNp?=
 =?utf-8?B?QmxKdnNsVE1aaUlCRW80LzdPNHZmNFplOVNHVHE0bDBtZTVtRUhOS1hKMXN4?=
 =?utf-8?B?WCtod1czWWJFNzZjYklMMDY5MFNaRkYvRFd2SHN3d05VUno4dFM1dUUyYzc1?=
 =?utf-8?B?bHYrSCtRakplcElLWVJjUEE4d2pabzFaVDVqd1N2YjNxTWpzdS8vVWJiZnkx?=
 =?utf-8?B?a2NIRm1Jbi9Sb1ZLcHNzQWxTZmg5eVAyYTVpUVNWbUwxMUFjQ1dPZ29NYUoy?=
 =?utf-8?B?ZldHTjdwUnJ6clNadUFMMzg2a3VtbFFUTGRzeTQ4Q1NvaVVjSWkvc3BtNnRD?=
 =?utf-8?B?WlA2T0ZJdDBvbVFvd0xhbkVXL25GWktjcElHSmVLTVdaaFoxdnBGNUdaTElZ?=
 =?utf-8?B?dHZNL2NQQTh3aWo3S2JwWW51ZXNYRzFNZkgxbGZtbjNYeVEzQkpoa1p2d2Jv?=
 =?utf-8?B?K00rV012ajlwbVNmczFMYXMyankwY08zTWg0WHpCMDhUb2szQWhZS3NyTVN1?=
 =?utf-8?B?RUJsVE1FaGVycFdkcFNrNS9GNHJKc0crYmNIbk1xb2JyZUdadDJjc2NteCsr?=
 =?utf-8?B?ZWw0K2U0OXd3VDlEOG0xbWMzWVNlUWlYVEJ5RHBNTXQ3SGVsQ0ZCQXFwcjRm?=
 =?utf-8?B?K1ZwWW5DbUlBa2FmSjRBbmVmRDVwMHBtdGk2SjkwcmFkd2FIYjV4cjJXWVNs?=
 =?utf-8?B?YVNiVjJZY2t3QUNUR1FlWkxRTThxZkU1cHB2U0EwdU1XcDhaalVwcjFiWWUz?=
 =?utf-8?B?T3BNTi8ra1lrb0g5MkNsMzh5R0NsRmJCVHFuTWFtRE9YRUpueExhVHRGcnU5?=
 =?utf-8?B?aTVnS3c3UWl3KzVwbTFKdGdCVWtnc0wzQ1Bid1BvQWNsOGF4M0J6V3EwOWRn?=
 =?utf-8?B?dEw4YjdqeTMrMEkzYmc4a0J3cm91a2FsOG5LZWp0WnhJWENnRGlEVXp3OUJP?=
 =?utf-8?B?V0dSN0ZFNVhzVERjUlBUM0RyaVFXaDVGbUFnektXRmJsRWR4ZHd1K29QdWp3?=
 =?utf-8?B?ZHNsNzE0c1kwNThobmpmbDUycWdSOGRiTmRvVitISURIUlFkdDB5cVhVUkFP?=
 =?utf-8?B?WXZscy9YV3VSMy9rM0JFRnVQOVRBQ2FiT05vY0J4NEY2alFkUWVudjdxblk0?=
 =?utf-8?B?TGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f9cb178b-4d20-41f8-bf6a-08dc83d83245
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 14:19:36.2494
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x57F2UGLeffCWT/STguFLpbw3iZwy3khYZWJ2z9LSPbf6Om1/cZaAMpDSKMsGOZXmgTmmT5/BjVlNOjBIEZQlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8430
X-OriginatorOrg: intel.com

hi, Ian,

On Fri, May 31, 2024 at 09:38:01AM -0700, Ian Rogers wrote:
> On Fri, May 31, 2024 at 1:16 AM kernel test robot <oliver.sang@intel.com> wrote:
> >
> >
> > hi, Ian Rogers,
> >
> > we actually want to seek your advice. in our env, there is no problem to build
> > parent.
> >
> > * 3249f8b84526d (linux-review/Ian-Rogers/perf-jevents-Autogenerate-empty-pmu-events-c/20240525-093240) perf jevents: Autogenerate empty-pmu-events.c
> > * 7d88bd0d22746 perf jevents: Use name for special find value   <--- parent
> >
> > however, failed to build perf upon 3249f8b84526d. but there is not many useful
> > information in below detail log.
> >
> > is there any dependency or env setting for us to build this commit? Thanks!
> 
> Hi Oliver,
> 
> Thanks for the report and the work testing! Seeing the output:
> 
> [..snip..]
> > --- pmu-events/empty-pmu-events.c       2024-05-30 08:20:10.000000000 +0000
> > +++ pmu-events/test-empty-pmu-events.c  2024-05-30 15:55:37.332495538 +0000
> > @@ -136,7 +136,7 @@
> >  { 2623 }, /* M3\000\0001 / M3\000\000\000\000\000\000\000\00000 */
> >  { 2078 }, /* cache_miss_cycles\000group1\000dcache_miss_cpi + icache_miss_cycles\000\000\000\000\000\000\000\00000 */
> >  { 1947 }, /* dcache_miss_cpi\000\000l1d\\-loads\\-misses / inst_retired.any\000\000\000\000\000\000\000\00000 */
> > -{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst_retiredany\000\000\000\000\000\000\000\00000 */
> > +{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst_retired.any\000\000\000\000\000\000\000\00000 */
> >
> >  };
> >
> > @@ -373,7 +373,7 @@
> [..snip..]
> 
> It appears the version of empty-pmu-events.c the patch adds and the
> version generated in your test configuration are differing because of
> whitespace. Perhaps a hex editor will show what the exact difference
> is, it must relate to locales or something. Like you mention this
> could be resolved by an env change.
> 
> > The kernel config and materials to reproduce are available at:
> > https://download.01.org/0day-ci/archive/20240531/202405311548.1e881dea-oliver.sang@intel.com
> 
> I didn't see the generated test-empty-pmu-events.c there and so
> couldn't follow up on the locale/env exploration. I wonder that a
> suitable workaround is to change from the patch:
> 
> +$(EMPTY_PMU_EVENTS_TEST_LOG): $(EMPTY_PMU_EVENTS_C) $(TEST_EMPTY_PMU_EVENTS_C)
> +       $(call rule_mkdir)
> +       $(Q)$(call echo-cmd,test)diff -u $? 2> $@ || (cat $@ && false)
> 
> to instead of invoking "diff -u" to invoke "diff -w -u", that is to
> ignore whitespace. I can send a v3 with this.

I tried below patch

commit a79a41133a41adc2d69c8f603c7d880b3796cbf7 
Author: 0day robot <lkp@intel.com>
Date:   Mon Jun 3 16:35:45 2024 +0800

    fix from Ian Rogers: invoke "diff -w -u" instead of "diff -u"

diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index c3fa43c497069..54d19b492db5c 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -39,7 +39,7 @@ $(TEST_EMPTY_PMU_EVENTS_C): $(JSON) $(JSON_TEST) $(JEVENTS_PY) $(METRIC_PY) $(ME

 $(EMPTY_PMU_EVENTS_TEST_LOG): $(EMPTY_PMU_EVENTS_C) $(TEST_EMPTY_PMU_EVENTS_C)
        $(call rule_mkdir)
-       $(Q)$(call echo-cmd,test)diff -u $? 2> $@ || (cat $@ && false)
+       $(Q)$(call echo-cmd,test)diff -w -u $? 2> $@ || (cat $@ && false)

 $(PMU_EVENTS_C): $(JSON) $(JSON_TEST) $(JEVENTS_PY) $(METRIC_PY) $(METRIC_TEST_LOG) $(EMPTY_PMU_EVENTS_TEST_LOG)
        $(call rule_mkdir)


but make still failed. I still saw below in our build log

--- pmu-events/empty-pmu-events.c       2024-06-03 08:41:16.000000000 +0000
+++ pmu-events/test-empty-pmu-events.c  2024-06-03 13:47:19.522463482 +0000
@@ -136,7 +136,7 @@
 { 2623 }, /* M3\000\0001 / M3\000\000\000\000\000\000\000\00000 */
 { 2078 }, /* cache_miss_cycles\000group1\000dcache_miss_cpi + icache_miss_cycles\000\000\000\000\000\000\000\00000 */
 { 1947 }, /* dcache_miss_cpi\000\000l1d\\-loads\\-misses / inst_retired.any\000\000\000\000\000\000\000\00000 */
-{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst_retiredany\000\000\000\000\000\000\000\00000 */
+{ 2011 }, /* icache_miss_cycles\000\000l1i\\-loads\\-misses / inst_retired.any\000\000\000\000\000\000\000\00000 */

 };


I will try to get generated test-empty-pmu-events.c tomorrow.

> 
> Thanks,
> Ian