Received-SPF: pass (google.com: domain of linux-kernel+bounces-199279-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <3990ab6d-6217-4e10-bda9-6b5c7bd668c0@amd.com>
Date: Mon, 3 Jun 2024 10:22:22 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
 avadhut.naik@amd.com, john.allen@amd.com
Subject: Re: [PATCH 3/9] x86/mce: Increment MCP count only for timer calls
To: Borislav Petkov <bp@alien8.de>
References: <20240523155641.2805411-1-yazen.ghannam@amd.com>
 <20240523155641.2805411-4-yazen.ghannam@amd.com>
 <20240524145335.GAZlCp7wAO22acrGyP@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240524145335.GAZlCp7wAO22acrGyP@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aHdCQ1ZPajB3OUhsVkFZTGFJbXFDaGtsdFpKZDhVZHU2UFhNcFZJaFgwcG1M?=
 =?utf-8?B?TUF4dkM3YU1jK3RnaDBnOVQ3c1VKcWlMMEs5ay9VUjFuZldyWWl1T2xEYkdh?=
 =?utf-8?B?Z2t6L1dpMHMrR0x2dm9LVGdYUlhEM3lMSm9GelhJMExBQWRRbXBPdDg1TWk0?=
 =?utf-8?B?cXlJclAvNkE3R3g1azdyV2s4ZDBVY1dlVVd1SVFpUEpQVmdlbXJqN25vbzk2?=
 =?utf-8?B?QWhtRkFnd1dSM3VIc2VEdU42dHpQdS92bjNJWVpvM2NBZXlGbEduY21DUU5V?=
 =?utf-8?B?dHVTZkVTQ21ONkFtcXl2dlZHR1VPdVZGWDhndG9EMjdVOVRvYU4xdVVmWlBZ?=
 =?utf-8?B?WGpxUUlHRElDMUt3M3VHRHo1MDI4UGxtYUZUTWlUSnZQQzI1UVdKZjgySXNn?=
 =?utf-8?B?UGEvQlI4NHZ4dDVrNjFKQVlWUVRjU2JnRzg2TkZhMjVhOFhSN0RoT3JtY3Qw?=
 =?utf-8?B?Y2RGd0NxWVdKYmQydnU1YUk5UmJPbmNleXZjdndBVWJIZjlMVW9vNTRtc01E?=
 =?utf-8?B?Mk9FZ3c0SGRPVzJLbFQ0ek00eDc1MFVKQ2FDQnd1YjFCalZmVyszazdZaTN1?=
 =?utf-8?B?aURiK0FHc3c1WWIxVUF2SllrUVhnNDhTQ3VBNXA1TTNEcXB3MHU1YVlmSVVu?=
 =?utf-8?B?SzltY3F4b1FJZUV2RDA1a3J3SU5VOEV5SDRlRVRpSVlnU3JCNGF6Y09oTFBC?=
 =?utf-8?B?SE5zelYxclBIOURyb3hxOWlXc2hOaVc2bVVDU1poMlVocjZEaFc2d0RkQ1li?=
 =?utf-8?B?RGVYVEJwTEtFdGVTaHpxK0tWVnRES1dBOGNtWjVQQ3NUOHZBNUlEc2NmYkJp?=
 =?utf-8?B?VnJiS2tGV0h0WnIyTE9pZVBORXBGZ3dNT0JmTEFjNU93MDhoWGNoaTRMdHB4?=
 =?utf-8?B?b3o0SW85ZjNFS0M3ZjIwNmdzNTNpdmtKUUhSWVZEb2VhQ2hvY1R4MkNmWUJh?=
 =?utf-8?B?aUJMRlhlYzRHcjhPN3J0UkdOSW93NmRoQmRMOUR2MjJKVVZpcnpTQUlBSU1C?=
 =?utf-8?B?YzRoQnpVTUhwM1B6bnpMdEg3S2xLQ2RHVmxHOE9rUUJBWWlQNkRJcEFkTmRa?=
 =?utf-8?B?ajlVWDRFc2NqaUxaTVNnM3M3UTJvUElHTWNlMmJZU3ZDczhnYi9kOXBReERk?=
 =?utf-8?B?ZUFlTnJ1M2JHUWVmSDhZUUVPakd2elFvaGZsekY2NXFSajUyb1BhemxPSEJR?=
 =?utf-8?B?K01nb3JxdTdKanR1YSt6ZW5rNmYwY1RxSXd0eVM4c3IrODRPSWk4T2w1Z3dZ?=
 =?utf-8?B?NUsyUFlPTHFJWUdpMVFlbmZrbVlTMDdJa24zblZhNFBxREdNdVVpTzF3MkFw?=
 =?utf-8?B?am0xZnl1SnNwVDQwSlQycE1kRHh3M1dEdjl1bUhMVXA0akg2VmcycGppTFBs?=
 =?utf-8?B?NlgxSmJJcGxOT3U2U2VIUUlLU2RmRnlnSnNqeDZSOTJLeTVPUGNsK2EzcFNL?=
 =?utf-8?B?Yno0SSs0THNiRWxnSGI0cC9ZenpON1h6MTFQNWJxcjdHdVF5aC9VVjJjeDlS?=
 =?utf-8?B?SkNOR2xoTzYxMjVLbml2dnhVTVdIZElhREk0bW9MbVJGSHNRNVRtWGdhcUNp?=
 =?utf-8?B?MXp1eTBXRmRSaWNScEJDL0t3R1JNeTlnUUNEbUMzK2VGTXJLZDlaQm95bTdJ?=
 =?utf-8?B?TmwwTVY2QTA0WnI2Y2RxSi9SVkJCWUJINTFLeGVPU25uTjBSZVdZbmJYQ3Ru?=
 =?utf-8?B?Z1EzWE9iY0M2b0NJYjA1MWdWMnNWdjlPY3JCcXJESms3R2ZwOENOWkw2N2Nv?=
 =?utf-8?B?azEybHBOcHZWbklwZW5mMGpkeDVJeWUrNXJPMzY2Y2FzejcrVkRIT1gyNjVt?=
 =?utf-8?B?OUpSaVlEZDFCU0h2dVZ0QVNWMVJ3ZXFYc1EyYTRTaDA1WGg1NW14Qm96bXJh?=
 =?utf-8?B?RitnRU5vN0Z6eUZQSlR0cEV1Rkg0S2RLYjArRlBsTFQxdnhBZFlxbmkraHBD?=
 =?utf-8?B?K2xhYUQ4VEtTVUhzakJDZDN2dVZNMFZzNDR3Y2JLdUpzek9iTnRQdTBNN0wy?=
 =?utf-8?B?QkZKL3l3ZlRnNE12UGUwMStCdzJ0TUorWUVwMW90Z3J0bldKRmtvWHJDRVlX?=
 =?utf-8?B?SU9TeUxoSlFiMGJ4WUZDallQU0FZYmI3ZzZYU1Q3RGtLR1ZHWTF1cjU1QjVl?=
 =?utf-8?Q?O0pEq5zWzCs7oA+V5DCrZRMCu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef79ecde-713c-4817-3eb4-08dc83d896bd
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 14:22:24.6924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QwsLgIRxd43rzI5IIycIHSumSHBAvkDDr1LZQRdp/WeNGaIUpG1xjc2HkUUS+49MmzGx0kO+8S0AK/shTcopgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6200

On 5/24/24 10:53 AM, Borislav Petkov wrote:
> On Thu, May 23, 2024 at 10:56:35AM -0500, Yazen Ghannam wrote:
>> MCP count is currently incremented for any call to machine_check_poll().
>> Therefore, the count includes calls from the timer, boot-time polling,
>> and interrupt handlers.
>>
>> Only increment the MCP count when called from the timer so as to avoid
>> double counting the interrupt handlers.
> 
> Well, but, every time the function is called, we did poll the banks.
> Sure, the count is part of /proc/interrupts but we did poll the banks in
> those other cases too. So I think showing an accurate poll number is
> actually representing the truth, no matter where it is shown...
> 

Okay, fair enough.

In this case, should we also increment the count in __mc_scan_banks()?

Thanks,
Yazen