Received-SPF: pass (google.com: domain of linux-kernel+bounces-199300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6d508036-befd-4d5c-b02e-abb228ed9144@amd.com>
Date: Mon, 3 Jun 2024 10:34:10 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
 avadhut.naik@amd.com, john.allen@amd.com
Subject: Re: [PATCH 3/3] x86/mce: Use mce_prep_record() helpers for
 apei_smca_report_x86_error()
To: Borislav Petkov <bp@alien8.de>
References: <20240521125434.1555845-1-yazen.ghannam@amd.com>
 <20240521125434.1555845-4-yazen.ghannam@amd.com>
 <20240529172809.GJZldlqSr5km0frQ_o@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240529172809.GJZldlqSr5km0frQ_o@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QTRQbG1GUVgrZkFQRjBJeWNmSnRKazZZQUhUVmNqWFBQcXF0NmhSMXZZNkxw?=
 =?utf-8?B?L1c5Y3pkcEhuRFJnSll3UFlDdzdDMElDaEVMazl6end5SFdrck1seFRXL1Rk?=
 =?utf-8?B?UDhpenh0bThLZXNBNElTaGNDY3l6emc3TzZTekRRdkR2VTcycnBSV3RCcW5V?=
 =?utf-8?B?VmRaNTM0ekF0WW9Pd3Y1YzhXRkxLaFdhWWtQYTNkdXRmYlovbWpMWmpwY2cv?=
 =?utf-8?B?U2JRUlhGcGJsaVNIbmVzTlpkZjRCNTZCbHY0TS9sVXp2a08yTDVYdzl3Vk95?=
 =?utf-8?B?dDYya1NmM0hLSFFhUUxNbFR2VnJFTXNVaWh4T3BZOFVFcU5NdWFoSitvMlN4?=
 =?utf-8?B?R21WbHZqOXE1b09ZL0ZiNTdxclpoSld6VHR1M2lzeTNBbDVOM2hsRmRDeXNW?=
 =?utf-8?B?WitGUkk3Vmo5QXp3dFJadXpFZmE5NElHVWJWd0RISGEybi82VjJJVjdzcSti?=
 =?utf-8?B?bGczZU1oTzl5azlLSExvV1l4c0xldlNYcVNlc0RNUHg1ZXJ5Y1hqaE56djI4?=
 =?utf-8?B?bVJjajFQbnZWcG5BT0lRdGdYUUN5c05hNU9Sbm0rQ29Cb05CZVluVlg2TFl5?=
 =?utf-8?B?LzY0bXR2ZW9UZ2tXVWJkanh6YThlZFRBbG53K1NRUjllcE1nbCsxMXFRV2dl?=
 =?utf-8?B?dVROQkd3R2ovK29qUjhDL3FBUExyZ1g4NnlHSkZUalhBbXpLanV0U2oyby9i?=
 =?utf-8?B?Y25NQ25yRXcwdHRoUnlFZkxLaDlDQjN4Z2ppKzlCNFR3ZThTR25TNGNBbXJa?=
 =?utf-8?B?V01GRW5SNnM2ZFFXNTZHOE1BSm92Q3I0WTNVcFphMGo2VXVXTnhPTUFiRkZ2?=
 =?utf-8?B?d0ZjYzRBVWN0cy9BWWt3b3dPTzg5enUrVlNoMFlRRlVXSnNqNUtJc3RFalht?=
 =?utf-8?B?S1U0dzZrMjJNdk5vM0drNGZXbit1Q0tDdzF2alI1anJOejhIL0Z6c2NxQmFV?=
 =?utf-8?B?Z3BSTTRkQmVTenhLa051UUsxVFdlRzc1QzJuQUpOUVdsNUF3NGNraUQrRkhL?=
 =?utf-8?B?VG9DbkIxNGVHVDJhOXA2ajkxS2k5KzIzOVV3SHprWEZlOW1NRkdqbEpWUzZ5?=
 =?utf-8?B?WXU4VzdWbjcyQ2YrRk0zaUtISGdyZlRjNXg3bmZNTlFCVFpzSFZyZWVLZlp4?=
 =?utf-8?B?WHpvNDFxZWp2bDJKMG5DdmJGVXRQTGpDYWFNME0yZXo0bFdQaUJMbzRQS3J1?=
 =?utf-8?B?N1dVUGtodHF0cGRuVlVkL1IzamtMM0dOdWhlc3Vzbzd2VDE2RzhHVTZSWlQ3?=
 =?utf-8?B?VklPd1JTaHFpSDV3OFhWVGJhejFESEZ0OXlvcmc5SnUxR00wMWFBb3kyQ2JV?=
 =?utf-8?B?Qm12UmJheHJPQnNTd29hZC9hQnZYWTJHVDc2K1hBeGlYVWpGSS9YSEM3TUMx?=
 =?utf-8?B?dkQvSlh6a2NENFdZVndWdUxmSEhvSnhoU043azdiamlnK0hyQmpWMzhjTFZX?=
 =?utf-8?B?QnAvYW1Ubm1xRlZJQ1FWT2hRbGp3VUJnYndCSE9wa0FLOWhhdmVLRHVGUFBL?=
 =?utf-8?B?VFJ2d0VwbStYU2pCeStidzFTYU1Jam5JczJkZzBPb1V1ekcwakNlZDZXNDg0?=
 =?utf-8?B?QXhldFRjdWU2QTZMVGF4QTdoZDNRU3RNdVdSWlBKZkwwUkpXRWlUenJJQ3Zj?=
 =?utf-8?B?Z055d0R5Q05xQVNZWGo1YmUwa1VLREFJV1ZFRWlDQXQreDFZbUJiY1RiSDRR?=
 =?utf-8?B?VEF6UlZTNWwxZi9yRTNUQmVWTjFsd2hpcXg4M3FzKys3aGFHMWdCaFFBbXc4?=
 =?utf-8?B?T3drRjdWbWhIUU1yNTY3clpuRnJlRVFZQVIxeDJDSTFWQ28vME1td0xYSGht?=
 =?utf-8?B?VFVEWVZhSG0xYzNKYkFRUG9Tei9TWGR2RXZjTFh6dEpEZFA4N2I4RUZiY0c4?=
 =?utf-8?B?TXUvSk5JblVScERBWmhoeTBHc0VBQ21qVUMrNDlQVVBlZzIwQU9WWGdCMVdR?=
 =?utf-8?B?dmhkWEYzNlBNYklsdmI4VmhEOENWL3A5cVF2bnFrbVk5b292NFNvL2poSE9j?=
 =?utf-8?B?QmFMRWNkWGRTdUV3WWY0SnEzUlFkQlU3emRKUEhqVU43enpFK3Q5d1U1d2li?=
 =?utf-8?B?NmxXeEhtU25JR0U2R1V1V0xXWi8rcnR3WDBKS2RUVEFCRUtQNHp5dHRWWUFn?=
 =?utf-8?Q?sC6ivpX68/GsjNvEfsWtXxeo+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9817726-7d34-4fed-c5ef-08dc83da3bdc
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 14:34:11.1696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uPeoVCzGoNcM85LgcjD3XVHO9O5g5x2FDZLx9FdlEuS+uYIaq/WVTwDz4keauhQbzpewUodoKd2wtAFjEusaTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8463

On 5/29/24 1:28 PM, Borislav Petkov wrote:
> On Tue, May 21, 2024 at 07:54:34AM -0500, Yazen Ghannam wrote:
>> Current AMD systems can report MCA errors using the ACPI Boot Error
>> Record Table (BERT). The BERT entries for MCA errors will be an x86
>> Common Platform Error Record (CPER) with an MSR register context that
>> matches the MCAX/SMCA register space.
>>
>> However, the BERT will not necessarily be processed on the CPU that
>> reported the MCA errors. Therefore, the correct CPU number needs to be
>> determined and the information saved in struct mce.
>>
>> The CPU number is determined by searching all possible CPUs for a Local
>> APIC ID matching the value in the x86 CPER.
> 
> You're explaining the code again. :)
> 

One day I'll break this habit. Thanks again for the reminder. :)

>>  	for_each_possible_cpu(cpu) {
>> -		if (cpu_data(cpu).topo.initial_apicid == lapic_id) {
>> -			m.extcpu = cpu;
>> -			m.socketid = cpu_data(m.extcpu).topo.pkg_id;
>> +		if (cpu_data(cpu).topo.initial_apicid == lapic_id)
>>  			break;
>> -		}
>>  	}
>>  
>> -	m.apicid = lapic_id;
>> +	if (!cpu_possible(cpu))
>> +		return -EINVAL;
> 
> What's that test for? You just iterated over the possible CPUs using
> "cpu" as the iterator there...
> 

This is to catch the case where there was no break from the loop.

If there is no match during the iterator, then "cpu" will be equal to
nr_cpu_ids.

I wanted to use a helper that goes with with the iterator rather than
checking against nr_cpu_ids directly.

Thanks,
Yazen