Received-SPF: pass (google.com: domain of linux-kernel+bounces-199327-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: [PATCH] media: mediatek: jpeg: support 34bits
From: Daniel Almeida <daniel.almeida@collabora.com>
In-Reply-To: <20240327040145.7155-1-jianhua.lin@mediatek.com>
Date: Mon, 3 Jun 2024 11:57:15 -0300
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
 matthias.bgg@gmail.com,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 Linux Media Mailing List <linux-media@vger.kernel.org>,
 linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 linux-mediatek@lists.infradead.org,
 Project_Global_Chrome_Upstream_Group@mediatek.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <D76FE1CB-1EF9-4F38-8D73-F3E0D7942A6C@collabora.com>
References: <20240327040145.7155-1-jianhua.lin@mediatek.com>
To: Jianhua Lin <jianhua.lin@mediatek.com>

Hi Jianhua,


> + ret =3D of_property_read_u32(pdev->dev.of_node, "mediatek,34bits",
> + &jpeg->support_34bit);
> + if (ret !=3D 0) {
> + dev_info(&pdev->dev, "default for 32bits");
> + jpeg->support_34bit =3D 0;
> + }
> + dev_info(&pdev->dev, "use 34bits: %d", jpeg->support_34bit);
> +

Please use of_property_read_bool instead.


> enc_get_file_size(void __iomem *base, u32 support_34bit)
> {
> - return readl(base + JPEG_ENC_DMA_ADDR0) -
> + u32 value =3D 1;
> +
> + if (support_34bit)
> + value =3D 4;
> +
> + return readl(base + JPEG_ENC_DMA_ADDR0) * value -
>       readl(base + JPEG_ENC_DST_ADDR0);
> }

Please use the ternary operator instead, there=E2=80=99s no need for two =
assignments.

Can you please add a comment inline to explain why this multiplier is =
needed?


> EXPORT_SYMBOL_GPL(mtk_jpeg_enc_get_file_size);
> @@ -75,6 +80,9 @@ void mtk_jpeg_enc_start(void __iomem *base)
>=20
> value =3D readl(base + JPEG_ENC_CTRL);
> value |=3D JPEG_ENC_CTRL_INT_EN_BIT | JPEG_ENC_CTRL_ENABLE_BIT;
> + value |=3D JPEG_ENC_CTRL_RDMA_PADDING_EN;
> + value |=3D JPEG_ENC_CTRL_RDMA_RIGHT_PADDING_EN;
> + value &=3D ~JPEG_ENC_CTRL_RDMA_PADDING_0_EN;
> writel(value, base + JPEG_ENC_CTRL);
> }

These do not have to be gated by =E2=80=9Csupport_34bit=E2=80=9D ?

=E2=80=94 Daniel=