Received-SPF: pass (google.com: domain of linux-kernel+bounces-199329-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 3 Jun 2024 16:59:51 +0200
From: Petr Mladek <pmladek@suse.com>
To: "gxxa03070307@gmail.com" <gxxa03070307@gmail.com>
Cc: "john.ogness" <john.ogness@linutronix.de>,
	rostedt <rostedt@goodmis.org>,
	senozhatsky <senozhatsky@chromium.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	fengqi <fengqi@xiaomi.com>,
	=?utf-8?B?6auY57+U?= <gaoxiang19870307@163.com>
Subject: Re: [PATCH] printk: Increase PRINTK_PREFIX_MAX and the buf size in
 print_caller.
Message-ID: <Zl3aZ1bfsUyX-7I4@pathway.suse.cz>
References: <20240527091929.316471-1-gxxa03070307@gmail.com>
 <ZlSewPTyQ-jMpW5n@pathway.suse.cz>
 <87y17tktze.fsf@jogness.linutronix.de>
 <1717404421510.qmo40jy5kubcunlrdknzajsf@android.mail.163.com>
 <Zl26LDOV_v946kOv@pathway.suse.cz>
 <1717420513010.hwqncbrma24lbz30knw4rdzi@android.mail.163.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1717420513010.hwqncbrma24lbz30knw4rdzi@android.mail.163.com>

On Mon 2024-06-03 21:15:13, gxxa03070307@gmail.com wrote:
> https://android.googlesource.com/kernel/common/+/refs/heads/android15-6.6/kernel/printk/printk.c
> We are based on google source code development, this is the link to google source code printk.c, which adds trace_android_vh_printk_caller, if we want to change the buf size must first merge into linux main line.

trace_android_vh_printk_caller() is not in the mainline
=> there is no reason to change the buffer size in the mainline.

You might try to get the change of the buffer size into the android
google sources.

If you want an upstream support then please try to upstream
the entire solution.

But the use of trace_android_vh_printk_caller() is a hack. And upstream
will not support such hacks.

Best Regards,
Petr


> gxxa03070307@gmail.com
> 邮箱：gxxa03070307@gmail.com
> ---- Replied Message ----
> From Petr Mladek<pmladek@suse.com> Date 06/03/2024 20:42 To gxxa03070307@gmail.com Cc john.ogness<john.ogness@linutronix.de>、rostedt<rostedt@goodmis.org>、senozhatsky<senozhatsky@chromium.org>、linux-kernel<linux-kernel@vger.kernel.org>、fengqi<fengqi@xiaomi.com>、高翔<gaoxiang19870307@163.com> Subject Re: [PATCH] printk: Increase PRINTK_PREFIX_MAX and the buf size in print_caller. 
> On Mon 2024-06-03 16:47:01, gxxa03070307@gmail.com wrote: 
> > I need to populate the temporary variable "caller" in "print_caller" func with the additional information. And it's no use defining a buf in out-of-tree patch. 
> > In out-of-tree patch, I can only add hooks (special cases), I can't change anything else, because it needs to be consistent with mainline linux. 
> > caller buf in mainline linux is it better to make the buf bigger and leave some space? 
> I do not understand. Why the buffer size has to be consistent with 
> mainline linux? 
> Really, it does not make much sense to upstream just this part 
> of your out-of-tree patch? 
> Best Regards, 
> Petr