Received-SPF: pass (google.com: domain of linux-kernel+bounces-199332-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 3 Jun 2024 11:00:28 -0400
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." <linux-mmc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>, imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml
Message-ID: <Zl3ajFd05VKULEyO@lizhi-Precision-Tower-5810>
References: <20240531193745.1714046-1-Frank.Li@nxp.com>
 <b78b14c7-e71c-4403-a606-80564a31e107@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b78b14c7-e71c-4403-a606-80564a31e107@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vypXhQdWk0ZAfBtgjGiPFcArEzwOSNN8u+l8axGF8oeZ/s2rL1Z008gkxxu9?=
 =?us-ascii?Q?khgF7++jiASO4+XEIGEXTMwUdsZIO/CzYhAtxFRgC8iN1rMjAhCISDeAi7pm?=
 =?us-ascii?Q?KrU36CcRbI6U9nRT5CDGvz3qQWdREMvbI0AdUvJNLGI7QIml01VL5uwVp81s?=
 =?us-ascii?Q?EKOvKORvMyaW4HV/uKFgz1w/FOAemMCXARnM/xpFrktROdCI7x9ABV8asBl0?=
 =?us-ascii?Q?BH+CyBlbDrxCK+Az11qTMy/jESV8SY9gJWd8bON+ei9pUdDE3csFDIKEfkTB?=
 =?us-ascii?Q?pyjGTuwHPOrSptNQ+DVze/3E5ezsoJ2TRG0/dcxCbYEfQdx38aIfPh/b+mOM?=
 =?us-ascii?Q?RAn3Gfr9mlilM0tkVyXqcNneZEBL0QnwAx56XVkDh3Dr1r+AT+nQ78H7+0mU?=
 =?us-ascii?Q?TEk7gl+iLSamGzCSwt0ogxBcgt16DyBM+DftjokLosRgdPG6BNzIou6MJaVI?=
 =?us-ascii?Q?+jh6KL7kK+50fZbSzmyXfnagBd6ILlv/Pgl1AQCwxM/d2Xt0q0GQX501UwSF?=
 =?us-ascii?Q?tCw36SpmuAhh+XdsIu0SREVIJMUbBKmzdNWpnUhKl9T8TWSO9hmPIo1LSfqf?=
 =?us-ascii?Q?JvW42vLqUzYyjGhuEQNE7WmYwdDwrk5DOCy59afnLJf1ZSK4dt8FRiBSfJSb?=
 =?us-ascii?Q?QC4DBLlyJuFtteClOBfMyVACOM2DU9FCyUVUtGLq0xSgVVGYajAxSeCOapaW?=
 =?us-ascii?Q?Jxjvz4TH3nhQZPzxGn5d/R61UVTs305i/JAdKSBAW9VJZh8/6WRz9/ghnSOZ?=
 =?us-ascii?Q?HWOdRVNFyZQuVO+dPB2h1bjw95UlUQmu3B1ye8nQ1xFguKuzQt1KyWn196CW?=
 =?us-ascii?Q?KaUnzEtw9aBYDyXPQ+D3TYmcrenGdTWuIcjVFtYi9iR9/mLTi7OA8P11DFLH?=
 =?us-ascii?Q?O0bs3Uf/l93NImvCcFs+I/OVf4FUCaWAHUSM3zI7mxiy5O4ZF6hJmBY74y9G?=
 =?us-ascii?Q?Qv/P4CH8VwdNggKUZCMnpoDzNb57M8KQ7wRjkM1hSXSHxY+nqtiHX6c8cXs5?=
 =?us-ascii?Q?OOHPVw8pShM8uX42sbHgGhdTMdl1V79+9TgYOdycboBRxc9Nu7h/WTB/TM2e?=
 =?us-ascii?Q?MxozLYxsrv/zi09jlllrqfEWtRjqcGjZlVnc58v3RIfmcgbhFXusZz3M6w00?=
 =?us-ascii?Q?/AgvT+iErolUDLr6xa2A84X/J4bytYvm30MhOdN657yRdemE8B2Kk135vBWG?=
 =?us-ascii?Q?rCsgaks/s4652vE9E1klnlBB2ddP4kjrhsn157oay5503T0GWjYGO/OZl3iX?=
 =?us-ascii?Q?bDHuTV5MpldMaD5GLvURQFj2NNBxKdoYbZDtJA4+zCJEOkDdYkCm1Es35hvy?=
 =?us-ascii?Q?TBavFbnd2wgLtJ6JGOK9BvwsHMr9OHlhc8ie23PGacFbsZp1ksJmBEchIhpS?=
 =?us-ascii?Q?SaK/aKLSCUr5dN9kVYMLk/HvqOnohAm0buFuRQkptFVAoLg36b4usLLK2s7z?=
 =?us-ascii?Q?yPRbCPKmgHKj4cH5p8dMOo/OQHFW6O6W0GN9ZkplseM0E6JeiTtUuUI5S9/r?=
 =?us-ascii?Q?ft5dG1vUSd3KZxSaFvDQ04Omuwi+PabKCAlDze4p5mB1ddJvnmUT/6axH/oq?=
 =?us-ascii?Q?RR03HPLYjmdtyd8hcGiBY9ifHoVuQkGUuatUUvOj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74fbf25a-4c36-4b5d-d85e-08dc83ddec85
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 15:00:35.9827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JFFGSzyCRO8VOpwDU3LdgaO1ik3prMVr9kZ1braOsEgP732Thf6/0g2CqppGmJRhSSM40pOW8A/9cIEXMzXsgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7050

On Sat, Jun 01, 2024 at 05:25:46PM +0200, Krzysztof Kozlowski wrote:
> On 31/05/2024 21:37, Frank Li wrote:
> > Convert layerscape fsl-esdhc binding doc from txt to yaml format.
> > 
> > Addtional change during convert:
> > - deprecate "sdhci,wp-inverted", "sdhci,1-bit-only".
> > - Add "reg" and "interrupts" property.
> > - change example "sdhci@2e000" to "mmc@2e000".
> > - compatible string require fsl,<chip>-esdhc followed by fsl,esdhc to match
> > most existed dts file.
> > 
> 
> 
> > -};
> > diff --git a/Documentation/devicetree/bindings/mmc/fsl-ls-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-ls-esdhc.yaml
> > new file mode 100644
> > index 0000000000000..cafc09c4f1234
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/fsl-ls-esdhc.yaml
> 
> Filename: fsl,esdhc.yaml

There is fsl-imx-esdhc.yaml for freescale imx esdhc. If use "fsl,esdhc.yam",
it may confuse user, which will cover imx chips also, actually it is only
used for layerscape chips.

Frank

> 
> > @@ -0,0 +1,98 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> 
> ...
> 
> > +  clock-frequency:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: specifies eSDHC base clock frequency.
> > +
> > +  sdhci,wp-inverted:
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +    deprecated: true
> > +    description:
> > +      specifies that eSDHC controller reports
> > +      inverted write-protect state; New devices should use the generic
> > +      "wp-inverted" property.
> > +
> > +  sdhci,1-bit-only:
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +    deprecated: true
> > +    description:
> > +      specifies that a controller can only handle
> > +      1-bit data transfers. New devices should use the generic
> > +      "bus-width = <1>" property.
> > +
> > +  sdhci,auto-cmd12:
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +    description:
> > +      specifies that a controller can only handle auto CMD12.
> > +
> > +  voltage-ranges:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
> > +    items:
> > +      items:
> > +        - description: specifies minimum slot voltage (mV).
> > +        - description: specifies maximum slot voltage (mV).
> > +
> > +  little-endian:
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +    description:
> > +      If the host controller is little-endian mode, specify
> > +      this property. The default endian mode is big-endian.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> 
> clock-frequency was required. Isn't it required now?
> 
> > +
> > +allOf:
> > +  - $ref: sdhci-common.yaml#
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    mmc@2e000 {
> > +        compatible = "fsl,mpc8378-esdhc", "fsl,esdhc";
> > +        reg = <0x2e000 0x1000>;
> > +        interrupts = <42 0x8>;
> > +        interrupt-parent = <&ipic>;
> > +        /* Filled in by U-Boot */
> > +        clock-frequency = <0>;
> 
> Please provide complete (final) example.
> 
> > +        voltage-ranges = <3300 3300>;
> > +    };
> 
> Best regards,
> Krzysztof
>