Received-SPF: pass (google.com: domain of linux-kernel+bounces-199335-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 3 Jun 2024 17:03:17 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Frederic Weisbecker <frederic@kernel.org>,
	Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tick: shift tick_nohz_switch_to_nohz() from
 tick_check_oneshot_change() to hrtimer_run_queues()
Message-ID: <20240603150317.GB388@redhat.com>
References: <20240530124203.GA26990@redhat.com>
 <20240602102007.GA27454@redhat.com>
 <87jzj6789b.ffs@tglx>
 <20240603134100.GA388@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240603134100.GA388@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)

On 06/03, Oleg Nesterov wrote:
>
> On 06/03, Thomas Gleixner wrote:
> >
> > On Sun, Jun 02 2024 at 12:20, Oleg Nesterov wrote:
> > > @@ -1891,8 +1891,11 @@ void hrtimer_run_queues(void)
> > >  	 * there only sets the check bit in the tick_oneshot code,
> > >  	 * otherwise we might deadlock vs. xtime_lock.
> > >  	 */
> > > -	if (tick_check_oneshot_change(!hrtimer_is_hres_enabled())) {
> > > -		hrtimer_switch_to_hres();
> > > +	if (tick_check_oneshot_change()) {
> > > +		if (hrtimer_is_hres_enabled())
> > > +			hrtimer_switch_to_hres();
> > > +		else
> > > +			tick_nohz_switch_to_nohz();
> >
> > hrtimers have no business with tick_nohz_switch_to_nohz(),
> > really. That's a strict tick/nohz specific thing. hrtimers do not care
> > about NOHZ much. They care about whether they can switch to high
> > resolution mode.
>
> OK, lets forget this patch then.
>
> But note that the comment above the tick_check_oneshot_change() says
> "switch to highres and / or nohz mode".

But yes, please forget this patch ;)

Currently hrtimer_run_queues() doesn't return if tick_check_oneshot_change()
itself calls tick_nohz_switch_to_nohz() and returns 0.

Oleg.