Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756288AbYBDWIR (ORCPT ); Mon, 4 Feb 2008 17:08:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752118AbYBDWID (ORCPT ); Mon, 4 Feb 2008 17:08:03 -0500 Received: from smtp-out0.tiscali.nl ([195.241.79.175]:59201 "EHLO smtp-out0.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbYBDWIB (ORCPT ); Mon, 4 Feb 2008 17:08:01 -0500 Message-ID: <47A78CBB.2090401@tiscali.nl> Date: Mon, 04 Feb 2008 23:07:55 +0100 From: Roel Kluin <12o3l@tiscali.nl> User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: len.brown@intel.com, ibm-acpi@hmh.eng.br CC: ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org, lkml Subject: [drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED) Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 30 in drivers/misc/thinkpad_acpi.c: 4137-4142 it reads: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */ else if (level & TP_EC_FAN_FULLSPEED) level |= 4; /* safety min speed 4 */ Note the duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should this be replaced by if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */ else level |= 4; /* safety min speed 4 */ or if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */ if (level & TP_EC_FAN_FULLSPEED) level |= 4; /* safety min speed 4 */ ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/