Received-SPF: pass (google.com: domain of linux-kernel+bounces-199356-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>,
	imx@lists.linux.dev (open list:FREESCALE eDMA DRIVER),
	dmaengine@vger.kernel.org (open list:FREESCALE eDMA DRIVER),
	linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev
Subject: [PATCH v2 1/2] dmaengine: fsl-edma: request per-channel IRQ only when channel is allocated
Date: Mon,  3 Jun 2024 11:23:15 -0400
Message-Id: <20240603152317.69917-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6xrbuavkf1eqPdjqNYSrGogdI9GcMcA5JsP9+4hZS0m6hCX+x1W48WhHXqFY?=
 =?us-ascii?Q?J0AW+b/BLUScv2syKUkgUUCN5D510GiAkLkUsnjGHvl4Szy3nAXSHhSqRgYv?=
 =?us-ascii?Q?wYSOOmJ6WI92xqhRT72zd3WitkCyRGhY11acVu4BvSuGIdfspBjWo+/0Eslx?=
 =?us-ascii?Q?EMVmY0e2jS1SatR5uOhxhksmiTRyxIcG0tTfRNJhbopXsi0NS+/kOWSGKYAN?=
 =?us-ascii?Q?7UEvocP1YGBsq0Zc0anOuQEcjVhJJ2YUjX1CxLF3QoFjgcrNVK9bNVzIvEDF?=
 =?us-ascii?Q?qCZ0qqmmqL6Z5dLRfP8X/eoAvXAngHp2/Oj+kpVmwaUEUtoFSh5TNImeLG2r?=
 =?us-ascii?Q?iglR/prktzlleoeP9rvVeQaiSLl2JkgZ40Mf/eqv1vqNbQmWjQsyHNkoSx59?=
 =?us-ascii?Q?6xo+utCqb2bcEuiSu95BdjZRlXjd40A/Tlx1V2zGrOYYHii9i3VToZFPg19/?=
 =?us-ascii?Q?a5kzdjCKO4A2uanL8CX1pnjKhmJ39UXC1B8ZCa/6agZ3rERntJYHCDyAhXXy?=
 =?us-ascii?Q?Hbq1/IDEWaUPqvk0jG4w2Ew+Ii1B1xZNyplbG3tErqQWlq49WO3UtlNL4n3M?=
 =?us-ascii?Q?JslLQh/TuN5uIjqfUJofxA/zdpbQOlxmBPhQlGdT+CucmiqRgSd0BxHpFM9i?=
 =?us-ascii?Q?5h7Vgkq0R7s7LGv6phI93IIHqC1pbEG0WoR/sv/eECaZXFa3Oh8X7S8CDWzs?=
 =?us-ascii?Q?hY49uT3oAovm1hP36JAJG5q8c/FsTNERYW4xQO9dc9m/r0eRLy4GRo7jCYR6?=
 =?us-ascii?Q?m4GaUXlKS239zEnhNI1wubCjCPurN59kyr86uvCHe5g/x6QCmu8B/xnPA7FR?=
 =?us-ascii?Q?Ih7DbuRvccvVNLo+zsRFa9Fi+c2bhxudlQiCUW0/V3XCc9Z+GKJi+nevi7rh?=
 =?us-ascii?Q?+jjyq6d90ncfyCnm0VY9a0JLDl9aD9D8GR01SVXyU8LeFmxzIpbu3gh9Cl3a?=
 =?us-ascii?Q?S+3u9keCXZ6p6VTzSYKhPSOXuEhXeS2m3nld9z/8osRLX+LduEpdXQRJdtJ0?=
 =?us-ascii?Q?H+LSgRyBWbvDurjIjqQlecVGX0W51MfX7KNb3oL5R8fbnZ6dG2q+73L4dDIP?=
 =?us-ascii?Q?qnPSVhAbvg6LFATnkwhIOLmaPPMrZxcq5eF7DsElqBvXi3UXHR5gymJeu+fT?=
 =?us-ascii?Q?zYwzRMFY2go5VSUoWG5TLJX4jA1/J01szI8hajofdOh4ubyPIAZgfYIXnzju?=
 =?us-ascii?Q?moby03XN6pI0dkpSuJDyU/D1fhR4kM3TmYbXziFpeKBL4ixt9oyEFRwDkOZI?=
 =?us-ascii?Q?ErNJspcpQ61O10YV7WqorFH6wWqZ8OivFTYnrPMAxBI0ORidwXnwqCQE6QsF?=
 =?us-ascii?Q?6maxjZ2w9CfUNof9NFUiO/P5uF6X2shcWOY5DTLBW8mfR0MsgLPzdcf88BXV?=
 =?us-ascii?Q?RmndRT+55aEb2n/x47pFkj6RoWllACArR32LVx91vFW71unx+HjO2u3aUIpU?=
 =?us-ascii?Q?8pjXo9xnqg5emr6d6+iulyGOb3gKbNfl8ik9KMtA4CfKVh1JAe6v5kQ+ayLT?=
 =?us-ascii?Q?zc6miUtteYG5lc/BJf/t/FD2Hgo0cx9W4aXL4EJEvZSxAQUfcdudJgPVLbOM?=
 =?us-ascii?Q?Rp3Ue5ggsASKcpxSR2SytbOxAnlgNWT+mKPJX0XC?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c191bbc-fc3e-4e9f-eb1a-08dc83e11ec0
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 15:23:28.7925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: So0bVwWmhB5IX3JFrJzxcwZeqdpQLB+TTO8QL6OQHfCgZP/hPi+YQiSZ1Q0+hxpidxxTaxHzcEri15sisAZ/zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9243

The edma feature individual IRQs for each DMA channel at some devices.
Given the presence of numerous eDMA instances, each with multiple channels,
IRQ request during probe results in an extensive list at /proc/interrupts.
However, a significant portion of these channels remains unused by the
system.

Request irq only when a DMA client driver requests a DMA channel.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v1 to v2
    - none

 drivers/dma/fsl-edma-common.c | 15 +++++++++++++++
 drivers/dma/fsl-edma-common.h |  1 +
 drivers/dma/fsl-edma-main.c   | 29 +++++++++++++++--------------
 3 files changed, 31 insertions(+), 14 deletions(-)

diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index ac04a2ce4fa1f..91a4c11b7cbfd 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -805,6 +805,7 @@ void fsl_edma_issue_pending(struct dma_chan *chan)
 int fsl_edma_alloc_chan_resources(struct dma_chan *chan)
 {
 	struct fsl_edma_chan *fsl_chan = to_fsl_edma_chan(chan);
+	int ret;
 
 	if (fsl_edma_drvflags(fsl_chan) & FSL_EDMA_DRV_HAS_CHCLK)
 		clk_prepare_enable(fsl_chan->clk);
@@ -813,6 +814,17 @@ int fsl_edma_alloc_chan_resources(struct dma_chan *chan)
 				fsl_edma_drvflags(fsl_chan) & FSL_EDMA_DRV_TCD64 ?
 				sizeof(struct fsl_edma_hw_tcd64) : sizeof(struct fsl_edma_hw_tcd),
 				32, 0);
+
+	if (fsl_chan->txirq) {
+		ret = request_irq(fsl_chan->txirq, fsl_chan->irq_handler, IRQF_SHARED,
+				 fsl_chan->chan_name, fsl_chan);
+
+		if (ret) {
+			dma_pool_destroy(fsl_chan->tcd_pool);
+			return ret;
+		}
+	}
+
 	return 0;
 }
 
@@ -832,6 +844,9 @@ void fsl_edma_free_chan_resources(struct dma_chan *chan)
 	fsl_edma_unprep_slave_dma(fsl_chan);
 	spin_unlock_irqrestore(&fsl_chan->vchan.lock, flags);
 
+	if (fsl_chan->txirq)
+		free_irq(fsl_chan->txirq, fsl_chan);
+
 	vchan_dma_desc_free_list(&fsl_chan->vchan, &head);
 	dma_pool_destroy(fsl_chan->tcd_pool);
 	fsl_chan->tcd_pool = NULL;
diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
index dfbdcc922ceea..c5a766da02b88 100644
--- a/drivers/dma/fsl-edma-common.h
+++ b/drivers/dma/fsl-edma-common.h
@@ -172,6 +172,7 @@ struct fsl_edma_chan {
 	int                             priority;
 	int				hw_chanid;
 	int				txirq;
+	irqreturn_t			(*irq_handler)(int irq, void *dev_id);
 	bool				is_rxchan;
 	bool				is_remote;
 	bool				is_multi_fifo;
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index a1c3c4ed869c5..82ac56be2d832 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -65,6 +65,13 @@ static irqreturn_t fsl_edma3_tx_handler(int irq, void *dev_id)
 	return IRQ_HANDLED;
 }
 
+static irqreturn_t fsl_edma2_tx_handler(int irq, void *devi_id)
+{
+	struct fsl_edma_chan *fsl_chan = devi_id;
+
+	return fsl_edma_tx_handler(irq, fsl_chan->edma);
+}
+
 static irqreturn_t fsl_edma_err_handler(int irq, void *dev_id)
 {
 	struct fsl_edma_engine *fsl_edma = dev_id;
@@ -228,7 +235,6 @@ fsl_edma_irq_init(struct platform_device *pdev, struct fsl_edma_engine *fsl_edma
 
 static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engine *fsl_edma)
 {
-	int ret;
 	int i;
 
 	for (i = 0; i < fsl_edma->n_chans; i++) {
@@ -243,13 +249,7 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
 		if (fsl_chan->txirq < 0)
 			return  -EINVAL;
 
-		ret = devm_request_irq(&pdev->dev, fsl_chan->txirq,
-			fsl_edma3_tx_handler, IRQF_SHARED,
-			fsl_chan->chan_name, fsl_chan);
-		if (ret) {
-			dev_err(&pdev->dev, "Can't register chan%d's IRQ.\n", i);
-			return -EINVAL;
-		}
+		fsl_chan->irq_handler = fsl_edma3_tx_handler;
 	}
 
 	return 0;
@@ -278,19 +278,20 @@ fsl_edma2_irq_init(struct platform_device *pdev,
 	 */
 	for (i = 0; i < count; i++) {
 		irq = platform_get_irq(pdev, i);
+		ret = 0;
 		if (irq < 0)
 			return -ENXIO;
 
 		/* The last IRQ is for eDMA err */
-		if (i == count - 1)
+		if (i == count - 1) {
 			ret = devm_request_irq(&pdev->dev, irq,
 						fsl_edma_err_handler,
 						0, "eDMA2-ERR", fsl_edma);
-		else
-			ret = devm_request_irq(&pdev->dev, irq,
-						fsl_edma_tx_handler, 0,
-						fsl_edma->chans[i].chan_name,
-						fsl_edma);
+		} else {
+			fsl_edma->chans[i].txirq = irq;
+			fsl_edma->chans[i].irq_handler = fsl_edma2_tx_handler;
+		}
+
 		if (ret)
 			return ret;
 	}
-- 
2.34.1