Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1053688lqj; Mon, 3 Jun 2024 08:50:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWgMMoGh8gGsxyp6pCTphNjtKXjKprfAe17aOqO6TDS0FyzExhap6Iz/7tZ6C/j2naCrF1F9rp0HSSo1JeU+reoa6uJO+afQoDpn7loSQ== X-Google-Smtp-Source: AGHT+IGoqHpSvVPtssOL966nj+qwudyBULaaGEVzuziebvafbpO4XSVuUoPT/vfKXESkYpgpEZAG X-Received: by 2002:aa7:8890:0:b0:702:2d79:f4e5 with SMTP id d2e1a72fcca58-702477be3bbmr11613852b3a.5.1717429831423; Mon, 03 Jun 2024 08:50:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717429831; cv=pass; d=google.com; s=arc-20160816; b=J2Gj2mfXAly7B3TOYLBg7ZLH4FGdz1rtZFkoGqka/Hd7EJ0fHpw40sdRHGgjBq2iOh 34rHwYi2vFWUyNnnf0Tmcx7UvPrY2GxopzjSZdZd7b3x//GD2QduLUFSISwQ6R7xYyCf VRTsEQipDI3aXMyRZfq1eZhgk/wMetEUbgkXNycPOzOh7iIRssUXOJkSuJG5Ac6ymmh6 jcz0Fj20XJcYhn01Y2AdUpVK9V/pHc8kpnr89YG7wr1J0947XvFZmRBX8KJPLK9tLWrd 3pNdYurSdTSxhcVcO974fOBy8zsmYA72SxCvLGQF+4M0hX/SvnsLDGH/HiZUkvfaV+oC Xq6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=GwTcq4IedeHLQXBXk1rloGqIPerrvErDu7RrUmu96H8=; fh=3h4gJYNl+4FlHA793EclK3N6TKBsUsYvxMIFXK+T/z0=; b=qkxL/PiwHG2BBFXceYW6jWluJbUjHx42B712txtYMhAsG8wDYczf4PAql8xgWTdnlr 4ufiFfAXo0bTW/B0JBgSQEq641sy1F2CNNDoZzgxFnPvMRXiuHPfHirXJL2Jc3ArnYBu Jm7dAGWA0k4Go4oXEAHxI7PSam/flsmHEQ2UGtuKocudVok9Q113GlgA7tqS2HfJCHBU eXEo8J2ErYcrsAhcyVVK2jdm5W4nVbo7WtdsqmT41ic2shmRjJYQgygcPThkslI5PKNo hOiB2Dn+2JWOyNZYRVEasPhw9bUgF8/0pnEIs7MFF+pFX+y5n45lSKyujijvUWYSZ6Zl zKRA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QEERog17; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-199389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199389-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-702423dc692si6557483b3a.6.2024.06.03.08.50.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 08:50:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QEERog17; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-199389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199389-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0E2162851CB for ; Mon, 3 Jun 2024 15:50:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D54F132111; Mon, 3 Jun 2024 15:50:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="QEERog17" Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77DDB6F2F2; Mon, 3 Jun 2024 15:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717429821; cv=none; b=nBxbg26kHQyQquQRWDXuFOYF7/aWe+zKfiXmDZwPqzngfE/JGsjbsx14WRkKygu/qNJA6VzrCXFRnNmgwtl1tBHt8I2x2Z/uQ+/CM01cfDqI+lEuageRXWzKnC+ACx2bQAkGyeFuxUuBTJoToI0ga3uUokd9McjJfFU0gGAjTOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717429821; c=relaxed/simple; bh=Rx5a8gcjyJ7ZSiIv7XBAZ+Rj0nWbBdD3FbeUn6UvyrM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sH3Ai1zPAvkvxeh7vKvnl6OC+Xty+cAD6rmwJ7jvlf3ZDq8PcZ/TBCZucDBv9u4P+uZFv+DZl6vQzpSW3QdJaTsSNLGYydQKxUJPe5HomqxSd+M6LNY9hIJUGZVtIk1v+hWsI2p/gh2SpR/HlCTJy+0xleqf7nLPcE/bmPZGxTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=QEERog17; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 7E50EE0007; Mon, 3 Jun 2024 15:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717429817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GwTcq4IedeHLQXBXk1rloGqIPerrvErDu7RrUmu96H8=; b=QEERog173eXk5OmgCX0zfGMBQMH3arOVasSjUWavLnk15brrZBeEFC8Oz8XDZQjNCkHsjR sehVeAFHi50SOMGY1ea9upKz1box4M7r2hc5W/y6lx0PVzZiaBem4vgk8nLXlR3PjYKVvO amy7jNuAtd8FPrH9koat0csVnxFiYiEEWXTMv/Sihxm/3y188V+Ntp+IkrBkWnbIcZkjGr SUmsSY1MzbRPp5V1W09OKcHTsKdriPH2aOdFUw/Z0NB5dZgr+BTLncObHzBoZf6N7iATxp BmN0CbyEQtYfnKT1LU4Mo1pS+rJF+sCWSNsRX5ZjNu3p605utwp2CfqYcqQJ5A== Date: Mon, 3 Jun 2024 17:50:14 +0200 From: Luca Ceresoli To: Dmitry Yashin Cc: Linus Walleij , Heiko Stuebner , Jianqun Xu , Jonas Karlman , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] pinctrl: rockchip: add rk3308b SoC support Message-ID: <20240603175014.6a41d3d8@booty> In-Reply-To: <20240529143534.32402-3-dmt.yashin@gmail.com> References: <20240529143534.32402-1-dmt.yashin@gmail.com> <20240529143534.32402-3-dmt.yashin@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com Hello Dmitry, On Wed, 29 May 2024 19:35:34 +0500 Dmitry Yashin wrote: > Add pinctrl support for rk3308b. This pin controller much the same as > rk3308's, but with additional iomux routes and 3bit iomuxes selected > via gpio##_sel_src_ctrl registers. Set them up in the function > rk3308b_soc_sel_src_init to use new 3bit iomuxes over some 2bit old > ones and update iomux_recalced and iomux_routes for the new SoC's. > > Fixes: 1f3e25a06883 ("pinctrl: rockchip: fix RK3308 pinmux bits") > Signed-off-by: Dmitry Yashin Thank you for adding runtime chip ID detection! Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com