Received-SPF: pass (google.com: domain of linux-kernel+bounces-199401-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <c8d765bc-4e45-40b3-a33d-b4cc1bbd67bd@amd.com>
Date: Mon, 3 Jun 2024 11:00:22 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/5] platform/chrome: cros_ec_lpc: Add a new quirk for
 ACPI id
To: Tzung-Bi Shih <tzungbi@kernel.org>, Ben Walsh <ben@jubnut.com>
Cc: Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>,
 "Dustin L. Howett" <dustin@howett.net>, Kieran Levin <ktl@frame.work>,
 =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240603063834.5580-1-ben@jubnut.com>
 <20240603063834.5580-4-ben@jubnut.com> <Zl2NTbhk96dhTV2n@google.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <Zl2NTbhk96dhTV2n@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NGIrekxzYXBEamR0dW9TUXVQdmlBS3JpeFBqYnoxT1pTUXg0K05DaElSajNH?=
 =?utf-8?B?QUllYmNHME9HNWQwMDBTdHQ5dVcrWTRRVHdvLzcvOHlqYlZXOWR1RWQ3Sm1O?=
 =?utf-8?B?ay9IVUc0WFBHT2gzejBrOUhRKzdGUW5lWW0vYmFhUEZOYlJ2QXdKRWV0K1RO?=
 =?utf-8?B?REpBNmw3U0lXYTZvZFJHcEI2QVVaVW4reWw1cXBCa2RGY1kvVE1SMlE3S2pF?=
 =?utf-8?B?V1ozOTRjOTlSWHlVUUxYZnNvOWFWMFZBSGUxeDNsN3BWMU5aQ1R1S0hQWi90?=
 =?utf-8?B?dWpqMnFSb0w1cEFQNlQyaGVyQXVRcUdkL21NbCttQzIxM0k0LytQV0w2d2wv?=
 =?utf-8?B?eVVlbVo4NktyemFlL1BhdnVCL3hFUmxTYzVJZWNaWk9vTkh0MFpnaXExQnFU?=
 =?utf-8?B?d0RzUnJ1QjhMd2JwL2tUMEJQOFd3aG1meUhndWJZVDhjNG5GV2VHVzlwVVV4?=
 =?utf-8?B?dGZxclZwZlhsci96cHJQQUJmMlhpeWJTWjVOU2p5ZVdaNzZ4aGtpeitOM3hi?=
 =?utf-8?B?RVVXZitaWm02OXV5RjNFUGVCTjlLR0t3YnExU0h0cnEvczRvNVdNWUlreXN6?=
 =?utf-8?B?a3FRMW9pQWdzTE1ZUlVwSVNuYmliQzE2WXBGeE4zRjZUWHBsekhZUVFXNFVk?=
 =?utf-8?B?MS9EWldhYlJrUFU2T1NuRXlDWTFSRStISDYwUHg2OTlaaGh1a3hMWW5xcCsv?=
 =?utf-8?B?VUZiV1J4b25yNFRiaGsyNnFuZndaVlBWU2tib1pLbzAzODRJN3QvQ0d1S1FB?=
 =?utf-8?B?SFI1SGVxcnFiYXphbUdRQmhmL2FDUi9QM2x5U0d2NmRQVjFheFgrZ0tXTjI2?=
 =?utf-8?B?REtHVkZPUjBQaGZTTTBHWjJRcThmME9ZNEtTK0FyN2pFTnNreTVTRHR3YVFT?=
 =?utf-8?B?ckt6MDliTlUvRVlmcHA4TitsWkpJWEdsdTZTTzRjYTBVd0c1NDFpMlQ3KzZa?=
 =?utf-8?B?Vm5YbGFjVHNtckZRaWdDWm80aVI4anl6ZGxuVTdFVjkzVmpqeEtDS1VBTk1G?=
 =?utf-8?B?Yi9SVllmMXpDaTYxM0JhbXByc0dUajZUT0txUm1DOXFwdzZsbVU3ZWwyamhy?=
 =?utf-8?B?UzUrVmFZbWwvdXNtd3VkcklWOEp2NXl3OWZEUnZ4N3ZKZ2xJRXIxLzhDcXpl?=
 =?utf-8?B?eU50MXlYcWtYRENYaG5zMnJOaDM3VTZFWlRnZlYzTDEvb1YyYWROV09YUXFQ?=
 =?utf-8?B?V1lRZU1ScVdCSTc0N2pTVXF5QlhDM0grOGtxcUxNTkREZEtUZkJYMFRnM1lx?=
 =?utf-8?B?UnluVU9BMEJiSTBPYnh0aTlnYnFLaXdkemRRU2duS2RwR2JmZThyL0t2RXpo?=
 =?utf-8?B?TWdwMkxIaGkvQUtpMUNNME0yMENtN0JUQ0d5SEt0eUROTnNRNk4zLzgweFUx?=
 =?utf-8?B?cS9PRkRuZlcyWUVVdWtzT2Mrdm9Jc3BOOVk1L3A4SjRxZ3BQUkNUejlXN2Jz?=
 =?utf-8?B?ZlpJOE1EdHJDNjJVRFUxWnFXRGhHTkI4UWtsT2xRUGh4WTcwL2YvZ0p5QW1k?=
 =?utf-8?B?bXF3RVd0V2t0KzAyNGVweFd5anRRdFJTU0l1S1V2RkV6U3pjNVF5OExudGRB?=
 =?utf-8?B?S053ZmZJajdWZnM3SExjTDAyUFBHWGxXVE91ZVQwcjVGOVhYYndPcjhBRS9I?=
 =?utf-8?B?Z2JLZVI5K0ZXdW5EREVUUzVYTmJ5ZTE2UGR2dDYvaXFremladHNLcmFlaVV6?=
 =?utf-8?B?YjExUXZ5d2J5UFlCd1JHR2R6bGdJVUhTZ2VQUVN6RENGMVVXMHcrWTROcGw2?=
 =?utf-8?B?bTc0QzZCY0w1UTdGQjFzbHNsSmNVR3RUZTJIZEx1NFdCMmc5WEtkYWhPUGpK?=
 =?utf-8?B?SVIyWUtEU3FLY0tXRW9ibysyb3B0aE5hWm14VUcwVE90Y3ZGZlZXM1hwUGwy?=
 =?utf-8?B?aGptem5tL2dETncxVjlJenVDTDZIMGQ4c2ZmcFdVbDdvWjI4TS9pR05scVEw?=
 =?utf-8?B?ZjZCWHdFVXAvQTBhUVRxWDh4dk9ZQzRNRm9TUVVUTUVLeU1uWUtMYXBFWEpq?=
 =?utf-8?B?NUlUQ28xY2luZkdjM0hNWTR2MkxZZEtwUElQYzdWZCtLTm1vaDRmVk9kYkhJ?=
 =?utf-8?B?cmY0SUcrdXhMTVhYclFqVFJ2aWRMUDE0MjF3bldmbkY4b1dnM2pTemxwY1hx?=
 =?utf-8?Q?TyvKTi7FDhgktP3lNyFa9lpqJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09c5e1da-fb67-442b-7d8c-08dc83e6481d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 16:00:25.7052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4EmN76CgeWSa76e2jBLU9zccGLa6UX8AIPm/KsDTumE1YDWoXVQyQ8RzTL9vMZIT7DagMi3BFFOXVB2KqqkbPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8098

On 6/3/2024 04:30, Tzung-Bi Shih wrote:
> On Mon, Jun 03, 2024 at 07:38:32AM +0100, Ben Walsh wrote:
>> @@ -436,6 +463,8 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>>   
>>   	ec_lpc->mmio_memory_base = EC_LPC_ADDR_MEMMAP;
>>   
>> +	adev = ACPI_COMPANION(dev);
>> +
> 
> The change is irrelevant to the patch.

It looks relevant to me.  The companion needs to get set before the 
quirk overwrites it.

> 
>> @@ -538,7 +577,6 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>>   	 * Connect a notify handler to process MKBP messages if we have a
>>   	 * companion ACPI device.
>>   	 */
>> -	adev = ACPI_COMPANION(dev);
>>   	if (adev) {
>>   		status = acpi_install_notify_handler(adev->handle,
>>   						     ACPI_ALL_NOTIFY,
> 
> See above comment.