Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1073664lqj; Mon, 3 Jun 2024 09:20:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVIFDgY+IXZKDGI1NkKC3GlPYd7IIK2m0aV+av4Aw5Sz1yu3uu65tLTlZt6RJ7yusK1T/eppNr9i1LG1cFrB/KfNEk3J3tIPRH2PeiuTg== X-Google-Smtp-Source: AGHT+IH1KBOvA2DPyPSkWaIIdzTw68WUfmo0zVMnhXih1DENQYxlXabgOiuaK9CM45Qyvw81n6lw X-Received: by 2002:a05:6808:16a8:b0:3ce:cd76:30bc with SMTP id 5614622812f47-3d1e3476e76mr11921357b6e.9.1717431650800; Mon, 03 Jun 2024 09:20:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717431650; cv=pass; d=google.com; s=arc-20160816; b=uuKU5lh4bsgphBSCmucfjtBcLbXieChdcv6UfWpBcxi4gjJ9kk3MvL2aietopJYYUv Z2Gp80r2/iO/pO6+isWqR59ApHhFmHWOfdSglABX+MB+faohojwIvWPhO9RT/vAZf/Ko fcTn5kVXtMCfBur4KtM/cqzmtHKJO0hMqZJXo6Gaf+aQZGyOeIrBwB/3wpAFQdYc5teL OphUsI9j7oekvvz6v4JEpKd004ffs0FhPmfMCXnnCdyQO1MwkoyGza1w0da8aHaeFUj6 y6O2W7ToVp/vPCkItc1Zm6r/XJ4bLYLAJ90xS35fgypgFpOLGmtXcGCO1Ut8AzIyYMnb EdGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=a9B+7uwm/MkuKDK5YQG4gGBGAExES3AfLJdIdJres/Q=; fh=bTtx/iPNUW9fPVZtNbtqQqryhTtAMuHwRiQ1TyzaP0I=; b=en//5ESgIJLXuMXt34Yr+Vrl8AA+cTat1CX/+rngBS9spgqD/Xi8qRB3cYBjNSO0ZM yyR74uTPZrJYAZ1euKg07lI8YdOT1yfehCt5HWEUGzCkK7opQ6s6srknq7nl1u9l0Poz WTeuGdwbPFWcLl4mfKAq6qPqit/CgmX9aVR5im0+s3XhwIo3ICv7nV+L58remODNjKuH m5CfW490hujH5RrRzGnruydvGAW/Wm1rTIODSA5VBf70Szwc8/PHz3c3NCRNoTvKxfZt jev4tG/dOQSrNsqvuykZyFT84IMunAWuy0hnK9CNXWFWoWMLLNkeZ6rSyCV2JW1qOVXx eerg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=4ioz63HV; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-199425-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199425-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-43ff23ac16csi7908461cf.82.2024.06.03.09.20.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 09:20:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199425-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=4ioz63HV; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-199425-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199425-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7EEFA1C219A3 for ; Mon, 3 Jun 2024 16:20:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE704135A71; Mon, 3 Jun 2024 16:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="4ioz63HV"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="nkifY63Y" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8534132134; Mon, 3 Jun 2024 16:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717431646; cv=none; b=RaWxLxDU8aclGnXX1D7xCiGE+VjoZwPI8cdX0IhtSqpL7eEi9wpr77FWHn/FtMsChzWuw4hfO7ns/ig0/HBw5E65EDpASORhx+Goacij/XZJfno3mSkYm2+ZCqhLHaVcRUiyYkBssJ/UHK9uZAmLzoCwzSQ0Bf/EsKyn8zidGk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717431646; c=relaxed/simple; bh=tAh8BEKe9KGyLkew/OUaE+pHQOosCHCwdAXwE/GUMU0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=KqO1Xjih7fTv8E824/uGhLwOGttOEoJzP3p1jw7yvIDlNUC06JRAkfY9n/a3CtOF/DreDiZIouFdRl2e7hG/+OVcSawdEoAdUuyerOmouCPwkMitTmXXBuTyrggRSwsaCMfpesUzCcxbAQbO4Vx+MHSenDEGc37RUoGwQkXMguQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=4ioz63HV; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=nkifY63Y; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1717431643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9B+7uwm/MkuKDK5YQG4gGBGAExES3AfLJdIdJres/Q=; b=4ioz63HVkWP70a4QHN4OIHUu2Ie5KAVQhHVpmIyI6scnRpLDG7rKqdZtcrRv/AYQDlsm0F grIY3fqgZHFeyoPcXwstRjcZYyXdMsQHzqEr72yxURbkDwU381cGyESPyzGZIkUz28dmpW 9RUJLSHq+m8dqnTPA+wviLkcfFXvXQSbjGJBfJFmo15Z0IYhaitiXD0uKzC+lM7eTwgwpB nxo4CnNoyGYDJ7jquaNADTZLn8k0M6PWTgnK2qRvZpLttW+sHLCEcyjAvVzEeu6FTSydLu tFKID6PJBbJpjWrZIoJ640ZUAhN3ssIbaTlHu7wpNc5LAUCFJwKL1OTtuBZeUA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1717431643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9B+7uwm/MkuKDK5YQG4gGBGAExES3AfLJdIdJres/Q=; b=nkifY63Yem/s1TH/4C8SaefAeBLme2UHLQFDqeVK3hXsXye4FEDoVyUdU4yfyVeBlhmjP8 GRrjjS+vVsx7XkCQ== To: Marc Zyngier , linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org, Hagar Hemdan , stable@vger.kernel.org, x86@kernel.org Subject: Re: [tip: irq/urgent] irqchip/gic-v3-its: Fix potential race condition in its_vlpi_prop_update() In-Reply-To: <86h6eakoc9.wl-maz@kernel.org> References: <20240531162144.28650-1-hagarhem@amazon.com> <171741750653.10875.4371546608500601999.tip-bot2@tip-bot2> <86h6eakoc9.wl-maz@kernel.org> Date: Mon, 03 Jun 2024 18:20:42 +0200 Message-ID: <875xuq6lr9.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Jun 03 2024 at 17:01, Marc Zyngier wrote: > On Mon, 03 Jun 2024 13:25:06 +0100, >> @@ -1992,6 +1970,8 @@ static int its_irq_set_vcpu_affinity(struct irq_data *d, void *vcpu_info) >> if (!is_v4(its_dev->its)) >> return -EINVAL; >> >> + guard(raw_spinlock_irq, &its_dev->event_map.vlpi_lock); >> + > > I don't think this compiles as is, due to the funky syntax required. Stupid me. I obviously compiled the wrong config to validate... Fixed now.