Received-SPF: pass (google.com: domain of linux-kernel+bounces-199449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240602000505.213032-1-linux@treblig.org>
In-Reply-To: <20240602000505.213032-1-linux@treblig.org>
From: Ian Rogers <irogers@google.com>
Date: Mon, 3 Jun 2024 09:32:47 -0700
Message-ID: <CAP-5=fUbtFd2V=cjSHd-KgFmrGQnncS5p7FXTNpL5kA+19qRNA@mail.gmail.com>
Subject: Re: [PATCH] perf genelf: remove unused struct 'options'
To: linux@treblig.org
Cc: peterz@infradead.org, mingo@redhat.com, jolsa@kernel.org, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 1, 2024 at 5:05=E2=80=AFPM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@google.com>

Ian

> ---
>  tools/perf/util/genelf.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index ac17a3cb59dc..c8f6bee1fa61 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -54,11 +54,6 @@ typedef struct {
>    char         name[0]; /* Start of the name+desc data */
>  } Elf_Note;
>
> -struct options {
> -       char *output;
> -       int fd;
> -};
> -
>  static char shd_string_table[] =3D {
>         0,
>         '.', 't', 'e', 'x', 't', 0,                     /*  1 */
> --
> 2.45.1
>