Received-SPF: pass (google.com: domain of linux-kernel+bounces-199448-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240602000709.213116-1-linux@treblig.org>
In-Reply-To: <20240602000709.213116-1-linux@treblig.org>
From: Ian Rogers <irogers@google.com>
Date: Mon, 3 Jun 2024 09:31:58 -0700
Message-ID: <CAP-5=fXaaDZPL44Nar9uR94QvqgiYaaDjEpM1rb1mgiU69178A@mail.gmail.com>
Subject: Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
To: linux@treblig.org
Cc: yangyicong@hisilicon.com, jonathan.cameron@huawei.com, 
	peterz@infradead.org, mingo@redhat.com, jolsa@kernel.org, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 1, 2024 at 5:07=E2=80=AFPM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@google.com>

Ian

> ---
>  tools/perf/util/hisi-ptt.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
>         u32 pmu_type;
>  };
>
> -struct hisi_ptt_queue {
> -       struct hisi_ptt *ptt;
> -       struct auxtrace_buffer *buffer;
> -};
> -
>  static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *=
buf)
>  {
>         uint32_t head =3D *(uint32_t *)buf;
> --
> 2.45.1
>