Received-SPF: pass (google.com: domain of linux-kernel+bounces-199473-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Wang, Weilin" <weilin.wang@intel.com>
To: Namhyung Kim <namhyung@gmail.com>
CC: "namhyung@google.com" <namhyung@google.com>, Namhyung Kim
	<namhyung@kernel.org>, Ian Rogers <irogers@google.com>, "Arnaldo Carvalho de
 Melo" <acme@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar
	<mingo@redhat.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, "Hunter, Adrian" <adrian.hunter@intel.com>, Kan
 Liang <kan.liang@linux.intel.com>, "linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Taylor, Perry" <perry.taylor@intel.com>,
	"Alt, Samantha" <samantha.alt@intel.com>, "Biggers, Caleb"
	<caleb.biggers@intel.com>
Subject: RE: [RFC PATCH v10 8/8] perf test: Add test for Intel TPEBS counting
 mode
Thread-Topic: [RFC PATCH v10 8/8] perf test: Add test for Intel TPEBS counting
 mode
Thread-Index: AQHasZOMbuNn7cwVHkStwuT5Ba6t6rG1I8WAgAEoKXA=
Date: Mon, 3 Jun 2024 17:00:54 +0000
Message-ID: <CO6PR11MB56353AAFC39B85C7E9310488EEFF2@CO6PR11MB5635.namprd11.prod.outlook.com>
References: <20240529064327.4080674-9-weilin.wang@intel.com>
 <20240602232041.1730256-1-namhyung@google.com>
In-Reply-To: <20240602232041.1730256-1-namhyung@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yYvJ+RIP9Fk2DcEar6IPhOJ61Qc5zJ7PoRlLj/3y2ou+lo9wNlE7U+MBK0kD?=
 =?us-ascii?Q?dDB9dxmQtaYJGi5VsEfQxMSYU+04YlTgu2S0q7BFkCh9/KZQvLfal4AHYdTw?=
 =?us-ascii?Q?M3Z5R73vp0pPFwWF8UOOSOynlgV3NUp/WMmn8Lf7Mq5V4tM6vDRICNzxIKX2?=
 =?us-ascii?Q?/zvTVvgyvqPMxQIrqt+VO4ipW90mehEZwG0BqEdQJa6/tT8bX4PwrES5HGte?=
 =?us-ascii?Q?oVfPFHtoKEk80pzzVnpaMpdcr0XzHx6LlBpLUSeLzdd/2Aq4TsxrhDqGRA0L?=
 =?us-ascii?Q?9JwcvkOGmLdFGq5lz3l7kQYaG1t9XtcKG8tITJYB6bB80LrIWK1O6zd0VnLl?=
 =?us-ascii?Q?9/rtqSKvBLI8gzC9hadI/58b7DKE6zPlKbQS4qZk2QQDeD5bwzumDemoxC/h?=
 =?us-ascii?Q?NdbhwTzyeztfJpbmPDgMynHFdEaGKj4GzZ0/ZYGaQ0Lk7k2w65EvwlBuNqy4?=
 =?us-ascii?Q?/yQqhyvH7zhc+5l4XVDUI1M9pEZBANeNqcNmLaNrEZ9lX6Hkz7Qi3366MvwK?=
 =?us-ascii?Q?U5PNr0oZxD1wwNs9ZFuWROiKLBHWtqmqfQ/Zmo68T+WWR5pGgc5LvBvcZVD3?=
 =?us-ascii?Q?vmQWVZwPXdXCuBQlzapYTdTTN2dKjYvPsBqivj1JGekqht4EmFDE1yjS8O63?=
 =?us-ascii?Q?Q/SrHjJ8ewdpBDpeitY76Jc2i8DtsmJliW6TmUEtASiCP6j4O07JKudcZF9s?=
 =?us-ascii?Q?bvM1o0IUq0CvpMDsvNokKYmO4HwyK6hkAAniPVoy0KoA2G63YQjuhaN9aqzj?=
 =?us-ascii?Q?svlGkGhrOeijL22r2Zsl4U13+qK0NejLcKB79ttZa9t80nqAtTGIn1odx+Em?=
 =?us-ascii?Q?Ao0pjDFvmm1I8dhLTMQx62ahmpARy8DNc/seKltAKIXO+gcA2aB1mUdzP4Ni?=
 =?us-ascii?Q?dLeVP7VFlSUETfQJ/zXcs8+lnrZZjGI5KEoPv7ut9T/nKiG84EITYrTFDDsi?=
 =?us-ascii?Q?sHCvyBc+CvbOWCUJ3fH0VJJBP9X4L8Zpi24u/H9UPhISi+G+c2/0H4HAh7b1?=
 =?us-ascii?Q?xl4NuXbsyXcbGK3H4k0NtpGz3g1QMYNaYOvvekodbD7vcz7DLrhfAu7uw6SH?=
 =?us-ascii?Q?gFKgwkxbxuuAKw9OIb4RKmJ5ILw8UxJi7PErDumoSN+/Zpb+0FaPQy+4o9qG?=
 =?us-ascii?Q?jCUjoNGoFL2lPdR6sJfRWI70YvkzAhB3gHs4YrJEA4ykrR9noxSm51Urldlq?=
 =?us-ascii?Q?cnkPp+MZ+com24wJ2ZUOdohpWOcA+eqNhdae6roUtlxFtxk0qMgRy0ZgkUZS?=
 =?us-ascii?Q?qovNVjYcmnFD8TmZH6mCyrQqkqBWRY1wuiknX1yNiEUhPXycNSoRpemb7HW6?=
 =?us-ascii?Q?E27POVW3Ch9eHBJ3q59Cwp9Zo0HRyF5WxAy6fARkWs+J+0frv/EdkuxBCJJX?=
 =?us-ascii?Q?Gy7cGblwy6XNUMln4mMPrVkofKryfRFmKFoZlMCd0hfMe65mDm7DLVjALSVa?=
 =?us-ascii?Q?Ygbv2tFySpjQj2LkTx8GSAneQRs6hIY4M4lVAMNHSvoz3BMdtBHQcxnJVF90?=
 =?us-ascii?Q?p5SsbR7nXyf+z8eoGrKNTO1F2xa+K8ryiOzCcuszX9ZzJ0mZ4j94c5bs88dC?=
 =?us-ascii?Q?DoEOgZv/JYoI0m3us1TB7Uxbqjaesj4qwMwqY0rd?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5635.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebc02e76-49fa-4bbd-52f5-08dc83eebb52
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 17:00:54.7388
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Jiu5L0sKU9hhhQwwSTFqHg/r7jzy9W8Ww7MSxVo8i20HdpylPC3YIkFBIOuYrKs4YhavuWNDIk53ljOdb/+NiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6866
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Namhyung Kim <namhyung@gmail.com>
> Sent: Sunday, June 2, 2024 4:21 PM
> To: Wang, Weilin <weilin.wang@intel.com>
> Cc: namhyung@google.com; Namhyung Kim <namhyung@kernel.org>; Ian
> Rogers <irogers@google.com>; Arnaldo Carvalho de Melo
> <acme@kernel.org>; Peter Zijlstra <peterz@infradead.org>; Ingo Molnar
> <mingo@redhat.com>; Alexander Shishkin
> <alexander.shishkin@linux.intel.com>; Jiri Olsa <jolsa@kernel.org>; Hunte=
r,
> Adrian <adrian.hunter@intel.com>; Kan Liang <kan.liang@linux.intel.com>;
> linux-perf-users@vger.kernel.org; linux-kernel@vger.kernel.org; Taylor, P=
erry
> <perry.taylor@intel.com>; Alt, Samantha <samantha.alt@intel.com>; Biggers=
,
> Caleb <caleb.biggers@intel.com>
> Subject: Re: [RFC PATCH v10 8/8] perf test: Add test for Intel TPEBS coun=
ting
> mode
>=20
> From: namhyung@google.com
>=20
> On Wed, 29 May 2024 02:43:24 -0400 weilin.wang@intel.com wrote:
>=20
> > From: Weilin Wang <weilin.wang@intel.com>
> >
> > Intel TPEBS sampling mode is supported through perf record. The countin=
g
> mode
> > code uses perf record to capture retire_latency value and use it in met=
ric
> > calculation. This test checks the counting mode code.
> >
> > Signed-off-by: Weilin Wang <weilin.wang@intel.com>
> > ---
> >  .../perf/tests/shell/test_stat_intel_tpebs.sh | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >  create mode 100755 tools/perf/tests/shell/test_stat_intel_tpebs.sh
> >
> > diff --git a/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> > new file mode 100755
> > index 000000000000..43f75055fee4
> > --- /dev/null
> > +++ b/tools/perf/tests/shell/test_stat_intel_tpebs.sh
> > @@ -0,0 +1,19 @@
> > +#!/bin/bash
> > +# test Intel TPEBS counting mode
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +set e
> > +err=3D0
> > +
> > +# Use this event for testing because it should exist in all platforms
> > +e=3Dcache-misses:R
> > +
> > +# Without this cmd option, default value or zero is returned
> > +echo "Testing without --enable-tpebs-recording"
> > +result=3D$(perf stat -e "$e" true 2>&1)
> > +[[ "$result" =3D~ "$e" ]] || exit 1
> > +
> > +# In platforms that do not support TPEBS, it should execute without er=
ror.
> > +echo "Testing with --enable-tpebs-recording"
> > +result=3D$(perf stat -e "$e" --enable-tpebs-recording -a sleep 0.01 2>=
&1)
> > +[[ "$result" =3D~ "perf record" && "$result" =3D~ "$e" ]] || exit 1
>=20
> I got these build errors:
>=20
Sorry about the error! I will fix it.=20

Thanks,
Weilin

> Thanks,
> Namhyung
>=20
> ---
>=20
>   TEST    tests/shell/test_stat_intel_tpebs.sh.shellcheck_log
>=20
> In tests/shell/test_stat_intel_tpebs.sh line 6:
> err=3D0
> ^-^ SC2034 (warning): err appears unused. Verify use (or export if used
> externally).
>=20
>=20
> In tests/shell/test_stat_intel_tpebs.sh line 14:
> [[ "$result" =3D~ "$e" ]] || exit 1
>                 ^--^ SC2076 (warning): Remove quotes from right-hand side=
 of =3D~ to
> match as a regex rather than literally.
>=20
>=20
> In tests/shell/test_stat_intel_tpebs.sh line 19:
> [[ "$result" =3D~ "perf record" && "$result" =3D~ "$e" ]] || exit 1
>                                               ^--^ SC2076 (warning): Remo=
ve quotes from right-
> hand side of =3D~ to match as a regex rather than literally.
>=20
> For more information:
>   https://www.shellcheck.net/wiki/SC2034 -- err appears unused. Verify us=
e
> (o...
>   https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand
> sid...
> make[4]: *** [tests/Build:91:
> tests/shell/test_stat_intel_tpebs.sh.shellcheck_log] Error 1
>=20