Received-SPF: pass (google.com: domain of linux-kernel+bounces-199489-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <2343889c-887a-49ce-86df-343737d70d37@amd.com>
Date: Mon, 3 Jun 2024 12:08:48 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 1/3] efi/x86: Fix EFI memory map corruption with kexec
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: Mike Rapoport <rppt@kernel.org>, tglx@linutronix.de, mingo@redhat.com,
 dave.hansen@linux.intel.com, x86@kernel.org, rafael@kernel.org,
 hpa@zytor.com, peterz@infradead.org, adrian.hunter@intel.com,
 sathyanarayanan.kuppuswamy@linux.intel.com, jun.nakajima@intel.com,
 rick.p.edgecombe@intel.com, thomas.lendacky@amd.com, michael.roth@amd.com,
 seanjc@google.com, kai.huang@intel.com, bhe@redhat.com,
 kirill.shutemov@linux.intel.com, bdas@redhat.com, vkuznets@redhat.com,
 dionnaglaze@google.com, anisinha@redhat.com, jroedel@suse.de,
 ardb@kernel.org, kexec@lists.infradead.org, linux-coco@lists.linux.dev,
 linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>
References: <20240528095522.509667-1-kirill.shutemov@linux.intel.com>
 <cover.1717111180.git.ashish.kalra@amd.com>
 <f4be03b8488665f56a1e5c6e6459f447352dfcf5.1717111180.git.ashish.kalra@amd.com>
 <20240603085654.GBZl2FVjPd-gagt-UA@fat_crate.local>
 <8e3dfc15-f609-4839-85c7-1cc8cefd7acc@amd.com> <Zl3HfiQ6oHdTdOdA@kernel.org>
 <1ef36309-8d7f-447b-a54a-3cdafeccca64@amd.com>
 <20240603144639.GCZl3XTwmFHwi-KUZW@fat_crate.local>
 <Zl3hwYL2GDiyUfGo@kernel.org> <7eb4ca99-679c-4f23-9562-a39b966c28a0@amd.com>
 <20240603165747.GGZl32C9yrmXJ4nhPT@fat_crate.local>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <20240603165747.GGZl32C9yrmXJ4nhPT@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U3pGTnAyZ1R5SVppT1IzL3pRcjVtWmM5WTVjeUloclRUcHVjZDRMd0xZWllJ?=
 =?utf-8?B?YlZlLzZMaTdpV3lkTnRncjdIOWV6aFl3ZjFQbWpJRllaTW8rVFNhL2Q1M2Zi?=
 =?utf-8?B?ZENQWHlUTlNvcmRyekdiWUZvM0pBRno0Y0lzMFcrUElFa2JLSzB1UmVDTjlK?=
 =?utf-8?B?UHI0TEtLa1VSNnUrQ2pJSWdSUHpCOVB2VGd0KzQ5TnB3Rm1US0FqY3lkYlhU?=
 =?utf-8?B?UCsvRCtWYnZpcnd1bEhEa011MmpXMnJ6RHRMZFo1Y3NzRFBxSEZQMDJNWjZn?=
 =?utf-8?B?bk4vRlkrOSt3VG9xMEZRMVZ3MkdMVzljMVROWldYT1N4d2I5WVRzSW9ybzYx?=
 =?utf-8?B?czhURFdvYU9hSlJxNUZ2bUorY2JXanY2WWd2b01sejlMQklLdzQrdFZDWXFH?=
 =?utf-8?B?d29CQnJMejJUWnNjcVYvbEI2aklnRjVMQnZ4UVlSUUlJVU9zTWxCQnZTL3Rx?=
 =?utf-8?B?NGdFa1E3bjE0ckpMeFlwME1aTzl5RnZFVmRxQ2JabUwrRUtta2lzRnVNQlA1?=
 =?utf-8?B?L1Z3UG1KbjNGbjdFa3NnTVVISUc4S1F1MDNmeTV4bkJJdXdhSnZoejhFQUty?=
 =?utf-8?B?dVVyK1NvelFUaXpZb1hqbnN5Mm9LVXBmNkZ4ditnNlRVMUUyU0FFaWVYWERO?=
 =?utf-8?B?a25BeExjS1gzWlhIQUp4LzFuR3grUjExc1pjMjZSU0lPNnJzZ2dUVlhNRDB6?=
 =?utf-8?B?aDJ4R2lKOUF3Q3Y1UjBYdVZlUXlqRzFPTm9RTFVzaVZpbTJRbFZQcnVraXhW?=
 =?utf-8?B?UktrSWNuQTVDclJKaVJvem9icldqMHFYSmpYM2RDK3ljRkN2bk5ldDNUdlVq?=
 =?utf-8?B?WlhUbGRmWmtkQTRBQWYyVDlQSUNodG1aT3JCcjNMU29GRG15NkM1cEhDS3Yv?=
 =?utf-8?B?dFBKM2RDRE5QRlkxejdWK0Q1NHlsd1RWVXE3OGRFdmc4YXAwb3ZNdzB4RHZM?=
 =?utf-8?B?WnVBZERCbjRlb1ZlSWIzUGhxSmQ5TG1FV1puYkVoeFNvTXdpK2FrdUczQTlw?=
 =?utf-8?B?QVhTQjduak1WcmtobDU1ZGZPMmw0MU5zbWlNenRoQkNTNjdSYnVnTzFwRFg1?=
 =?utf-8?B?ZGhXZktqSmRVSEFjVHorZWQxZUlDeTFxNld5WWVGNUx5cG03R2Y4cVR4M1FI?=
 =?utf-8?B?cVdIZUhnOGRZWDVVbDN3WlZONnE4aVVYU0N0bmNUQmxnMVUwZnZpQk90d1dJ?=
 =?utf-8?B?dFgySTdwRzgwYUNGRnFZK3JiMllYRGE5MTQxMjBkckkycG1oZ1ZLdmVoT0d0?=
 =?utf-8?B?OTh1c0oxMFBaOFVuc2lYYUxQYmFVUjdTOTI3UngyWjIrc2g1V2tvWXFQY3Ry?=
 =?utf-8?B?UWFhMGVqR0hhRkJ6K0VzNENoUktWcHdHOE5kb3FMMTBBTUpDWEovVDQ4bHBL?=
 =?utf-8?B?NmtSMjhSL2Z3Lzk3OHVZL2ptaFhDZ0U3RWhnajVzQXlISGx2bUZPS3hpL0pG?=
 =?utf-8?B?aXkzMFpiUW5iWmp4QlRhUmt1b2tMdHhBL3J5ZjV5YmJUUmJLOThsNzl6eHpj?=
 =?utf-8?B?Ykl1cHhDamVtamhIbU9McTVySjVpVm85dWtpWktGenlYMTZXZDBiU29iM0d5?=
 =?utf-8?B?WEZuNE1LT1UyZXp4OTNlTGs3Y2loVEpaeEFRdVRiVzBYcmM1S2grQmZVWVlN?=
 =?utf-8?B?eWFEQm9aQlpZL21OOEo2V0w4aDYyS2xNZjloZCs0YUNxUGVUeG40dHVnQ3dq?=
 =?utf-8?B?NkhmYVhnYUthSTB0c0VmOWp3ZStOTTlrQUFwSk5WVUo5MVdzU24rMGhtZjJX?=
 =?utf-8?B?MjRBNW02UGhUMjJpbmJucnh0ZlBhUlJnTEpWT3ppOVppNElpRUhvVngxYnFy?=
 =?utf-8?B?eVRXektqQlNiU2w5OGQzWGVZVkdXUWlNTFd6TUxUMC9KemkxcmlWUTJLWURE?=
 =?utf-8?B?aXM3cldRQjdpcmh5QzRkbHV4a2JsbkgzNzQxM0NrSVFRT2pmc0RWejI2c0xO?=
 =?utf-8?B?dUR3SXdTRmFCTmNad09aaHJDcnRPUmxabTF2emxTRGFGWmdJQ3BseDRwTkp5?=
 =?utf-8?B?a3VXeWgwOFZoa3dyQWxIcmNTa24yR1VsNGk2SGljUEdaanlPOFlRd0dWdnRx?=
 =?utf-8?B?MnIydmVIN2k4MngwZ2hZL1o3cFV5NU9qTTYzU000NFFTSjExUHRtYmU2ZFlP?=
 =?utf-8?Q?cszAxbO9UQLzXXiJCyhn+bGcj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71040401-c488-4b66-a909-08dc83efd761
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 17:08:51.4622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iXzkd9/qcbFTpX6Pi0B4J7ppG6WYtvH2vigsRxmixAP5iI5z/8YctNtEarKccAmtIaq54voiJQp/j3ZXbPsQhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6413

On 6/3/2024 11:57 AM, Borislav Petkov wrote:

> On Mon, Jun 03, 2024 at 11:48:03AM -0500, Kalra, Ashish wrote:
>> Yes, something similar as above, as efi_mem_reserve() is used to reserve
>> boot service memory and is not necessary for kexec boot.
>>
>> So, Dave Young (dyoung@redhat.com) had suggested that we skip
>> efi_arch_mem_reserve() for kexec by checking the set EFI_MEMORY_RUNTIME
>> attribute as below:a
> efi_arch_mem_reserve() or efi_mem_reserve() altogether?

efi_arch_mem_reserve().

Thanks, Ashish

>
> Btw, that below got really gibberished by your mail client. Snipped.
>