Received-SPF: pass (google.com: domain of linux-kernel+bounces-199547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9a283339-b6d1-48f0-a949-d772152bf7c1@intel.com>
Date: Mon, 3 Jun 2024 11:06:53 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] cacheinfo: Add function to get cacheinfo for a given
 (cpu, cachelevel)
To: Tony Luck <tony.luck@intel.com>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>
CC: Fenghua Yu <fenghua.yu@intel.com>, Maciej Wieczor-Retman
	<maciej.wieczor-retman@intel.com>, Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>, Babu Moger <babu.moger@amd.com>, "Drew
 Fustini" <dfustini@baylibre.com>, Dave Martin <Dave.Martin@arm.com>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
References: <20240531195720.232561-1-tony.luck@intel.com>
 <20240531195720.232561-2-tony.luck@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240531195720.232561-2-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TklQUlBrdGl2VExsdUdkVUxMUGRNU2NHNUt3NGxsUHFPUUtqRkVUbnZaU0Zt?=
 =?utf-8?B?dFNDOWlkVmptUjNmYk9sR0F3eE02WGtUTzZFbDI2d2ZjSGFvcGRDekdlaDN4?=
 =?utf-8?B?dmkySUttTHRJWm5uM1RkWEtjT0FLTTlXcHF3U2svQnVaY1ZJL0M3MWhVRnV4?=
 =?utf-8?B?QW9MM2k4dDZvb2QzY3N0dEdCckJaRElJYldXbEtlUmJGbjcxMDZJTU1SbDBV?=
 =?utf-8?B?RVBwdEliY25oZVB4eVhYT2t2a0VBQnZ2eW8rMy9US0hOOVNTeFcvYm9uNEVh?=
 =?utf-8?B?ZzFGU09mVXNUTUl5aFZ0SURKTzBPL2tWbmVDM2FnZ2RFamhRdlovYTM3bUJB?=
 =?utf-8?B?QWV0dHFDa1lidGc2OTBvaVZtN1M0ZU00WXJLYVJyQllYKzJ2cUQ2dXUyVnhM?=
 =?utf-8?B?bHhaS1NjNXlPQ1JRUXBnVlk2UjZFTU1xZHRyb1d2T090WndjZHhGdU0rSTdh?=
 =?utf-8?B?N0RQK3NJYmxyVHEyYi9uRzFtMFk1cnlxYTZ1TzEzTHlqQ2xmWm1PK2lrd0h2?=
 =?utf-8?B?WEFhMTRVUThZbXNTaURKdnQ2YWhpRWd3WU5Ma3FYK0UyVDNTTHRsTDU5OStH?=
 =?utf-8?B?a3FVRUVRRWdteStOYXpaRDhXMS9XM2VzNm5RcUZaeGs2cEZ0b0w4RnpLeDhk?=
 =?utf-8?B?VmJKc1EzY3IrOFRwU2JxUnp4NjB6Ymhmb0VGcWpnU0hqT0FQU3grdkMzMko2?=
 =?utf-8?B?TGs3MzZ2bEMyREFHdGZCNndacEJlS2h6Uzhzd0w0ZXBOaTVXc1Z2SmdyaHpk?=
 =?utf-8?B?ZkdDTXNGb3RScnlKTDdpbHhnV2Z3bHV1T1ljNGI3dXBGV0pJM2NSRjFVYXVn?=
 =?utf-8?B?YWZ6eFA4Q3llckR4b3RSSXJDbTAvdGxBeS9UNDFTMi9oLzk3S0xzenR0V2Zn?=
 =?utf-8?B?RG9sVXhURkc0cDBJMFA3WWU5TFIzZFJ3UE9pS2VMNmZoVHZ0OVN0Qm82QVlt?=
 =?utf-8?B?ZTRiZTNBOWdiQ3Qwd3dGQVAzdVVUdHRLNE5laFYrM3RuaTJiZEZFdDVPS2F2?=
 =?utf-8?B?SFRSWThXOGp3Qkoxd3Z1M3JDaGtTYVhOckh1ZVEyVk91VU8zTkdUemp5UDBt?=
 =?utf-8?B?ZHJOL2cxeFA5d2QwTThNaFRyV204eUxNc0hlNjgwYXNtWkhtSmZneHVYeG4v?=
 =?utf-8?B?cjcreTNXSEdhYUQ5NjlUSUQrQmVIUzFUM0xEWUlxaHN3ZXRXTE8zNnp2TnVM?=
 =?utf-8?B?ZFlGMmhmK0Z4ckVuUCttRUtUcjdwellDcHNCS2VnVi9wdUFuY3dlTnBSYjZJ?=
 =?utf-8?B?bE5hSGZzYWlCL3RFaGVod1VVbXNiaTZpQUlaV243UitvTXc2Um44SWp4THdy?=
 =?utf-8?B?Um5HMlRoY3F0OHpxTmJSRjY1clN0WW83cUt4TW1rME9tOWhXR2FnOW9yamgv?=
 =?utf-8?B?MWhldG9DbkRab3Q3N3A5L1NHYUF6VEpaaXpnd0xqRVN3a010bVZ4VnRVZGk2?=
 =?utf-8?B?V0Y5S2huMVFrL0R6d3BPZW5pOElJN1RBQU5rVG5NWG5FNDJSTk1ZODFTU2JD?=
 =?utf-8?B?K1RDQ081VVArcFdGNGRCTlRMSEtsanRXakdUZG9wcG1pU0M1NisrcDRqYTYv?=
 =?utf-8?B?dmNCV3dES3FMcC9GN1Yrc0R6NFY4NjdlenVnaXlrZGM4a0dYWWVlcWRlNi9x?=
 =?utf-8?B?K1pPNWNzaFBRcDNyWTRERUVjRXF3QVRYbFE2eklhQUNyUG9Cb3g4ODZtb3Fj?=
 =?utf-8?B?VFJZUVJqUzFrTDdyM3VYSWJTQ0FoRjNvM1VkOTZKdStWZmNYUlFDd09sSzdW?=
 =?utf-8?B?K2M5c2NMdFZXNFhuOUtxTFN5QUhuQ1NsWTZ5aTdnRTBDLytHNWpZcmZsQkFN?=
 =?utf-8?B?d3l0VnRoSUY1dDZyOU5mRVNKOFBtNWRjM1dnczQydUwvN3A4Z2xOUitiMTB5?=
 =?utf-8?B?d2Z0TUtnTnpvUXpGRDBieUNxV2g3Y09XYThzeVlrcndQWUVIMklURnlWeEVq?=
 =?utf-8?B?NzhHTC9RR2I4VG4yN09Wa0twOU5GMDYzUDFKWUR2T1dGWm1NY2FVZFBUQk1P?=
 =?utf-8?B?Z2pEeS9KK2ZTR0lFZ1A2ei9xWDZjU1AwUmVJQWtEZ1cwZU1WQjFqMUZXbklY?=
 =?utf-8?B?VmRIcXFNdXk4MVFwM2oweG9yWTdnaEhNRU5qYVZDc2tWSk1YbVo1V3IwWlN6?=
 =?utf-8?B?c2RuM1hsVWZDSVI3dmJLRExFWWQ3RUg4OUVQQk5FZmRzWWtJZ0FJakl0bHJK?=
 =?utf-8?B?OXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e4d13fa4-44b3-42e2-35c2-08dc83f7f441
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 18:06:55.9463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lRqA2SzkD0+rCihDuUBtvw109mV1WFn4gziNm0T9knCb+gmo79V1npxqU8e5RTzcIcS8EvnqS7CvogLZqEiJCIOxCRAGHlYN+GVvtMSyoYg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7383
X-OriginatorOrg: intel.com

Hi Tony,

On 5/31/24 12:57 PM, Tony Luck wrote:
> Resctrl code open codes a search for information about a given cache
> level in a couple of places (and more are on the way).
> 
> Provide a new inline function get_cpu_cacheinfo_level() in
> <linux/cacheinfo.h> to do the search and return a pointer to
> the cacheinfo structure.
> 
> Simplify the existing get_cpu_cacheinfo_id() by using this new
> function to do the search.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>   include/linux/cacheinfo.h | 21 ++++++++++++++++-----
>   1 file changed, 16 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/cacheinfo.h b/include/linux/cacheinfo.h
> index 2cb15fe4fe12..301b0b24f446 100644
> --- a/include/linux/cacheinfo.h
> +++ b/include/linux/cacheinfo.h
> @@ -113,10 +113,10 @@ int acpi_get_cache_info(unsigned int cpu,
>   const struct attribute_group *cache_get_priv_group(struct cacheinfo *this_leaf);
>   
>   /*
> - * Get the id of the cache associated with @cpu at level @level.
> + * Get the cacheinfo structure for cache associated with @cpu at level @level.

"for cache" -> "for the cache"?

>    * cpuhp lock must be held.
>    */
> -static inline int get_cpu_cacheinfo_id(int cpu, int level)
> +static inline struct cacheinfo *get_cpu_cacheinfo_level(int cpu, int level)
>   {
>   	struct cpu_cacheinfo *ci = get_cpu_cacheinfo(cpu);
>   	int i;
> @@ -124,12 +124,23 @@ static inline int get_cpu_cacheinfo_id(int cpu, int level)
>   	for (i = 0; i < ci->num_leaves; i++) {
>   		if (ci->info_list[i].level == level) {
>   			if (ci->info_list[i].attributes & CACHE_ID)
> -				return ci->info_list[i].id;
> -			return -1;
> +				return &ci->info_list[i];
> +			return NULL;
>   		}
>   	}
>   
> -	return -1;
> +	return NULL;
> +}
> +
> +/*
> + * Get the id of the cache associated with @cpu at level @level.
> + * cpuhp lock must be held.
> + */
> +static inline int get_cpu_cacheinfo_id(int cpu, int level)
> +{
> +	struct cacheinfo *ci = get_cpu_cacheinfo_level(cpu, level);
> +
> +	return ci ? ci->id : -1;
>   }
>   
>   #ifdef CONFIG_ARM64

Just the one nitpick from me.
Thank you.

| Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette