Date: Mon, 4 Feb 2008 15:06:38 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: yi.y.yang@intel.com, greg@kroah.com, rdunlap@xenotime.net,
       linux-kernel@vger.kernel.org
Subject: Re: 2.6.24-mm1: module params broken
Message-Id: <20080204150638.512f46ea.akpm@linux-foundation.org>
In-Reply-To: <Pine.LNX.4.64.0802042140250.8210@blonde.site>
References: <20080203171634.58ab668b.akpm@linux-foundation.org>
	<Pine.LNX.4.64.0802042140250.8210@blonde.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1515
Lines: 40

On Mon, 4 Feb 2008 21:56:54 +0000 (GMT)
Hugh Dickins <hugh@veritas.com> wrote:

> Please chuck out:
> add-new-string-functions-strict_strto-and-convert-kernel-params-to-use-them.patch
> (along with Randy's perfectly reasonable -fix.patch).
> 
> So predictable that it would just disable loading modules with params:
> Feb  4 13:17:02 blonde kernel: thinkpad_acpi: `1' invalid for parameter `experimental'
> 
> Maybe it's something as simple as a trailing whitespace issue,
> I haven't looked, would prefer the originator to do so.
> openSUSE 10.3 if that makes any difference.
> 

Takashi found a bug in it:

--- a/lib/vsprintf.c~add-new-string-functions-strict_strto-and-convert-kernel-params-to-use-them-fix-2
+++ a/lib/vsprintf.c
@@ -234,7 +234,7 @@ int strict_strto##type(const char *cp, u
 		if (ret != 0)						\
 			*res = -(*res);					\
 	} else								\
-		ret = strict_strtou##type(cp+1, base, res);		\
+		ret = strict_strtou##type(cp, base, res);		\
 									\
 	return ret;							\
 }									\
_

and I was very bad and didn't immediately prepare and upload the fix and
hence probably wasted a lot of your time, for which I apologise.  In my
defense, it was 4:00AM Sunday and I had lost eye control by then.

Does that fix fix it?  If not: patch overboard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/