Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1184732lqj; Mon, 3 Jun 2024 12:50:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXffgBxkyXV9VFLr/iNPXC8Bz2WuP2MHZBzrzWF5E81chNXnCYHxbdxowySjEiMcEr+xeFEhDDUC0WlzJXC+Hbl/uShhuYSRCswQVUuBg== X-Google-Smtp-Source: AGHT+IHLBMq06dLKSPW0lmOu+yg7ZBr8h3J987L2mTFM2pK5g14sN8uchkBwyHJlZ8sjS+r5X9al X-Received: by 2002:a9d:66c4:0:b0:6f0:37af:bf10 with SMTP id 46e09a7af769-6f911f1fc7emr10611080a34.3.1717444226188; Mon, 03 Jun 2024 12:50:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717444226; cv=pass; d=google.com; s=arc-20160816; b=nlrkpqXFtitrwp7SPHnzz04SVY/5KOh+2Aue19kkDnHOretSP41aUnufCmZa/XW1Io 7Kgrkje5lsKeXxmcQ2XATId7f/AZgn3MKCgHgZEP+yD4eGMLcQg9g9CYPC8m9yKLEyku mAe3V5HxDpdyKRqr2CzRoHK7uGRTC/gG7Htq0DGq98pNxVnVqGskY6fYrkTwq3anWVWG 1o4Tu6C7sFkqxON3/ed/K4tlvpE5cEW1iEpghx7S4uJSGdzbWGzQANMjGFa2mxE/3gi4 nDSkMru4eJ+zA7oXszDe22SsQ64qSST/0bOBdSV1d3tBS57jjqoZ48ZpvjjluIhiY+m7 Bk5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-transfer-encoding :content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:message-id:subject:cc:to:from:date; bh=99QPBddpZ3jzXllToIUzG92HUn4Go9akTgLISqIs+ic=; fh=S8a3BxB06uLFOzeO75EYnhzOY3FBB3n8tzhPlwhVqd0=; b=JSkdnCTRP9ttnTYi9k9W+yHlsDpF6MOUgzK1T6xGlkXW44+wo1uheIg4MCjTg0JKLw L3j6igUOs5qLwN+rk/UpTFEdLtm+ezKPE8Ns52Ke031KIRIAE0mxXnX5l02Dct546DhK QdntOPiEdfNl9cwSRTbBr2fPQsNkiPpUyeRTwTnpScWrw27Q1hcDKOVF5cpKBvj7vXtr 5CleWe0kvA1/8WTFMe9tpmntek88rSqikC2IedQXQMd/yj5McITl95MaX0M1Lu6UwmFl hQ0LdKkugzVvcNmGMa6YGIZPTaM7XAk3URVbHTDHtLHJPwQ/npCwpN+hJkryp4M2hluy vHEA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-199661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199661-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-794f318bc95si972760085a.528.2024.06.03.12.50.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 12:50:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-199661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199661-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CDD6E1C22137 for ; Mon, 3 Jun 2024 19:50:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2CD7313B29F; Mon, 3 Jun 2024 19:50:18 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 609D915E88; Mon, 3 Jun 2024 19:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717444217; cv=none; b=kIkpf6aj/t0zstBro6L0ozdWVzjIfSAgXnE/yGOyXwYMhPQ6yRZz0CWX3FZtJwL9/Byq3+Mdg8eVkmh/ClUoAyXaf+Cy4HVLL2yk2+U5GP4nmSXjwMABrrvOC7oD3vIOU/4y/AAtjuaw3SpwFRbO/NQ+nnFTMv2AaPbZf4EOP8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717444217; c=relaxed/simple; bh=JLCnBDX9E8BbMMfYDbpRW4ZyFGLrd1rjJXYlIEmqAlE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YgW581OF0hYgV/36yrtZbE3nb+yFah98SY647JmKPZjVN9lTgucp+eDrLWcPrir3t3euUv7dfZbu5gJu8oXQxa6d7lEeFI1NhRDZjQp8pVg/hHV/JmLz8UCYRsspb7I6LnYzL0lMT5OMjgQ/drIS/ULyS/hCeeB9A5NDZi2/LVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: fU3RGfkZRZKQ+N/lb7Qi6Q== X-CSE-MsgGUID: fSMCbNxJT26CKurgzZ2cOg== X-IronPort-AV: E=McAfee;i="6600,9927,11092"; a="14143182" X-IronPort-AV: E=Sophos;i="6.08,212,1712646000"; d="scan'208";a="14143182" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 12:50:16 -0700 X-CSE-ConnectionGUID: WKZybg/ES1iAnDYVtGu8Ig== X-CSE-MsgGUID: uLCcqS2/SlaA1gddz7WkFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,212,1712646000"; d="scan'208";a="60162013" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 12:50:14 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1sEDh5-0000000DNHk-1OC3; Mon, 03 Jun 2024 22:50:11 +0300 Date: Mon, 3 Jun 2024 22:50:11 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Erick Archer , Kees Cook , "Gustavo A. R. Silva" , Justin Stitt , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] auxdisplay: Use sizeof(*pointer) instead of sizeof(type) Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Jun 03, 2024 at 09:52:57AM +0200, Geert Uytterhoeven wrote: > On Sun, Jun 2, 2024 at 10:49 AM Erick Archer wrote: > > It is preferred to use sizeof(*pointer) instead of sizeof(type) > > due to the type of the variable can change and one needs not > > change the former (unlike the latter). This patch has no effect > > on runtime behavior. > > > > Signed-off-by: Erick Archer > > Reviewed-by: Geert Uytterhoeven Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko