Received-SPF: pass (google.com: domain of linux-kernel+bounces-199679-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: John Ogness <john.ogness@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, xu xin
 <xu.xin.sc@gmail.com>
Cc: xu.xin16@zte.com.cn, linux-kernel@vger.kernel.org,
 linux-rt-users@vger.kernel.org, liu.chun2@zte.com.cn, rostedt@goodmis.org,
 si.hao@zte.com.cn, yang.yang29@zte.com.cn, zhang.yunkai@zte.com.cn
Subject: Re: [PATCH  5.10-rt] printk: ignore that console preempted by
 irq/softirq
In-Reply-To: <20240528152933.ns7uyFSD@linutronix.de>
References: <20240523235537910_yxfGMbTcSOmMkcfuK2d8@zte.com.cn>
 <20240528064003.776618-1-xu.xin16@zte.com.cn>
 <20240528152933.ns7uyFSD@linutronix.de>
Date: Mon, 03 Jun 2024 22:17:35 +0206
Message-ID: <87cyoxeqh4.fsf@jogness.linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 2024-05-28, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> There is a `may_sleep` variable set earlier. Couldn't that be re-used?

Since the printing thread cannot preempt the softirq context and since
the printing threads are not started before @system_state is
SYSTEM_RUNNING, using @may_sleep is OK.

if (!may_sleep &&
    con->thread &&
    task_cpu(con->thread) == smp_processor_id()) {
	continue;
}

John Ogness