Received-SPF: pass (google.com: domain of linux-kernel+bounces-199668-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 3 Jun 2024 20:55:02 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Nuno =?UTF-8?B?U8Oh?= <nuno.sa@analog.com>,
 Julien Stephan <jstephan@baylibre.com>, Esteban Blanc
 <eblanc@baylibre.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] iio: add support for multiple scan types
Message-ID: <20240603205502.5e6155f4@jic23-huawei>
In-Reply-To: <11841924e4e1db49001a2fe52f5985f3c044c184.camel@gmail.com>
References: <20240530-iio-add-support-for-multiple-scan-types-v3-0-cbc4acea2cfa@baylibre.com>
	<20240602102517.438b51b8@jic23-huawei>
	<11841924e4e1db49001a2fe52f5985f3c044c184.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, 03 Jun 2024 12:25:55 +0200
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Sun, 2024-06-02 at 10:25 +0100, Jonathan Cameron wrote:
> > On Thu, 30 May 2024 10:14:07 -0500
> > David Lechner <dlechner@baylibre.com> wrote:
> >  =20
> > > Up to now, the IIO subsystem has only supported a single scan type per
> > > channel. This scan type determines the binary format of the data in t=
he
> > > buffer when doing buffered reads.
> > >=20
> > > For simple devices, there is only one scan type and all is well. But
> > > for more complex devices, there may be multiple scan types. For examp=
le,
> > > ADCs with a resolution boost feature that adds more bits to the raw
> > > sample data. Traditionally, for slow devices, we've just always used =
the
> > > highest resolution mode, but for high performance ADCs, this may not =
be
> > > always practical. Manipulating data after every read can hurt perform=
ance
> > > and in the case of hardware buffers, it may not be possible to change=
 the
> > > format of the data in the buffer at all. There are also ADCs where
> > > enabling the higher resolution can only be done if oversampling is al=
so
> > > enabled which may not be desireable.
> > >=20
> > > To allow for more flexibility, we would like to add support for multi=
ple
> > > scan types per channel.
> > >=20
> > > To avoid having to touch every driver, we implemented this in a way t=
hat
> > > preserves the existing scan_type field. See the "iio: add support for
> > > multiple scan types per channel" the details. The first couple of pat=
ches
> > > are just preparation for this.
> > >=20
> > > [1]:
> > > https://lore.kernel.org/linux-iio/CAMknhBHOXaff__QyU-wFSNNENvs23vDX5n=
_ddH-Dw3s6-sQ9sg@mail.gmail.com/ =20
> >=20
> > Nice series. Applied to the togreg branch of iio.git and pushed out as
> > testing for 0-day to poke at it.
> >=20
> > Obviously this v3 hasn't been on list that long, but there is still time
> > as I doubt I'll push out a non rebasing tree for a week or so.
> > This week is looking too busy! =20
>=20
> If there's still time, feel free to add my tag:
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>=20
Done