Received-SPF: pass (google.com: domain of linux-kernel+bounces-199696-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 3 Jun 2024 13:38:31 -0700
In-Reply-To: <CABgObfY5athiQKdV8LQt3b=yKEgydOXRdfXeLz1C8Ho=ZrqOaQ@mail.gmail.com>
Precedence: bulk
Mime-Version: 1.0
References: <98ad0dab3a2c66834e50e6d465dcae47dd80758b.1717436464.git.babu.moger@amd.com>
 <Zl4DQauIgkrjuBjg@google.com> <CABgObfY5athiQKdV8LQt3b=yKEgydOXRdfXeLz1C8Ho=ZrqOaQ@mail.gmail.com>
Message-ID: <Zl4px2yauHdvDUbR@google.com>
Subject: Re: [PATCH] KVM: Fix Undefined Behavior Sanitizer(UBSAN) error
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Babu Moger <babu.moger@amd.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 03, 2024, Paolo Bonzini wrote:
> On Mon, Jun 3, 2024 at 7:54=E2=80=AFPM Sean Christopherson <seanjc@google=
.com> wrote:
> > > However, VM boots up fine without any issues and operational.
>=20
> Yes, the caller uses kvm_handle_hva_range() as if it returned void.
>=20
> > Ah, the "break" will only break out of the memslot loop, it won't break=
 out of
> > the address space loop.  Stupid SMM.
> >
> > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> > index b312d0cbe60b..70f5a39f8302 100644
> > --- a/virt/kvm/kvm_main.c
> > +++ b/virt/kvm/kvm_main.c
> > @@ -651,7 +651,7 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hv=
a_range(struct kvm *kvm,
> >                                         range->on_lock(kvm);
> >
> >                                 if (IS_KVM_NULL_FN(range->handler))
> > -                                       break;
> > +                                       goto mmu_unlock;
> >                         }
> >                         r.ret |=3D range->handler(kvm, &gfn_range);
> >                 }
> > @@ -660,6 +660,7 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hv=
a_range(struct kvm *kvm,
> >         if (range->flush_on_ret && r.ret)
> >                 kvm_flush_remote_tlbs(kvm);
> >
> > +mmu_unlock:
> >         if (r.found_memslot)
> >                 KVM_MMU_UNLOCK(kvm);
>=20
> Yep. If you want to just reply with Signed-off-by I'll mix the
> original commit message and your patch.

Signed-off-by: Sean Christopherson <seanjc@google.com>