Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1210666lqj; Mon, 3 Jun 2024 13:47:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWxsWDZBkgJ5tYtGgc6mCjKC/pXvehOHNoZAeQYuOewnH3D0Sek+PspI3CQS+ue3G34zdLmjqrY9uKrvOQAHpRGoYL/gr6j2S+BK4g5FQ== X-Google-Smtp-Source: AGHT+IFIHhaAHtEpRoh+xqZ/bAj3sF+lKwXcf8hYfRJP38AHM40vnEIu/lcU3wnXRIf6MTfUqaF8 X-Received: by 2002:a17:90b:4d8c:b0:2c2:299b:15c6 with SMTP id 98e67ed59e1d1-2c2299b1d7emr3812926a91.40.1717447661861; Mon, 03 Jun 2024 13:47:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717447661; cv=pass; d=google.com; s=arc-20160816; b=ZwZF+Gidhj1fnfV8VkiFn3GBiCWJx9l2/lVJ0Wb05Xnpxy4CZwu7dOoMprGnmIcQRL U8QR4nQ6axZEkA79UVMsCoIeNqOqA5R38lidYDnw/EheRD1GbALu7H67ZPlM/UppnOct F/f9lFv+572TMoMs6bxGJPenaZlLE/hYx2yRxf52vBMzhJrLoxzYv0ZhebRKI32DBjxF l21tq43sWETfwAhqss0CP+MMwCou7laTxgIukmu+TPVny9LLijDlH/ruK5SlFEpo6eTD /h1hA8VsOs1B+ArAh4eIcrOPYVo4DgKQl7JIAMXRyQkuipsGC4IY1Y/K5bmrNbWtI7o/ Gp0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=K22P6pVw6lQew0ShLjP6wTvWFgi04OqG2GCN7NDO5vg=; fh=9jeIruApQe8Uw0c4AriJphXaxO9l4OG8vDpmoXNbgFU=; b=GWR+3RcFg7r288QmofrRjJtuRVK0txERXjieUB0htK46ALDXmskk1tnDTinb/CDFEp mGLOa1xFeU2DjJa/OvIYIDZjRorVyk4Ce9Goazn+7XiCm8wRqW5DYIi0BSSE8ce4vYDh XSZWWJ6WLhHFxbjtLH115pHJZ4oiFwa2Uet2Oeixq8+HbLw0bCMH29DAyskwtSFuVFx6 3xhRloZDYcdM/TksElzoqHj95YB2TUWcW45vYkf+ZRokaV8ucDqBVL2Eiv1tp3NoUleq hhUrpkbC+kvhN9h3dQcpZHmevr3zt2W25A4eSyl3yx66K/vvVpwDqEWrtFXV1IRtRD6H mx+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-199700-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199700-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c1e7203203si6457546a91.172.2024.06.03.13.47.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 13:47:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199700-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-199700-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199700-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B0D7C28996F for ; Mon, 3 Jun 2024 20:46:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53C6813B58D; Mon, 3 Jun 2024 20:46:46 +0000 (UTC) Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [176.9.242.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C614B13958C for ; Mon, 3 Jun 2024 20:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=176.9.242.62 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717447605; cv=none; b=NeKOILm8TeLKafZPvDRpABtxJhtk+j9PsdMM72ONhGLcUGA1+fGGo9dcdOBgrvtasYHBIf7et50CmybGdxTIMTM+w8IOLi9g8VM7Q/Swde4GaZkY7wOELSZlzo/8uwgyRdME/0+0ll21TwZXcAjP23oJnSMTLTo2YZ+UymPNlcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717447605; c=relaxed/simple; bh=FsvxSX/KBaDFhi+ZDmk2mVbiVY6TXD1Hp+ZfY7jSulQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nTQerzEH9QF4YM4bu0ScmD5QbSKCPki+xXhwugwaMPQemSPfQbAefB1YBJS3fJVMWK74EfuqKEBOe3aCyND/trh3nYpKaKX8aWrail9VuXZijxD5vn09wqRW6TU6Z8qBpvKsNyG50G3qP4Hjc0WSF2D0BJkWOWIOErbk9VVD2wc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=176.9.242.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 131C3100EF4A2; Mon, 3 Jun 2024 22:46:35 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id CC119FAB5C; Mon, 3 Jun 2024 22:46:34 +0200 (CEST) Date: Mon, 3 Jun 2024 22:46:34 +0200 From: Lukas Wunner To: Jason Gunthorpe Cc: Greg Kroah-Hartman , Ard Biesheuvel , linux-kernel@vger.kernel.org, patches@lists.linux.dev, "Rafael J. Wysocki" Subject: Re: [PATCH] sysfs: Add stub sysfs_bin_attr_simple_read() for !CONFIG_SYSFS Message-ID: References: <0-v1-44baae71b833+ab-sysfs_simple_read_jgg@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0-v1-44baae71b833+ab-sysfs_simple_read_jgg@nvidia.com> On Mon, Jun 03, 2024 at 02:30:45PM -0300, Jason Gunthorpe wrote: > Since the only declaration for sysfs_bin_attr_simple_read() is inside the > "#ifdef CONFIG_SYSFS". Add a stub to the #else section too. [...] > I don't see a patch for this yet, but I did find a 0-day robot complaint: > > https://lore.kernel.org/all/202404200345.eGdn5uxW-lkp@intel.com/ I already submitted a patch on May 23, but it hasn't been applied yet: https://lore.kernel.org/all/05f4290439a58730738a15b0c99cd8576c4aa0d9.1716461752.git.lukas@wunner.de/ (My patch returns 0, yours -EINVAL, but I don't think that matters.) Thanks (and sorry for the breakage)! Lukas