Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1243200lqj; Mon, 3 Jun 2024 15:08:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXFaqbnXX3BegBQSkSdl1TvVyQvXq40sJibDiedX662/02RMkw77H1i7Dgs57LMYfMFyc+LS9LqPmgv9aV8NqQ7V4rpqqLCQbNmXop4lw== X-Google-Smtp-Source: AGHT+IGrzbc8WsfIn4KPoJtoKZcEvq+inhtiOFvE4Q4CganuS0tgZP9vlFCU3mfLjFCegChUCh5D X-Received: by 2002:a05:6358:5289:b0:199:5511:4443 with SMTP id e5c5f4694b2df-19b48d78b12mr998906255d.10.1717452503348; Mon, 03 Jun 2024 15:08:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717452503; cv=pass; d=google.com; s=arc-20160816; b=dKDMc3jW+9ZqJvPPvB5UADg/U1Z7AdtjaM7q+WGMIbdHGTI1p7oIN4R21LIJcVYSYb 2ThcV6ehZMsoVbfUYH783QAWWUouTYA708H9Znl3tnF30jgYDUWJSAMih2TEsWtauWJC dXpHtciYUrXOQQxtYVW51OJxNclIzw4UHRYZy+fxxyJHxUoUXbaL1yD6sAfYJbxuYR94 u0A4zafuuCrY6K5x5fI18TNf9NIy8WWFjYyIxTdnUI8GtLiBasIGBiHGRDXoElBOVfSv 6IkIqbRtFQZmtSc+GNu0Hgr5xrh2lhYs09dqtfgI8J674mCSRk5sBZ2HpUUvt4mRHL1r zM1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=J5ncs5YXMlmcc+Cu4jooVAXUIwvu4vyhBOgiv7B+Y4M=; fh=Q3AiS3G8Pqt/tr2Mzr9pXGK39FOwu5B+jA1lq2rhXOg=; b=OiVfX6QgU8kaENXgLd7H6QKpXvRCk6TX4agklwXPdWMCnTV1BUxiktk7tTFWJAigqI kiKmuNRGWLlpaM4W2F0Q3sG0q90ElwjjnaL5zPvEJVwA+1IE/kmUX1fMxLSKHx91qohu TzVnFWM+wf3hTTejxanYjJtjj6jqDLwB+RR3zVa7i6MfDODcvbVB2mC4IftxJwH1mBhv 1ZLNEzZ3Liy6a4IfpyJviI56qx8E3YVwZTUOA/LpV2evcXUDto+g2dNmIR5mLUjIcLeo UKaMiK/blcJ1A3O5QN5EPYx/C+oRRiR8588S1KWstH0s2x2Szy7OK6C2PGFYHFFWH0+M mUNQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=ZfUo2Zmv; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-199748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199748-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c35d975b06si6929621a12.844.2024.06.03.15.08.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 15:08:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=ZfUo2Zmv; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-199748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199748-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0FFFBB259F9 for ; Mon, 3 Jun 2024 21:58:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26B7B13C827; Mon, 3 Jun 2024 21:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZfUo2Zmv" Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081491369A1 for ; Mon, 3 Jun 2024 21:58:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717451889; cv=none; b=aqB1l1W5YxTwPBXRRArr7VjT2Nucnn+xHukRSDlhRLm+vYT+9urrMMCkwu7cDnRwVbVYSJJWKvVs/a5A/57bXV/l+orj2OFY2BN6MolO8MggSX4Mq3MAkl5gwe3U6XuFsyEZgGRF5X8db6EhhijJuxsRpVOIUG+yGHpNn+dsy3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717451889; c=relaxed/simple; bh=MVpwNnNRW1Y1ytE1Vtg6j8ox35ZkDK0zKcoia68uR50=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FhGyKCoYPloBkRkQS/KfhgkMsbA2slyhfOK6uiQs5GTmxm+8RMbpFIdxnDcv/soeswrY+hfDS5PLETfk12Ly0M0KWcRFfN55kFsAreuoHFqG/9gAhiD5Q1pixE65rE2Si3O63aKSCY9alOymyH0/DyuNDxrKCTfF03wuRK/4SPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZfUo2Zmv; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: ariel.miculas@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717451878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J5ncs5YXMlmcc+Cu4jooVAXUIwvu4vyhBOgiv7B+Y4M=; b=ZfUo2Zmv0H/xTaJ9qBv8B2yInG7GCa7dXmbCSfQDLwzHDhi1QKARaXYidJMJVqFbP/7n6H gl5a01/DqrYlbhby1MlZ1O3kivxp0ZFfeSRo4wdLUfv66Jmm7v9ZiRtvKGCPfo23NMvLmF Ktcyx83OMPvj3uYuP9QuGB6gcnV28/M= X-Envelope-To: linux-bcachefs@vger.kernel.org X-Envelope-To: bfoster@redhat.com X-Envelope-To: linux-kernel@vger.kernel.org Date: Mon, 3 Jun 2024 17:57:54 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Ariel Miculas Cc: linux-bcachefs@vger.kernel.org, Brian Foster , linux-kernel@vger.kernel.org Subject: Re: [PATCH] bcachefs: bch2_btree_insert() - add btree iter flags Message-ID: References: <20240603204732.2011734-1-ariel.miculas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603204732.2011734-1-ariel.miculas@gmail.com> X-Migadu-Flow: FLOW_OUT On Mon, Jun 03, 2024 at 11:47:31PM +0300, Ariel Miculas wrote: > The commit 65bd44239727 ("bcachefs: bch2_btree_insert_trans() no longer > specifies BTREE_ITER_cached") removes BTREE_ITER_cached from > bch2_btree_insert_trans, which causes the update_inode function from > bcachefs-tools to take a long time (~20s). Add an iter_flags parameter > to bch2_btree_insert, so the users can specify iter update trigger > flags, such as BTREE_ITER_cached. > > Signed-off-by: Ariel Miculas Applied